dweiss commented on a change in pull request #1248: LUCENE-9134: Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1248#discussion_r377479333
########## File path: lucene/core/src/java/org/apache/lucene/util/automaton/createLevAutomata.py ########## @@ -22,7 +22,7 @@ import os import sys # sys.path.insert(0, 'moman/finenight/python') -sys.path.insert(0, '../../../../../../../../build/core/moman/finenight/python') +sys.path.insert(0, '../../../../../../../../../build/moman/finenight/python') Review comment: If so then we should add a fail to ant and just say "use gradle?". These python scripts could take an argument - the path to moman passed from gradle script. Then it'd be elegant and clear without those ugly relative paths. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
