[
https://issues.apache.org/jira/browse/SOLR-14252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy Webb updated SOLR-14252:
-----------------------------
Description:
The {{getMax}} and {{getMin}} methods in
[AggregateMetric|https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java]
can throw an NPE if non-{{Number}} values are present in {{values}}, when it
tries to cast a {{null}} {{Double}} to a {{double}}.
This PR prevents the NPE occurring and triggers warnings instead:
[https://github.com/apache/lucene-solr/pull/1247]
We've seen it report {{not a Number: false}} and {{not a Number:
LocalStatsCache}} - so the NPE may have been hiding other issues with metrics
gathering, which warrant further investigation.
(We've also noticed an error in the documentation - see
https://github.com/apache/lucene-solr/commit/109d3411cd3866d83273187170dbc5b8b3211d20
- this could be pulled out into a separate ticket if necessary?)
was:
The {{getMax}} and {{getMin}} methods in
[AggregateMetric|https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java]
can throw an NPE if non-{{Number}} values are present in {{values}}, when it
tries to cast a {{null}} {{Double}} to a {{double}}.
This PR prevents the NPE occurring and triggers warnings instead:
[https://github.com/apache/lucene-solr/pull/1247]
We've seen it report {{not a Number: false}} and {{not a Number:
LocalStatsCache}} - so the NPE may have been hiding other issues with metrics
gathering, which warrant further investigation.
> NullPointerException in AggregateMetric
> ---------------------------------------
>
> Key: SOLR-14252
> URL: https://issues.apache.org/jira/browse/SOLR-14252
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
> Reporter: Andy Webb
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The {{getMax}} and {{getMin}} methods in
> [AggregateMetric|https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java]
> can throw an NPE if non-{{Number}} values are present in {{values}}, when it
> tries to cast a {{null}} {{Double}} to a {{double}}.
> This PR prevents the NPE occurring and triggers warnings instead:
> [https://github.com/apache/lucene-solr/pull/1247]
> We've seen it report {{not a Number: false}} and {{not a Number:
> LocalStatsCache}} - so the NPE may have been hiding other issues with metrics
> gathering, which warrant further investigation.
> (We've also noticed an error in the documentation - see
> https://github.com/apache/lucene-solr/commit/109d3411cd3866d83273187170dbc5b8b3211d20
> - this could be pulled out into a separate ticket if necessary?)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
