[ 
https://issues.apache.org/jira/browse/SOLR-14252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy Webb updated SOLR-14252:
-----------------------------
    Description: 
The {{getMax}} and {{getMin}} methods in 
[AggregateMetric|https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java]
 can throw an NPE if non-{{Number}} values are present in {{values}}, when it 
tries to cast a {{null}} {{Double}} to a {{double}}. We've seen the values 
{{false}} 

PR: [https://github.com/apache/lucene-solr/pull/1247]

The patch adds a warning for non-{{Number}} values - we've seen it report {{not 
a Number: false}} and {{not a Number: LocalStatsCache}} - so the NPE may have 
been hiding other issues with metrics gathering, which warrant further 
investigation.

  was:
The {{getMax}} and {{getMin}} methods in 
[AggregateMetric|https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java]
 can throw an NPE if non-{{Number}} values are present in {{values}}, when it 
tries to cast a {{null}} {{Double}} to a {{double}}.

PR: [https://github.com/apache/lucene-solr/pull/1247]


> NullPointerException in AggregateMetric
> ---------------------------------------
>
>                 Key: SOLR-14252
>                 URL: https://issues.apache.org/jira/browse/SOLR-14252
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: metrics
>            Reporter: Andy Webb
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The {{getMax}} and {{getMin}} methods in 
> [AggregateMetric|https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java]
>  can throw an NPE if non-{{Number}} values are present in {{values}}, when it 
> tries to cast a {{null}} {{Double}} to a {{double}}. We've seen the values 
> {{false}} 
> PR: [https://github.com/apache/lucene-solr/pull/1247]
> The patch adds a warning for non-{{Number}} values - we've seen it report 
> {{not a Number: false}} and {{not a Number: LocalStatsCache}} - so the NPE 
> may have been hiding other issues with metrics gathering, which warrant 
> further investigation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to