[GitHub] [iceberg] pvary commented on a diff in pull request #6648: Hive: Refactor commit lock mechanism from HiveTableOperations

pvary commented on code in PR #6648: URL: https://github.com/apache/iceberg/pull/6648#discussion_r1090832378 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveLock.java: ## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [iceberg] RussellSpitzer merged pull request #6680: Core: DeleteWithFilter fails on HashCode Collision

RussellSpitzer merged PR #6680: URL: https://github.com/apache/iceberg/pull/6680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceb

[GitHub] [iceberg] RussellSpitzer closed issue #6670: Random no-op for delete for sequence of similar numeric partition values

RussellSpitzer closed issue #6670: Random no-op for delete for sequence of similar numeric partition values URL: https://github.com/apache/iceberg/issues/6670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [iceberg] RussellSpitzer commented on pull request #6680: Core: DeleteWithFilter fails on HashCode Collision

RussellSpitzer commented on PR #6680: URL: https://github.com/apache/iceberg/pull/6680#issuecomment-1408917506 Merged! Thanks @amogh-jahagirdar , @rdblue , @stevenzwu , @abmo-x , @szehon-ho, @dramaticlly . I would also again like to greatly credit Steven and Szehon for their hard wor

[GitHub] [iceberg] amogh-jahagirdar opened a new pull request, #6704: Python: Update pyproject.toml to include dev folder.

amogh-jahagirdar opened a new pull request, #6704: URL: https://github.com/apache/iceberg/pull/6704 Python: Update pyproject.toml to include dev folder. Currently, some files which are required for during release validation such as 1.) .rat-excludes 2.) scripts in the dev/

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #6704: Python: Update pyproject.toml to include dev folder.

amogh-jahagirdar commented on code in PR #6704: URL: https://github.com/apache/iceberg/pull/6704#discussion_r1090854455 ## python/pyproject.toml: ## @@ -39,11 +39,13 @@ packages = [ { from = "vendor", include = "fb303" }, { from = "vendor", include = "hive_metastore" }

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #6704: Python: Update pyproject.toml to include dev folder.

amogh-jahagirdar commented on code in PR #6704: URL: https://github.com/apache/iceberg/pull/6704#discussion_r1090854455 ## python/pyproject.toml: ## @@ -39,11 +39,13 @@ packages = [ { from = "vendor", include = "fb303" }, { from = "vendor", include = "hive_metastore" }

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #6704: Python: Update pyproject.toml to include dev folder.

amogh-jahagirdar commented on code in PR #6704: URL: https://github.com/apache/iceberg/pull/6704#discussion_r1090854455 ## python/pyproject.toml: ## @@ -39,11 +39,13 @@ packages = [ { from = "vendor", include = "fb303" }, { from = "vendor", include = "hive_metastore" }

[GitHub] [iceberg] amogh-jahagirdar opened a new pull request, #6705: Python: Update pyproject.toml to include dev folder.

amogh-jahagirdar opened a new pull request, #6705: URL: https://github.com/apache/iceberg/pull/6705 Same as https://github.com/apache/iceberg/pull/6704 but raising it against the main branch. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [iceberg] deniskuzZ commented on pull request #6653: API: Fix Transform backward compatibility in PartitionSpec

deniskuzZ commented on PR #6653: URL: https://github.com/apache/iceberg/pull/6653#issuecomment-1408949576 > I also had a workaround for this issue, see #6482. Not sure which way is more reasonable. I am ok with either solution, however, noticed a potentially no-go comment in your PR

[GitHub] [iceberg] rdblue commented on a diff in pull request #6559: Core: View core parser implementations

rdblue commented on code in PR #6559: URL: https://github.com/apache/iceberg/pull/6559#discussion_r1090873633 ## core/src/main/java/org/apache/iceberg/view/BaseSQLViewRepresentation.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [iceberg] rdblue commented on a diff in pull request #6559: Core: View core parser implementations

rdblue commented on code in PR #6559: URL: https://github.com/apache/iceberg/pull/6559#discussion_r1090874509 ## core/src/main/java/org/apache/iceberg/view/BaseSQLViewRepresentation.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [iceberg] rdblue commented on a diff in pull request #6559: Core: View core parser implementations

rdblue commented on code in PR #6559: URL: https://github.com/apache/iceberg/pull/6559#discussion_r1090876425 ## core/src/main/java/org/apache/iceberg/view/SQLViewRepresentationParser.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [iceberg] rdblue commented on a diff in pull request #6559: Core: View core parser implementations

rdblue commented on code in PR #6559: URL: https://github.com/apache/iceberg/pull/6559#discussion_r1090876982 ## core/src/main/java/org/apache/iceberg/view/SQLViewRepresentationParser.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #6703: Python: Fix warnings from PyLint

amogh-jahagirdar commented on code in PR #6703: URL: https://github.com/apache/iceberg/pull/6703#discussion_r1090884952 ## python/tests/catalog/test_glue.py: ## @@ -67,7 +67,18 @@ def get_random_databases(n: int) -> Set[str]: @pytest.fixture(name="_bucket_initialize") def fi

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #6703: Python: Fix warnings from PyLint

amogh-jahagirdar commented on code in PR #6703: URL: https://github.com/apache/iceberg/pull/6703#discussion_r1090885186 ## python/tests/catalog/test_glue.py: ## @@ -67,7 +67,18 @@ def get_random_databases(n: int) -> Set[str]: @pytest.fixture(name="_bucket_initialize") def fi

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #6703: Python: Fix warnings from PyLint

amogh-jahagirdar commented on code in PR #6703: URL: https://github.com/apache/iceberg/pull/6703#discussion_r1090885186 ## python/tests/catalog/test_glue.py: ## @@ -67,7 +67,18 @@ def get_random_databases(n: int) -> Set[str]: @pytest.fixture(name="_bucket_initialize") def fi

[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6169: AWS,Core: Add S3 REST Signer client + REST Spec

danielcweeks commented on code in PR #6169: URL: https://github.com/apache/iceberg/pull/6169#discussion_r1091005884 ## aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java: ## @@ -1119,6 +1139,54 @@ public void applyS3ServiceConfigurations(T builder) .b

[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6169: AWS,Core: Add S3 REST Signer client + REST Spec

danielcweeks commented on code in PR #6169: URL: https://github.com/apache/iceberg/pull/6169#discussion_r1091008163 ## aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java: ## @@ -1119,6 +1139,54 @@ public void applyS3ServiceConfigurations(T builder) .b

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #6169: AWS,Core: Add S3 REST Signer client + REST Spec

amogh-jahagirdar commented on code in PR #6169: URL: https://github.com/apache/iceberg/pull/6169#discussion_r1091029462 ## aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java: ## @@ -0,0 +1,311 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [iceberg] singhpk234 commented on a diff in pull request #6581: Spark 3.3: Add RemoveDanglingDeletes action

singhpk234 commented on code in PR #6581: URL: https://github.com/apache/iceberg/pull/6581#discussion_r1091048096 ## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/RemoveDanglingDeletesSparkAction.java: ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [iceberg] Fokko commented on a diff in pull request #6703: Python: Fix warnings from pytest

Fokko commented on code in PR #6703: URL: https://github.com/apache/iceberg/pull/6703#discussion_r1091126388 ## python/tests/catalog/test_glue.py: ## @@ -67,7 +67,18 @@ def get_random_databases(n: int) -> Set[str]: @pytest.fixture(name="_bucket_initialize") def fixture_s3_bu

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #6648: Hive: Refactor commit lock mechanism from HiveTableOperations

amogh-jahagirdar commented on code in PR #6648: URL: https://github.com/apache/iceberg/pull/6648#discussion_r1091134137 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveLock.java: ## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #6648: Hive: Refactor commit lock mechanism from HiveTableOperations

amogh-jahagirdar commented on code in PR #6648: URL: https://github.com/apache/iceberg/pull/6648#discussion_r1091134137 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveLock.java: ## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #6648: Hive: Refactor commit lock mechanism from HiveTableOperations

amogh-jahagirdar commented on code in PR #6648: URL: https://github.com/apache/iceberg/pull/6648#discussion_r1091141484 ## hive-metastore/src/main/java/org/apache/iceberg/hive/MetastoreLock.java: ## @@ -0,0 +1,531 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] Fokko commented on a diff in pull request #6566: Python: Add visitor to DNF expr into Dask/PyArrow format

Fokko commented on code in PR #6566: URL: https://github.com/apache/iceberg/pull/6566#discussion_r1091169965 ## python/pyiceberg/expressions/visitors.py: ## @@ -881,3 +881,82 @@ def rewrite_to_dnf(expr: BooleanExpression) -> Tuple[BooleanExpression, ...]: # (A AND NOT(B) A

[GitHub] [iceberg] Fokko commented on a diff in pull request #6566: Python: Add visitor to DNF expr into Dask/PyArrow format

Fokko commented on code in PR #6566: URL: https://github.com/apache/iceberg/pull/6566#discussion_r1091170319 ## python/pyiceberg/expressions/visitors.py: ## @@ -881,3 +881,82 @@ def rewrite_to_dnf(expr: BooleanExpression) -> Tuple[BooleanExpression, ...]: # (A AND NOT(B) A

[GitHub] [iceberg] danielcweeks opened a new pull request, #6707: Mark updated auth fields volatile for refresh

danielcweeks opened a new pull request, #6707: URL: https://github.com/apache/iceberg/pull/6707 The fields updated in the background during auth refresh should be marked as volatile. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [iceberg] jackye1995 commented on pull request #6660: Flink: Support writes to branches in FlinkSink

jackye1995 commented on PR #6660: URL: https://github.com/apache/iceberg/pull/6660#issuecomment-1409461416 > A long time ago, I raised a related https://github.com/apache/iceberg/pull/5029 to do this, if you can, can you take a look? Thanks, marking that as a part of the milestone!

[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6648: Hive: Refactor commit lock mechanism from HiveTableOperations

jackye1995 commented on code in PR #6648: URL: https://github.com/apache/iceberg/pull/6648#discussion_r1091253698 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveLock.java: ## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #6682: Bulk delete

RussellSpitzer commented on code in PR #6682: URL: https://github.com/apache/iceberg/pull/6682#discussion_r1091266052 ## core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java: ## @@ -149,6 +164,45 @@ public void deletePrefix(String prefix) { } } + @Override +

[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #6682: Bulk delete

RussellSpitzer commented on code in PR #6682: URL: https://github.com/apache/iceberg/pull/6682#discussion_r1091266052 ## core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java: ## @@ -149,6 +164,45 @@ public void deletePrefix(String prefix) { } } + @Override +

[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #6682: Bulk delete

RussellSpitzer commented on code in PR #6682: URL: https://github.com/apache/iceberg/pull/6682#discussion_r1091268114 ## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/BaseSparkAction.java: ## @@ -85,6 +88,7 @@ private static final Logger LOG = LoggerFactory

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #6638: Spark: REPLACE BRANCH SQL implementation

amogh-jahagirdar commented on code in PR #6638: URL: https://github.com/apache/iceberg/pull/6638#discussion_r1091273786 ## spark/v3.3/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateOrReplaceBranchExec.scala: ## @@ -0,0 +1,89 @@ +/* + * Licens

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #6638: Spark: REPLACE BRANCH SQL implementation

amogh-jahagirdar commented on code in PR #6638: URL: https://github.com/apache/iceberg/pull/6638#discussion_r1091286134 ## spark/v3.3/spark-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4: ## @@ -82,6 +82,13 @@ snapshotRetentionC

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #6638: Spark: REPLACE BRANCH SQL implementation

amogh-jahagirdar commented on code in PR #6638: URL: https://github.com/apache/iceberg/pull/6638#discussion_r1091286560 ## spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestCreateBranch.java: ## @@ -129,6 +129,24 @@ public void testCreateBranchUse

[GitHub] [iceberg] szehon-ho commented on a diff in pull request #6648: Hive: Refactor commit lock mechanism from HiveTableOperations

szehon-ho commented on code in PR #6648: URL: https://github.com/apache/iceberg/pull/6648#discussion_r1091303197 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -135,13 +92,6 @@ public class HiveTableOperations extends BaseMetastoreTableO

[GitHub] [iceberg] zhangjiuyang1993 commented on issue #5993: Quick start docker-compose demo doesn't work

zhangjiuyang1993 commented on issue #5993: URL: https://github.com/apache/iceberg/issues/5993#issuecomment-1409624924 @nastra According to the configuration above, I got the following error： 23/01/31 01:43:58 WARN RESTSessionCatalog: Failed to report metrics to REST endpoint for table

[GitHub] [iceberg] zhangjiuyang1993 commented on issue #5993: Quick start docker-compose demo doesn't work

zhangjiuyang1993 commented on issue #5993: URL: https://github.com/apache/iceberg/issues/5993#issuecomment-1409640982 Sorry if wrongly reported as bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [iceberg] kingwind94 commented on issue #6694: position delete manifest lower_bounds/upper_bounds not correct

kingwind94 commented on issue #6694: URL: https://github.com/apache/iceberg/issues/6694#issuecomment-1409652067 > > But flink's new added position deletes should only appy to the new added data files, not history (rewritting) data files, so this should not hinder the rewrite operation if it

[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6638: Spark: REPLACE BRANCH SQL implementation

jackye1995 commented on code in PR #6638: URL: https://github.com/apache/iceberg/pull/6638#discussion_r1091381837 ## spark/v3.3/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateOrReplaceBranchExec.scala: ## @@ -0,0 +1,82 @@ +/* + * Licensed to

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #6638: Spark: REPLACE BRANCH SQL implementation

amogh-jahagirdar commented on code in PR #6638: URL: https://github.com/apache/iceberg/pull/6638#discussion_r1091385871 ## spark/v3.3/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateOrReplaceBranchExec.scala: ## @@ -0,0 +1,82 @@ +/* + * Licens

[GitHub] [iceberg] stevenzwu commented on a diff in pull request #6660: Flink: Support writes to branches in FlinkSink

stevenzwu commented on code in PR #6660: URL: https://github.com/apache/iceberg/pull/6660#discussion_r1091380956 ## flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSinkBranch.java: ## @@ -0,0 +1,398 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [iceberg] stevenzwu commented on a diff in pull request #6614: Flink:fix flink streaming query problem [ Cannot get a client from a closed pool]

stevenzwu commented on code in PR #6614: URL: https://github.com/apache/iceberg/pull/6614#discussion_r1091413180 ## flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/enumerator/ContinuousSplitPlannerImpl.java: ## @@ -62,11 +64,26 @@ public ContinuousSplitPlannerImp

[GitHub] [iceberg] bryanck commented on a diff in pull request #6707: Mark updated auth fields volatile for refresh

bryanck commented on code in PR #6707: URL: https://github.com/apache/iceberg/pull/6707#discussion_r1091447817 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java: ## @@ -354,10 +354,10 @@ public static class AuthSession { private static int tokenRefreshNumRe

[GitHub] [iceberg] bryanck commented on a diff in pull request #6707: Mark updated auth fields volatile for refresh

bryanck commented on code in PR #6707: URL: https://github.com/apache/iceberg/pull/6707#discussion_r1091447817 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java: ## @@ -354,10 +354,10 @@ public static class AuthSession { private static int tokenRefreshNumRe

[GitHub] [iceberg] zhangjiuyang1993 opened a new issue, #6708: Quick start docker-compose demo doesn't work

zhangjiuyang1993 opened a new issue, #6708: URL: https://github.com/apache/iceberg/issues/6708 ### Apache Iceberg version 0.14.1 ### Query engine Spark ### Please describe the bug 🐞 @nastra version: "3" services: spark-iceberg: image: tabula

[GitHub] [iceberg] szehon-ho commented on a diff in pull request #6698: Core, Hive: Support pluggable ClientPool

szehon-ho commented on code in PR #6698: URL: https://github.com/apache/iceberg/pull/6698#discussion_r1091488029 ## core/src/main/java/org/apache/iceberg/CatalogProperties.java: ## @@ -119,6 +119,8 @@ private CatalogProperties() {} "client.pool.cache.eviction-interval-ms"

[GitHub] [iceberg] lintingbin2009 commented on issue #6126: RemoveDanglingDeleteFiles

lintingbin2009 commented on issue #6126: URL: https://github.com/apache/iceberg/issues/6126#issuecomment-1409839075 @szehon-ho I have the same problem, is there any progress update? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [iceberg] arminnajafi commented on pull request #6646: Implement Support for DynamoDB Catalog

arminnajafi commented on PR #6646: URL: https://github.com/apache/iceberg/pull/6646#issuecomment-1409842868 @JonasJ-ap Thanks for reviewing this PR and also your Glue Catalog PR. This work is mostly based on that PR. -- This is an automated message from the Apache Git Service. To res

[GitHub] [iceberg] arminnajafi commented on a diff in pull request #6646: Implement Support for DynamoDB Catalog

arminnajafi commented on code in PR #6646: URL: https://github.com/apache/iceberg/pull/6646#discussion_r1091511605 ## python/tests/catalog/__init__.py: ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

[GitHub] [iceberg] arminnajafi commented on a diff in pull request #6646: Implement Support for DynamoDB Catalog

arminnajafi commented on code in PR #6646: URL: https://github.com/apache/iceberg/pull/6646#discussion_r1091513302 ## python/pyiceberg/catalog/dynamodb.py: ## @@ -0,0 +1,733 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreeme

[GitHub] [iceberg] arminnajafi commented on a diff in pull request #6646: Implement Support for DynamoDB Catalog

arminnajafi commented on code in PR #6646: URL: https://github.com/apache/iceberg/pull/6646#discussion_r1091516586 ## python/pyiceberg/catalog/dynamodb.py: ## @@ -0,0 +1,733 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreeme

[GitHub] [iceberg] arminnajafi commented on a diff in pull request #6646: Implement Support for DynamoDB Catalog

arminnajafi commented on code in PR #6646: URL: https://github.com/apache/iceberg/pull/6646#discussion_r1091520849 ## python/pyiceberg/catalog/__init__.py: ## @@ -431,3 +440,114 @@ def namespace_from(identifier: Union[str, Identifier]) -> Identifier: Identifier: Na

[GitHub] [iceberg] lirui-apache commented on a diff in pull request #6698: Core, Hive: Support pluggable ClientPool

lirui-apache commented on code in PR #6698: URL: https://github.com/apache/iceberg/pull/6698#discussion_r1091540668 ## core/src/main/java/org/apache/iceberg/CatalogUtil.java: ## @@ -439,4 +439,40 @@ public static MetricsReporter loadMetricsReporter(String impl) { return

[GitHub] [iceberg] lirui-apache commented on pull request #6698: Core, Hive: Support pluggable ClientPool

lirui-apache commented on PR #6698: URL: https://github.com/apache/iceberg/pull/6698#issuecomment-1409921692 @szehon-ho Thanks for reviewing! I've updated the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [iceberg] zhangbutao commented on pull request #6653: API: Fix Transform backward compatibility in PartitionSpec

zhangbutao commented on PR #6653: URL: https://github.com/apache/iceberg/pull/6653#issuecomment-1409922846 > I am ok with either solution, however, noticed a potentially no-go comment in your PR and decided to take the same approach as @Fokko in #6220. Note this is a blocker for Hive Iceber

[GitHub] [iceberg] Fokko merged pull request #6705: Python: Update pyproject.toml to include dev folder.

Fokko merged PR #6705: URL: https://github.com/apache/iceberg/pull/6705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

[GitHub] [iceberg] Fokko commented on pull request #6705: Python: Update pyproject.toml to include dev folder.

Fokko commented on PR #6705: URL: https://github.com/apache/iceberg/pull/6705#issuecomment-1409962986 Thanks @amogh-jahagirdar for fixing this, and @jackye1995 for the review 👏🏻 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [iceberg] Fokko commented on pull request #6704: Python: Update pyproject.toml to include dev folder.

Fokko commented on PR #6704: URL: https://github.com/apache/iceberg/pull/6704#issuecomment-1409963309 Thanks @amogh-jahagirdar for fixing this, and @jackye1995 and @singhpk234 for the review 👏🏻 -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [iceberg] Fokko merged pull request #6704: Python: Update pyproject.toml to include dev folder.

Fokko merged PR #6704: URL: https://github.com/apache/iceberg/pull/6704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

[GitHub] [iceberg] simhadri-g opened a new issue, #6709: BasicStats TOTAL_RECORDS_PROP does not update after records are deleted this results in unoptimised query plans.

simhadri-g opened a new issue, #6709: URL: https://github.com/apache/iceberg/issues/6709 ### Apache Iceberg version 1.1.0 (latest release) ### Query engine Hive ### Please describe the bug 🐞 **Issue:** - Hive planner uses basic stats for query plannin

[GitHub] [iceberg] youngxinler commented on pull request #6554: Parquet: Improve Test Coverage of RowGroupFilter Code with Nans #6518

youngxinler commented on PR #6554: URL: https://github.com/apache/iceberg/pull/6554#issuecomment-1410278806 please take a review if you have time. @RussellSpitzer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [iceberg] nastra commented on issue #5993: Quick start docker-compose demo doesn't work

nastra commented on issue #5993: URL: https://github.com/apache/iceberg/issues/5993#issuecomment-1410476388 @zhangjiuyang1993 are you using `tabulario/iceberg-rest:0.1.0`? If so, you need to use the latest one with Iceberg 1.1.0 support, which is `tabulario/iceberg-rest:0.2.0` -- This is

[GitHub] [iceberg] nastra commented on issue #6708: Quick start docker-compose demo doesn't work

nastra commented on issue #6708: URL: https://github.com/apache/iceberg/issues/6708#issuecomment-1410481495 You need to upgrade `tabulario/iceberg-rest:0.1.0` (uses Iceberg 1.0.0) to `tabulario/iceberg-rest:0.2.0` (uses Iceberg 1.1.0). That should fix it. -- This is an automated message f

[GitHub] [iceberg] nastra commented on a diff in pull request #6701: Add missing `last-column-id` to spec

nastra commented on code in PR #6701: URL: https://github.com/apache/iceberg/pull/6701#discussion_r1092044493 ## open-api/rest-catalog-open-api.yaml: ## @@ -1541,6 +1541,8 @@ components: properties: snapshot: $ref: '#/components/schemas/Sna

[GitHub] [iceberg] danielcweeks merged pull request #6702: Python: Let pytest know that it shouldn't collect TestType

danielcweeks merged PR #6702: URL: https://github.com/apache/iceberg/pull/6702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

[GitHub] [iceberg] snazy opened a new issue, #6710: REST-Catalog: missing conflict-checks for `dropTable` and `updateTable`

snazy opened a new issue, #6710: URL: https://github.com/apache/iceberg/issues/6710 ### Apache Iceberg version main (development) ### Query engine None ### Please describe the bug 🐞 Concurrent operations against the same table (like updating the same table

[GitHub] [iceberg] snazy opened a new issue, #6711: REST-Catalog: `Table.newTransaction()....commit()` does nothing

snazy opened a new issue, #6711: URL: https://github.com/apache/iceberg/issues/6711 ### Apache Iceberg version main (development) ### Query engine None ### Please describe the bug 🐞 This one works: `table.updateProperties().set("meep", "woof").commit();`

[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #6706: Refactor table metadata snapshot management

aokolnychyi commented on code in PR #6706: URL: https://github.com/apache/iceberg/pull/6706#discussion_r1092249993 ## core/src/main/java/org/apache/iceberg/SnapshotOperations.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #6706: Refactor table metadata snapshot management

aokolnychyi commented on code in PR #6706: URL: https://github.com/apache/iceberg/pull/6706#discussion_r1092250698 ## core/src/main/java/org/apache/iceberg/SnapshotOperations.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #6706: Refactor table metadata snapshot management

aokolnychyi commented on code in PR #6706: URL: https://github.com/apache/iceberg/pull/6706#discussion_r1092254793 ## core/src/main/java/org/apache/iceberg/SnapshotOperations.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

[GitHub] [iceberg] ajantha-bhat opened a new pull request, #6712: [WIP] Nessie: Support ApiV2 for Nessie client

ajantha-bhat opened a new pull request, #6712: URL: https://github.com/apache/iceberg/pull/6712 - The default is still kept as v1 as the v2 API cannot list implicit namespaces and need to provide a tool to convert implicit namespaces to explicit namespaces for an existing table if we make v

[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #6712: [WIP] Nessie: Support ApiV2 for Nessie client

ajantha-bhat commented on code in PR #6712: URL: https://github.com/apache/iceberg/pull/6712#discussion_r1092270108 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieUtil.java: ## @@ -37,6 +37,8 @@ public final class NessieUtil { public static final String NESSIE_CONFIG

[GitHub] [iceberg] jedrek-VL opened a new issue, #6713: PyIceberg fails when querying REST catalog

jedrek-VL opened a new issue, #6713: URL: https://github.com/apache/iceberg/issues/6713 ### Apache Iceberg version 1.1.0 (latest release) ### Query engine Other ### Please describe the bug 🐞 I start the spark/iceberg docker containers (as explained [here](h

[GitHub] [iceberg] nastra commented on a diff in pull request #6706: Refactor table metadata snapshot management

nastra commented on code in PR #6706: URL: https://github.com/apache/iceberg/pull/6706#discussion_r1092274484 ## core/src/main/java/org/apache/iceberg/SnapshotOperations.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #6706: Refactor table metadata snapshot management

aokolnychyi commented on code in PR #6706: URL: https://github.com/apache/iceberg/pull/6706#discussion_r1092288701 ## core/src/main/java/org/apache/iceberg/SnapshotOperations.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #6706: Refactor table metadata snapshot management

aokolnychyi commented on code in PR #6706: URL: https://github.com/apache/iceberg/pull/6706#discussion_r1092289003 ## core/src/main/java/org/apache/iceberg/SnapshotOperations.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #6706: Refactor table metadata snapshot management

aokolnychyi commented on code in PR #6706: URL: https://github.com/apache/iceberg/pull/6706#discussion_r1092291477 ## core/src/main/java/org/apache/iceberg/SnapshotOperations.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

[GitHub] [iceberg] yyanyy commented on a diff in pull request #6638: Spark: REPLACE BRANCH SQL implementation

yyanyy commented on code in PR #6638: URL: https://github.com/apache/iceberg/pull/6638#discussion_r1092293687 ## spark/v3.3/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateOrReplaceBranchExec.scala: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the

[GitHub] [iceberg] yyanyy commented on a diff in pull request #6638: Spark: REPLACE BRANCH SQL implementation

yyanyy commented on code in PR #6638: URL: https://github.com/apache/iceberg/pull/6638#discussion_r1092294333 ## spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestReplaceBranch.java: ## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #6706: Refactor table metadata snapshot management

aokolnychyi commented on code in PR #6706: URL: https://github.com/apache/iceberg/pull/6706#discussion_r1092289003 ## core/src/main/java/org/apache/iceberg/SnapshotOperations.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

[GitHub] [iceberg] stevenzwu commented on issue #6711: REST-Catalog: `Table.newTransaction()....commit()` does nothing

stevenzwu commented on issue #6711: URL: https://github.com/apache/iceberg/issues/6711#issuecomment-1410828722 @snazy I thought you need to call `.commitTransaction()` in the end -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [iceberg] nastra commented on issue #6711: REST-Catalog: `Table.newTransaction()....commit()` does nothing

nastra commented on issue #6711: URL: https://github.com/apache/iceberg/issues/6711#issuecomment-1410842372 Indeed this is missing the `commitTransaction() call. The below test passes for me: ``` @Test public void testUpdatePropertiesViaTransaction() { C catalog = catalog()

[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #6706: Refactor table metadata snapshot management

aokolnychyi commented on code in PR #6706: URL: https://github.com/apache/iceberg/pull/6706#discussion_r1092313811 ## core/src/main/java/org/apache/iceberg/SnapshotOperations.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #6706: Refactor table metadata snapshot management

aokolnychyi commented on code in PR #6706: URL: https://github.com/apache/iceberg/pull/6706#discussion_r1092314449 ## core/src/main/java/org/apache/iceberg/SnapshotOperations.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

[GitHub] [iceberg] snazy commented on issue #6711: REST-Catalog: `Table.newTransaction()....commit()` does nothing

snazy commented on issue #6711: URL: https://github.com/apache/iceberg/issues/6711#issuecomment-1410860361 Oh, okay - NVM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [iceberg] snazy closed issue #6711: REST-Catalog: `Table.newTransaction()....commit()` does nothing

snazy closed issue #6711: REST-Catalog: `Table.newTransaction()commit()` does nothing URL: https://github.com/apache/iceberg/issues/6711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #6700: Snapshot ref type public

aokolnychyi commented on code in PR #6700: URL: https://github.com/apache/iceberg/pull/6700#discussion_r1092317116 ## api/src/main/java/org/apache/iceberg/SnapshotRefType.java: ## @@ -21,7 +21,7 @@ import java.util.Locale; import org.apache.iceberg.relocated.com.google.common.

[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #6706: Refactor table metadata snapshot management

aokolnychyi commented on code in PR #6706: URL: https://github.com/apache/iceberg/pull/6706#discussion_r1092320846 ## core/src/main/java/org/apache/iceberg/SnapshotOperations.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

[GitHub] [iceberg] aokolnychyi commented on pull request #6695: Spark-3.3: Handle no-op for rewrite manifests procedure/action

aokolnychyi commented on PR #6695: URL: https://github.com/apache/iceberg/pull/6695#issuecomment-1410869692 I should be able to take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #6695: Spark-3.3: Handle no-op for rewrite manifests procedure/action

aokolnychyi commented on code in PR #6695: URL: https://github.com/apache/iceberg/pull/6695#discussion_r1092327457 ## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java: ## @@ -172,6 +172,10 @@ private RewriteManifests.Result doExecu

[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #6695: Spark-3.3: Handle no-op for rewrite manifests procedure/action

aokolnychyi commented on code in PR #6695: URL: https://github.com/apache/iceberg/pull/6695#discussion_r1092327895 ## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java: ## @@ -172,6 +172,10 @@ private RewriteManifests.Result doExecu

[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #6695: Spark-3.3: Handle no-op for rewrite manifests procedure/action

aokolnychyi commented on code in PR #6695: URL: https://github.com/apache/iceberg/pull/6695#discussion_r1092328163 ## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java: ## @@ -172,6 +172,10 @@ private RewriteManifests.Result doExecu

[GitHub] [iceberg] aokolnychyi commented on pull request #6695: Spark-3.3: Handle no-op for rewrite manifests procedure/action

aokolnychyi commented on PR #6695: URL: https://github.com/apache/iceberg/pull/6695#issuecomment-1410876532 The change makes sense but we must be able to rewrite large manifests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6706: Refactor table metadata snapshot management

danielcweeks commented on code in PR #6706: URL: https://github.com/apache/iceberg/pull/6706#discussion_r1092334697 ## core/src/main/java/org/apache/iceberg/SnapshotOperations.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6706: Refactor table metadata snapshot management

danielcweeks commented on code in PR #6706: URL: https://github.com/apache/iceberg/pull/6706#discussion_r1092336781 ## core/src/main/java/org/apache/iceberg/SnapshotOperations.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6706: Refactor table metadata snapshot management

danielcweeks commented on code in PR #6706: URL: https://github.com/apache/iceberg/pull/6706#discussion_r1092338783 ## core/src/main/java/org/apache/iceberg/SnapshotOperations.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6706: Refactor table metadata snapshot management

danielcweeks commented on code in PR #6706: URL: https://github.com/apache/iceberg/pull/6706#discussion_r1092339544 ## core/src/main/java/org/apache/iceberg/SnapshotOperations.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

[GitHub] [iceberg] dimas-b commented on a diff in pull request #6712: [WIP] Nessie: Support ApiV2 for Nessie client

dimas-b commented on code in PR #6712: URL: https://github.com/apache/iceberg/pull/6712#discussion_r1092348487 ## nessie/src/test/java/org/apache/iceberg/nessie/BaseTestIceberg.java: ## @@ -144,6 +144,9 @@ NessieCatalog initCatalog(String ref, String hash) { .put(Ca

<    3   4   5   6   7   8   9   10   11   12   >