amogh-jahagirdar commented on code in PR #6704:
URL: https://github.com/apache/iceberg/pull/6704#discussion_r1090854455
##########
python/pyproject.toml:
##########
@@ -39,11 +39,13 @@ packages = [
{ from = "vendor", include = "fb303" },
{ from = "vendor", include = "hive_metastore" },
{ include = "tests", format = "sdist" },
- { include = "dev/check-license", format = "sdist" },
{ include = "Makefile", format = "sdist" },
{ include = "NOTICE", format = ["sdist", "wheel"] }
]
+include = [
+ {path = "dev", format = "sdist"}
+]
Review Comment:
Made a separate list instead of adding in packages which seems to be what
https://python-poetry.org/docs/pyproject/#include-and-exclude suggests.
When I tried adding the glob "dev/*" to the existing packages list I would
always get errors saying that the files were not packages which makes sense,
but when I add the files individually it works. Since we want to include
everything in the dev folder, to make it easier in the future I went this route.
Technically we can add the Makefile, NOTICE files as well but I didn't want
to make this change more intrusive before release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
