aokolnychyi commented on code in PR #6695:
URL: https://github.com/apache/iceberg/pull/6695#discussion_r1092327457
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java:
##########
@@ -172,6 +172,10 @@ private RewriteManifests.Result doExecute() {
int targetNumManifests = targetNumManifests(totalSizeBytes);
int targetNumManifestEntries = targetNumManifestEntries(numEntries,
targetNumManifests);
+ if (targetNumManifests == 1 && matchingManifests.size() == 1) {
Review Comment:
I don't think this is safe as the only manifest that may match may be huge,
which would be a bottleneck for planning. It is a valid scenario to be able to
split one giant manifest into a number of smaller ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
