aokolnychyi commented on code in PR #6700: URL: https://github.com/apache/iceberg/pull/6700#discussion_r1092317116
########## api/src/main/java/org/apache/iceberg/SnapshotRefType.java: ########## @@ -21,7 +21,7 @@ import java.util.Locale; import org.apache.iceberg.relocated.com.google.common.base.Preconditions; -enum SnapshotRefType { +public enum SnapshotRefType { Review Comment: I haven't followed the initial implementation but it seems `SnapshotRef` class offers helper boolean methods to check if a ref is a branch or is a tag and hides `SnapshotRefType` on purpose. Is there a particular reason to make this public, @snazy? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org