rdblue commented on code in PR #6058:
URL: https://github.com/apache/iceberg/pull/6058#discussion_r1018469932
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##
@@ -532,6 +537,24 @@ public final void initialize(String name,
CaseInsensitiveStringMap
rdblue commented on code in PR #6058:
URL: https://github.com/apache/iceberg/pull/6058#discussion_r1018470425
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##
@@ -532,6 +537,24 @@ public final void initialize(String name,
CaseInsensitiveStringMap
aokolnychyi commented on code in PR #2276:
URL: https://github.com/apache/iceberg/pull/2276#discussion_r1018413283
##
api/src/main/java/org/apache/iceberg/FileScanTask.java:
##
@@ -48,4 +48,9 @@ default boolean isFileScanTask() {
default FileScanTask asFileScanTask() {
r
aokolnychyi commented on code in PR #6163:
URL: https://github.com/apache/iceberg/pull/6163#discussion_r1018475572
##
core/src/main/java/org/apache/iceberg/Partitioning.java:
##
@@ -195,41 +198,68 @@ public Void alwaysNull(int fieldId, String sourceName,
int sourceId) {
}
aokolnychyi commented on code in PR #6163:
URL: https://github.com/apache/iceberg/pull/6163#discussion_r1018476321
##
core/src/main/java/org/apache/iceberg/Partitioning.java:
##
@@ -195,41 +198,68 @@ public Void alwaysNull(int fieldId, String sourceName,
int sourceId) {
}
RussellSpitzer commented on code in PR #6163:
URL: https://github.com/apache/iceberg/pull/6163#discussion_r1018477109
##
core/src/main/java/org/apache/iceberg/Partitioning.java:
##
@@ -195,41 +198,68 @@ public Void alwaysNull(int fieldId, String sourceName,
int sourceId) {
}
aokolnychyi commented on PR #6012:
URL: https://github.com/apache/iceberg/pull/6012#issuecomment-1309475241
Let me take a look today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
RussellSpitzer commented on code in PR #6163:
URL: https://github.com/apache/iceberg/pull/6163#discussion_r1018479165
##
core/src/main/java/org/apache/iceberg/Partitioning.java:
##
@@ -195,41 +198,68 @@ public Void alwaysNull(int fieldId, String sourceName,
int sourceId) {
}
aokolnychyi commented on code in PR #6163:
URL: https://github.com/apache/iceberg/pull/6163#discussion_r1018485333
##
core/src/main/java/org/apache/iceberg/Partitioning.java:
##
@@ -195,41 +198,68 @@ public Void alwaysNull(int fieldId, String sourceName,
int sourceId) {
}
RussellSpitzer commented on code in PR #6163:
URL: https://github.com/apache/iceberg/pull/6163#discussion_r1018485570
##
core/src/main/java/org/apache/iceberg/Partitioning.java:
##
@@ -195,41 +198,68 @@ public Void alwaysNull(int fieldId, String sourceName,
int sourceId) {
}
RussellSpitzer commented on code in PR #6163:
URL: https://github.com/apache/iceberg/pull/6163#discussion_r1018485570
##
core/src/main/java/org/apache/iceberg/Partitioning.java:
##
@@ -195,41 +198,68 @@ public Void alwaysNull(int fieldId, String sourceName,
int sourceId) {
}
aokolnychyi commented on code in PR #6163:
URL: https://github.com/apache/iceberg/pull/6163#discussion_r1018486198
##
core/src/main/java/org/apache/iceberg/Partitioning.java:
##
@@ -195,41 +198,68 @@ public Void alwaysNull(int fieldId, String sourceName,
int sourceId) {
}
aokolnychyi commented on code in PR #6163:
URL: https://github.com/apache/iceberg/pull/6163#discussion_r1018487624
##
core/src/main/java/org/apache/iceberg/Partitioning.java:
##
@@ -195,41 +198,68 @@ public Void alwaysNull(int fieldId, String sourceName,
int sourceId) {
}
aokolnychyi commented on code in PR #6163:
URL: https://github.com/apache/iceberg/pull/6163#discussion_r1018487624
##
core/src/main/java/org/apache/iceberg/Partitioning.java:
##
@@ -195,41 +198,68 @@ public Void alwaysNull(int fieldId, String sourceName,
int sourceId) {
}
RussellSpitzer commented on code in PR #6163:
URL: https://github.com/apache/iceberg/pull/6163#discussion_r1018488935
##
core/src/main/java/org/apache/iceberg/Partitioning.java:
##
@@ -298,4 +324,33 @@ private static boolean compatibleTransforms(Transform t1, Transform
RussellSpitzer commented on code in PR #6163:
URL: https://github.com/apache/iceberg/pull/6163#discussion_r1018491119
##
core/src/main/java/org/apache/iceberg/Partitioning.java:
##
@@ -195,41 +198,68 @@ public Void alwaysNull(int fieldId, String sourceName,
int sourceId) {
}
RussellSpitzer commented on code in PR #6163:
URL: https://github.com/apache/iceberg/pull/6163#discussion_r1018492377
##
core/src/main/java/org/apache/iceberg/Partitioning.java:
##
@@ -195,41 +198,68 @@ public Void alwaysNull(int fieldId, String sourceName,
int sourceId) {
}
sunchao commented on code in PR #2276:
URL: https://github.com/apache/iceberg/pull/2276#discussion_r1018493002
##
api/src/main/java/org/apache/iceberg/FileScanTask.java:
##
@@ -48,4 +48,9 @@ default boolean isFileScanTask() {
default FileScanTask asFileScanTask() {
retur
RussellSpitzer commented on code in PR #6163:
URL: https://github.com/apache/iceberg/pull/6163#discussion_r1018496077
##
core/src/main/java/org/apache/iceberg/Partitioning.java:
##
@@ -298,4 +324,33 @@ private static boolean compatibleTransforms(Transform t1, Transform
RussellSpitzer commented on code in PR #6163:
URL: https://github.com/apache/iceberg/pull/6163#discussion_r1018499080
##
core/src/main/java/org/apache/iceberg/Partitioning.java:
##
@@ -195,41 +198,68 @@ public Void alwaysNull(int fieldId, String sourceName,
int sourceId) {
}
sunchao commented on code in PR #2276:
URL: https://github.com/apache/iceberg/pull/2276#discussion_r1018502255
##
api/src/main/java/org/apache/iceberg/util/StructProjection.java:
##
@@ -90,6 +90,13 @@ public static StructProjection createAllowMissing(
private final StructProj
singhpk234 commented on code in PR #5860:
URL: https://github.com/apache/iceberg/pull/5860#discussion_r1018512446
##
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteManifestsProcedure.java:
##
@@ -75,6 +96,79 @@ public void testRewriteLar
singhpk234 commented on PR #5860:
URL: https://github.com/apache/iceberg/pull/5860#issuecomment-1309542196
> I don't like running 4 tests in a loop inside one method when 2 test
methods would do fine. Can you please remove the complexity of parameterizing
this test?
ACK, removed the
github-actions[bot] commented on issue #4723:
URL: https://github.com/apache/iceberg/issues/4723#issuecomment-1309571874
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #4626:
URL: https://github.com/apache/iceberg/issues/4626#issuecomment-1309571902
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] closed issue #3731: Cannot use RewriteDataFiles on Hadoop
Tables
URL: https://github.com/apache/iceberg/issues/3731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
github-actions[bot] commented on issue #3731:
URL: https://github.com/apache/iceberg/issues/3731#issuecomment-1309571969
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
daksha121 opened a new issue, #6165:
URL: https://github.com/apache/iceberg/issues/6165
### Feature Request / Improvement
We have a scenario in which we need to add a new field to the table and add
it to the identifiers as well (Currently the table has only one required column
as the
rdblue commented on PR #6161:
URL: https://github.com/apache/iceberg/pull/6161#issuecomment-1309603910
Should we change the S3 FileIO order to use ArrowFileIO by default as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
rdblue merged PR #6161:
URL: https://github.com/apache/iceberg/pull/6161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
rdblue commented on code in PR #6161:
URL: https://github.com/apache/iceberg/pull/6161#discussion_r1018547445
##
python/pyiceberg/table/__init__.py:
##
@@ -90,3 +110,16 @@ def snapshot_by_name(self, name: str) -> Optional[Snapshot]:
def history(self) -> List[SnapshotLogEntr
kekwan commented on issue #5970:
URL: https://github.com/apache/iceberg/issues/5970#issuecomment-1309628626
Hitting similar issue with `java.io.InvalidClassException:
org.apache.iceberg.BaseFile; local class incompatible: stream classdesc
serialVersionUID = 2686776604825259963, local class
lvyanquan opened a new pull request, #6166:
URL: https://github.com/apache/iceberg/pull/6166
Flink: Port #6049 to Flink 1.14 in order to add Sink options of compression
properties.
This part of the code has been included in Flink 1.16 since #6092.
--
This is an automated message fr
eyeryone commented on issue #6067:
URL: https://github.com/apache/iceberg/issues/6067#issuecomment-1309667485
> Hive on Spark is not supported/tested Also Hive 2.1.1 is also not
supported/tested Could you use newer CDH/CDP version?
ok οΌthinks. If the version is not updated
sunchao commented on code in PR #2276:
URL: https://github.com/apache/iceberg/pull/2276#discussion_r1018632924
##
core/src/main/java/org/apache/iceberg/util/TableScanUtil.java:
##
@@ -121,10 +128,66 @@ public static
CloseableIterable> planTaskG
Function weightFunc =
sunchao commented on code in PR #2276:
URL: https://github.com/apache/iceberg/pull/2276#discussion_r1018633047
##
core/src/main/java/org/apache/iceberg/util/TableScanUtil.java:
##
@@ -121,10 +128,66 @@ public static
CloseableIterable> planTaskG
Function weightFunc =
sunchao commented on code in PR #2276:
URL: https://github.com/apache/iceberg/pull/2276#discussion_r1018633696
##
core/src/main/java/org/apache/iceberg/util/TableScanUtil.java:
##
@@ -121,10 +128,66 @@ public static
CloseableIterable> planTaskG
Function weightFunc =
SHuixo commented on issue #6104:
URL: https://github.com/apache/iceberg/issues/6104#issuecomment-1309843130
Think you @luoyuxia for your replay.
Later, I tried again a few times and found that when the cumulative storage
of iceberg data small files was relatively small, the flink 1.13
aokolnychyi commented on code in PR #6012:
URL: https://github.com/apache/iceberg/pull/6012#discussion_r1018710056
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/procedures/GenerateChangesProcedure.java:
##
@@ -0,0 +1,271 @@
+/*
+ * Licensed to the Apache Software Fo
nastra commented on code in PR #6146:
URL: https://github.com/apache/iceberg/pull/6146#discussion_r1018753250
##
.palantir/revapi.yml:
##
@@ -1,4 +1,85 @@
acceptedBreaks:
+ "1.0.0":
+org.apache.iceberg:iceberg-core:
+- code: "java.class.defaultSerializationChanged"
+
nastra commented on code in PR #6146:
URL: https://github.com/apache/iceberg/pull/6146#discussion_r1018757312
##
.palantir/revapi.yml:
##
@@ -11,15 +92,21 @@ acceptedBreaks:
- code: "java.method.addedToInterface"
new: "method java.lang.String
org.apache.iceberg.expr
nastra commented on code in PR #6146:
URL: https://github.com/apache/iceberg/pull/6146#discussion_r1018757312
##
.palantir/revapi.yml:
##
@@ -11,15 +92,21 @@ acceptedBreaks:
- code: "java.method.addedToInterface"
new: "method java.lang.String
org.apache.iceberg.expr
nastra commented on code in PR #6146:
URL: https://github.com/apache/iceberg/pull/6146#discussion_r1018760620
##
.palantir/revapi.yml:
##
@@ -11,15 +92,21 @@ acceptedBreaks:
- code: "java.method.addedToInterface"
new: "method java.lang.String
org.apache.iceberg.expr
nastra commented on code in PR #6146:
URL: https://github.com/apache/iceberg/pull/6146#discussion_r1018763350
##
.palantir/revapi.yml:
##
@@ -1,4 +1,85 @@
acceptedBreaks:
+ "1.0.0":
+org.apache.iceberg:iceberg-core:
+- code: "java.class.defaultSerializationChanged"
+
nastra commented on code in PR #6146:
URL: https://github.com/apache/iceberg/pull/6146#discussion_r1018784561
##
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##
@@ -269,6 +269,20 @@ public T post(
return execute(Method.POST, path, null, body, responseType, h
nastra commented on code in PR #6146:
URL: https://github.com/apache/iceberg/pull/6146#discussion_r1018802581
##
.palantir/revapi.yml:
##
@@ -1,4 +1,85 @@
acceptedBreaks:
+ "1.0.0":
+org.apache.iceberg:iceberg-core:
+- code: "java.class.defaultSerializationChanged"
+
pvary merged PR #6166:
URL: https://github.com/apache/iceberg/pull/6166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach
pvary commented on PR #6166:
URL: https://github.com/apache/iceberg/pull/6166#issuecomment-1309985875
Thanks @lvyanquan for taking care of this.
Totally forgot to backport π’
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
pvary commented on issue #6067:
URL: https://github.com/apache/iceberg/issues/6067#issuecomment-1309989646
I did not see progress on HoS side, and I think the Hive community decided
to remove Spark as an execution engine, so I think there is not too much hope
there.
OTOH I know that
nastra commented on code in PR #6058:
URL: https://github.com/apache/iceberg/pull/6058#discussion_r1018846546
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##
@@ -532,6 +537,24 @@ public final void initialize(String name,
CaseInsensitiveStringMap
eyeryone commented on issue #6067:
URL: https://github.com/apache/iceberg/issues/6067#issuecomment-1310027231
> I did not see progress on HoS side, and I think the Hive community decided
to remove Spark as an execution engine, so I think there is not too much hope
there.
>
> OTOH I k
gaborkaszab commented on code in PR #6045:
URL: https://github.com/apache/iceberg/pull/6045#discussion_r1018774071
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -365,6 +374,13 @@ public boolean dropNamespace(Namespace namespace) {
@Override
nastra commented on PR #6133:
URL: https://github.com/apache/iceberg/pull/6133#issuecomment-1310103577
Going forward we'll be tagging & releasing from `master` but I don't think
we'd want to delete `1.0.x`. That being said I think we can close this PR here
since https://github.com/apache/ic
nastra closed pull request #6133: [1.0] Dell: Fix client serialization bug.
URL: https://github.com/apache/iceberg/pull/6133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Fokko commented on code in PR #6141:
URL: https://github.com/apache/iceberg/pull/6141#discussion_r1018963278
##
python/pyiceberg/expressions/literals.py:
##
@@ -58,25 +60,25 @@
timestamp_to_micros,
timestamptz_to_micros,
)
-from pyiceberg.utils.singleton import Single
Fokko commented on code in PR #6141:
URL: https://github.com/apache/iceberg/pull/6141#discussion_r1017702146
##
python/pyiceberg/expressions/literals.py:
##
@@ -125,81 +127,71 @@ def literal(value) -> Literal:
@literal.register(bool)
-def _(value: bool) -> Literal[bool]:
+d
nastra commented on code in PR #6167:
URL: https://github.com/apache/iceberg/pull/6167#discussion_r1018975215
##
settings.gradle:
##
@@ -52,6 +52,12 @@ project(':nessie').name = 'iceberg-nessie'
project(':gcp').name = 'iceberg-gcp'
project(':dell').name = 'iceberg-dell'
+if
nastra commented on PR #6102:
URL: https://github.com/apache/iceberg/pull/6102#issuecomment-1310144291
@ajantha-bhat as we disussed yesterday in the Iceberg sync: Going forward
we'll be tagging & releasing commits reachable from `master`, so I think this
PR can be closed
--
This is an au
Fokko merged PR #6129:
URL: https://github.com/apache/iceberg/pull/6129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach
Fokko commented on PR #6129:
URL: https://github.com/apache/iceberg/pull/6129#issuecomment-1310152192
Thanks everyone for the review ππ»
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
Fokko commented on code in PR #6141:
URL: https://github.com/apache/iceberg/pull/6141#discussion_r1018963278
##
python/pyiceberg/expressions/literals.py:
##
@@ -58,25 +60,25 @@
timestamp_to_micros,
timestamptz_to_micros,
)
-from pyiceberg.utils.singleton import Single
Fokko commented on code in PR #6141:
URL: https://github.com/apache/iceberg/pull/6141#discussion_r1018963278
##
python/pyiceberg/expressions/literals.py:
##
@@ -58,25 +60,25 @@
timestamp_to_micros,
timestamptz_to_micros,
)
-from pyiceberg.utils.singleton import Single
ggershinsky commented on PR #5432:
URL: https://github.com/apache/iceberg/pull/5432#issuecomment-1310159553
@rdblue I've sent a commit that addresses the review comments.
Regarding the magic string - it's 4-byte long, so I've kept "AGS1" (only)
there; but if it's a problem, I can replace
nastra closed pull request #6167: Build: Add -DallVersions property that
exposes all component versions
URL: https://github.com/apache/iceberg/pull/6167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
gaborkaszab commented on code in PR #6074:
URL: https://github.com/apache/iceberg/pull/6074#discussion_r1019008623
##
core/src/main/java/org/apache/iceberg/SnapshotManager.java:
##
@@ -22,6 +22,7 @@
public class SnapshotManager implements ManageSnapshots {
+ private final
nastra commented on PR #6168:
URL: https://github.com/apache/iceberg/pull/6168#issuecomment-1310173703
This currently fails with
```
Caused by:
com.fasterxml.jackson.databind.JsonMappingException: Scala module
2.14.0 requires Jackson Databind version >= 2.14.0 and < 2.15.0
ajantha-bhat closed pull request #6102: Build: Fix build version
URL: https://github.com/apache/iceberg/pull/6102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
luoyuxia commented on issue #6104:
URL: https://github.com/apache/iceberg/issues/6104#issuecomment-1310193327
> the repeated compression process of full data
The compaction won't be repeated. I mean during one compaction, some files
are compacted to one file. In next compaction, it won't
gaborkaszab commented on code in PR #6074:
URL: https://github.com/apache/iceberg/pull/6074#discussion_r1019036196
##
core/src/main/java/org/apache/iceberg/SnapshotManager.java:
##
@@ -30,6 +31,17 @@ public class SnapshotManager implements ManageSnapshots {
ops.current(
nastra commented on code in PR #6168:
URL: https://github.com/apache/iceberg/pull/6168#discussion_r1019154280
##
spark/v3.2/build.gradle:
##
@@ -33,6 +33,8 @@ configure(sparkProjects) {
resolutionStrategy {
force
"com.fasterxml.jackson.module:jackson-module-scal
nastra commented on code in PR #6168:
URL: https://github.com/apache/iceberg/pull/6168#discussion_r1019154927
##
spark/v3.3/build.gradle:
##
@@ -31,7 +31,9 @@ configure(sparkProjects) {
configurations {
all {
resolutionStrategy {
+force
"com.fasterxml.jac
nastra opened a new pull request, #6169:
URL: https://github.com/apache/iceberg/pull/6169
This introduces an S3 REST signer client and defines a REST spec
(`s3-signer-open-api.yml`) for a server implementation. Below is a high-level
overview of the introduced changes:
* the main logi
nastra commented on PR #6169:
URL: https://github.com/apache/iceberg/pull/6169#issuecomment-1310373071
/cc @rdblue @danielcweeks @jackye1995 @amogh-jahagirdar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
nastra commented on PR #4855:
URL: https://github.com/apache/iceberg/pull/4855#issuecomment-1310414693
@jackye1995 any updates on this? I think it would be great to get this in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
nastra commented on PR #6169:
URL: https://github.com/apache/iceberg/pull/6169#issuecomment-1310416636
For testing we might actually need
https://github.com/apache/iceberg/pull/4855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
Fokko opened a new pull request, #6170:
URL: https://github.com/apache/iceberg/pull/6170
Follow up on:
https://github.com/apache/iceberg/pull/6161#discussion_r1018547445
Another option is to move it to the constructor of the Table and not store
the properties.
--
This is an automa
Fokko commented on code in PR #6161:
URL: https://github.com/apache/iceberg/pull/6161#discussion_r1019271623
##
python/pyiceberg/table/__init__.py:
##
@@ -90,3 +110,16 @@ def snapshot_by_name(self, name: str) -> Optional[Snapshot]:
def history(self) -> List[SnapshotLogEntry
Fokko commented on code in PR #6161:
URL: https://github.com/apache/iceberg/pull/6161#discussion_r1019271623
##
python/pyiceberg/table/__init__.py:
##
@@ -90,3 +110,16 @@ def snapshot_by_name(self, name: str) -> Optional[Snapshot]:
def history(self) -> List[SnapshotLogEntry
thompson0012 opened a new issue, #6171:
URL: https://github.com/apache/iceberg/issues/6171
### Apache Iceberg version
1.0.0 (latest release)
### Query engine
Spark
### Please describe the bug π
as the official docker image has several problem
i use the py
nastra commented on issue #6171:
URL: https://github.com/apache/iceberg/issues/6171#issuecomment-1310475564
`NoClassDefFoundError` usually indicates that some classes were available
during compilation but are not available anymore at runtime.
Also what issue does the Docker image have? Wo
gaborkaszab commented on issue #6042:
URL: https://github.com/apache/iceberg/issues/6042#issuecomment-1310484363
Well, my plan was to keep the existing columns in the partitions metadata
table intact and add some delete file related ones on top. Currently, I only
dealt with position deletes
thompson0012 commented on issue #6171:
URL: https://github.com/apache/iceberg/issues/6171#issuecomment-1310487799
i know there are some issues found in #5993 , so i use this
[images](https://hub.docker.com/r/jupyter/pyspark-notebook)
with the following .jars
1. [1.0.0 Spark 3.3_2.12 ru
Fokko commented on PR #6145:
URL: https://github.com/apache/iceberg/pull/6145#issuecomment-1310545882
Also threw in some tests ππ»
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
thompson0012 commented on issue #6171:
URL: https://github.com/apache/iceberg/issues/6171#issuecomment-1310555881
i just found that, almost all the read extension is fail when i added
iceberg configuration
i cant normally read my local files after setting up the iceberg
but it goes
rdblue commented on code in PR #6141:
URL: https://github.com/apache/iceberg/pull/6141#discussion_r1019379366
##
python/pyiceberg/expressions/literals.py:
##
@@ -58,25 +60,25 @@
timestamp_to_micros,
timestamptz_to_micros,
)
-from pyiceberg.utils.singleton import Singl
rdblue commented on code in PR #6141:
URL: https://github.com/apache/iceberg/pull/6141#discussion_r1019381524
##
python/pyiceberg/expressions/literals.py:
##
@@ -108,7 +110,7 @@ def __ge__(self, other):
@singledispatch
-def literal(value) -> Literal:
+def literal(value: Any
rdblue commented on code in PR #6141:
URL: https://github.com/apache/iceberg/pull/6141#discussion_r1019382186
##
python/pyiceberg/expressions/literals.py:
##
@@ -125,81 +127,73 @@ def literal(value) -> Literal:
@literal.register(bool)
-def _(value: bool) -> Literal[bool]:
+
rdblue commented on code in PR #6141:
URL: https://github.com/apache/iceberg/pull/6141#discussion_r1019382620
##
python/pyiceberg/expressions/literals.py:
##
@@ -125,81 +127,71 @@ def literal(value) -> Literal:
@literal.register(bool)
-def _(value: bool) -> Literal[bool]:
+
rdblue commented on code in PR #6141:
URL: https://github.com/apache/iceberg/pull/6141#discussion_r1019384042
##
python/pyiceberg/expressions/literals.py:
##
@@ -125,81 +127,73 @@ def literal(value) -> Literal:
@literal.register(bool)
-def _(value: bool) -> Literal[bool]:
+
rdblue commented on code in PR #6141:
URL: https://github.com/apache/iceberg/pull/6141#discussion_r1019385197
##
python/pyiceberg/expressions/literals.py:
##
@@ -309,23 +303,23 @@ def __init__(self, value: float):
super().__init__(value, float)
@singledispatchmet
Fokko commented on code in PR #6141:
URL: https://github.com/apache/iceberg/pull/6141#discussion_r1019389663
##
python/pyiceberg/expressions/literals.py:
##
@@ -108,7 +110,7 @@ def __ge__(self, other):
@singledispatch
-def literal(value) -> Literal:
+def literal(value: Any)
rdblue merged PR #6145:
URL: https://github.com/apache/iceberg/pull/6145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
rdblue closed pull request #6131: Python: Add initial TableScan implementation
URL: https://github.com/apache/iceberg/pull/6131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
rdblue commented on PR #6131:
URL: https://github.com/apache/iceberg/pull/6131#issuecomment-1310623432
Closing in favor of #6145.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
rdblue commented on PR #6145:
URL: https://github.com/apache/iceberg/pull/6145#issuecomment-1310622915
Thanks, @Fokko!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
rdblue commented on PR #6168:
URL: https://github.com/apache/iceberg/pull/6168#issuecomment-1310624837
We should probably wait on this one until after the 1.1 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
rdblue merged PR #6167:
URL: https://github.com/apache/iceberg/pull/6167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
rdblue commented on PR #6167:
URL: https://github.com/apache/iceberg/pull/6167#issuecomment-1310626722
Thanks, @nastra! This is going to make it much easier to keep test running
properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
rdblue commented on code in PR #6170:
URL: https://github.com/apache/iceberg/pull/6170#discussion_r1019421535
##
python/pyiceberg/catalog/__init__.py:
##
@@ -162,6 +163,9 @@ def __init__(self, name: str, **properties: str):
self.name = name
self.properties = pr
rdblue commented on PR #6170:
URL: https://github.com/apache/iceberg/pull/6170#issuecomment-1310637803
Looks good to me! Just needs to be rebased and we can get it in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
1601 - 1700 of 85865 matches
Mail list logo
