nastra commented on code in PR #6146:
URL: https://github.com/apache/iceberg/pull/6146#discussion_r1018784561


##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -269,6 +269,20 @@ public <T extends RESTResponse> T post(
     return execute(Method.POST, path, null, body, responseType, headers, 
errorHandler);
   }
 
+  /**
+   * @deprecated Will be removed in 1.2.0, use {@link 
RESTClient#delete(String, Map, Class, Map,
+   *     Consumer)}.
+   */
+  @Deprecated
+  @Override
+  public <T extends RESTResponse> T delete(

Review Comment:
   I have removed the deprecation for now, but I would still consider 
deprecating it. We have 4 different `delete` methods in `RESTClient`. I think 
just keeping the one with `queryParams` would be ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to