nastra commented on code in PR #6146: URL: https://github.com/apache/iceberg/pull/6146#discussion_r1018753250
########## .palantir/revapi.yml: ########## @@ -1,4 +1,85 @@ acceptedBreaks: + "1.0.0": + org.apache.iceberg:iceberg-core: + - code: "java.class.defaultSerializationChanged" + old: "class org.apache.iceberg.BaseMetadataTable" + new: "class org.apache.iceberg.BaseMetadataTable" + justification: "Serialization changed" + - code: "java.class.defaultSerializationChanged" + old: "class org.apache.iceberg.BaseTable" + new: "class org.apache.iceberg.BaseTable" + justification: "Serialization changed" + - code: "java.class.defaultSerializationChanged" + old: "class org.apache.iceberg.BaseTransaction.TransactionTable" + new: "class org.apache.iceberg.BaseTransaction.TransactionTable" + justification: "Serialization changed" + - code: "java.class.defaultSerializationChanged" + old: "class org.apache.iceberg.MetricsConfig" + new: "class org.apache.iceberg.MetricsConfig" + justification: "Serialization changed" + - code: "java.class.defaultSerializationChanged" + old: "class org.apache.iceberg.SerializableTable" + new: "class org.apache.iceberg.SerializableTable" + justification: "Serialization changed" + - code: "java.class.defaultSerializationChanged" + old: "class org.apache.iceberg.TableMetadata" + new: "class org.apache.iceberg.TableMetadata" + justification: "Serialization changed" + - code: "java.field.noLongerConstant" + old: "field org.apache.iceberg.TableProperties.DELETE_MODE_DEFAULT" + new: "field org.apache.iceberg.TableProperties.DELETE_MODE_DEFAULT" + justification: "Refactorings" + - code: "java.field.noLongerConstant" + old: "field org.apache.iceberg.TableProperties.MERGE_MODE_DEFAULT" + new: "field org.apache.iceberg.TableProperties.MERGE_MODE_DEFAULT" + justification: "Refactorings" + - code: "java.field.noLongerConstant" + old: "field org.apache.iceberg.TableProperties.UPDATE_MODE_DEFAULT" + new: "field org.apache.iceberg.TableProperties.UPDATE_MODE_DEFAULT" + justification: "Refactorings" + - code: "java.method.addedToInterface" + new: "method <T extends org.apache.iceberg.rest.RESTResponse> T org.apache.iceberg.rest.RESTClient::delete(java.lang.String,\ + \ java.util.Map<java.lang.String, java.lang.String>, java.lang.Class<T>, java.util.Map<java.lang.String,\ + \ java.lang.String>, java.util.function.Consumer<org.apache.iceberg.rest.responses.ErrorResponse>)" + justification: "Adding new method where query params can be used" + - code: "java.method.addedToInterface" + new: "method org.apache.hadoop.conf.Configuration org.apache.hadoop.conf.Configurable::getConf()\ + \ @ org.apache.iceberg.hadoop.HadoopConfigurable" + justification: "New method was added to org.apache.hadoop.conf.Configurable" + - code: "java.method.addedToInterface" + new: "method void org.apache.hadoop.conf.Configurable::setConf(org.apache.hadoop.conf.Configuration)\ + \ @ org.apache.iceberg.hadoop.HadoopConfigurable" + justification: "New method was added to org.apache.hadoop.conf.Configurable" + - code: "java.method.numberOfParametersChanged" + old: "method void org.apache.iceberg.ManifestReader<F extends org.apache.iceberg.ContentFile<F\ + \ extends org.apache.iceberg.ContentFile<F>>>::<init>(org.apache.iceberg.io.InputFile,\ + \ java.util.Map<java.lang.Integer, org.apache.iceberg.PartitionSpec>, org.apache.iceberg.InheritableMetadata,\ + \ org.apache.iceberg.ManifestReader.FileType)" + new: "method void org.apache.iceberg.ManifestReader<F extends org.apache.iceberg.ContentFile<F\ + \ extends org.apache.iceberg.ContentFile<F>>>::<init>(org.apache.iceberg.io.InputFile,\ + \ int, java.util.Map<java.lang.Integer, org.apache.iceberg.PartitionSpec>,\ + \ org.apache.iceberg.InheritableMetadata, org.apache.iceberg.ManifestReader.FileType)" + justification: "Avoids reading ManifestFile when creating ManifestReader" Review Comment: I've restored the original code for the old constructor + deprecated it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
