Fokko commented on code in PR #6161:
URL: https://github.com/apache/iceberg/pull/6161#discussion_r1019271623


##########
python/pyiceberg/table/__init__.py:
##########
@@ -90,3 +110,16 @@ def snapshot_by_name(self, name: str) -> Optional[Snapshot]:
     def history(self) -> List[SnapshotLogEntry]:
         """Get the snapshot history of this table."""
         return self.metadata.snapshot_log
+
+    @cached_property
+    def io(self) -> FileIO:
+        return load_file_io({**self.catalog_properties, 
**self.metadata.properties, **self.config})

Review Comment:
   Hey Ryan, that makes sense. My main reason to pass it to the Table is that 
it can potentially refresh the FileIO, but we could also just refresh the 
table. For example, when a credential gets expired. I've posted a follow up PR: 
https://github.com/apache/iceberg/pull/6170



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to