chinmay-bhat commented on code in PR #950:
URL: https://github.com/apache/iceberg-python/pull/950#discussion_r1694696015
##
pyiceberg/table/__init__.py:
##
@@ -1129,12 +1128,22 @@ def _(update: SetSnapshotRefUpdate, base_metadata:
TableMetadata, context: _Tabl
return base_
nastra commented on code in PR #10802:
URL: https://github.com/apache/iceberg/pull/10802#discussion_r1694699704
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java:
##
@@ -137,6 +138,7 @@ protected void assertRecords(Table table, Lis
nastra merged PR #10800:
URL: https://github.com/apache/iceberg/pull/10800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
nastra merged PR #10798:
URL: https://github.com/apache/iceberg/pull/10798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
nastra commented on code in PR #10802:
URL: https://github.com/apache/iceberg/pull/10802#discussion_r1694709068
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java:
##
@@ -137,6 +138,7 @@ protected void assertRecords(Table table, Lis
nastra commented on PR #9008:
URL: https://github.com/apache/iceberg/pull/9008#issuecomment-2255138973
I don't have anything else and yes #10775 needs to be handled before 1.7
(would be good to start work on it rather sooner than later)
--
This is an automated message from the Apache Git
pvary commented on code in PR #9905:
URL: https://github.com/apache/iceberg/pull/9905#discussion_r1694724039
##
orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java:
##
@@ -296,24 +304,36 @@ private static TypeDescription buildOrcProjection(
list.elementI
pvary commented on PR #9905:
URL: https://github.com/apache/iceberg/pull/9905#issuecomment-2255169998
> > @deniskuzZ: How this is solved in Hive?
>
> i think it's done in `Hive: Support timestamp with local zone in Hive3
(#1897)`
#1897 does not have any ORC specific part. I sti
Fokko commented on PR #10780:
URL: https://github.com/apache/iceberg/pull/10780#issuecomment-2255174333
> IIUC, this should get published to the central website. Maybe other repos
can put a link in there contributing.md to reference this section once it gets
published?
Yes, that woul
nastra merged PR #10801:
URL: https://github.com/apache/iceberg/pull/10801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
Fokko merged PR #10796:
URL: https://github.com/apache/iceberg/pull/10796
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
pvary commented on PR #10776:
URL: https://github.com/apache/iceberg/pull/10776#issuecomment-2255212800
> > This basically resulted in "inconsistencies" between the 1.17-1.18/1.19
tests.
>
> @pvary Can you clarify what do you mean by the "inconsistencies" here?
Differences woul
pvary commented on issue #10765:
URL: https://github.com/apache/iceberg/issues/10765#issuecomment-2255254484
I think this is the log for the 19517:
```
Jul 24, 2024 @ 04:59:45.158 Failed to trigger checkpoint for job
ba65ea243c487f4f0fd52c158e4ed985 since Checkpoint triggering task
f
pvary commented on PR #10802:
URL: https://github.com/apache/iceberg/pull/10802#issuecomment-2255275307
Thanks for the review @nastra!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
pvary merged PR #10802:
URL: https://github.com/apache/iceberg/pull/10802
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
twuebi commented on issue #482:
URL: https://github.com/apache/iceberg-rust/issues/482#issuecomment-2255302470
Hi all,
I agree with @sdd and suggest to stick with tracing. It is the default
choice for logging in async applications and has the most wide-spread adoption.
Regardi
desruisseaux commented on issue #10260:
URL: https://github.com/apache/iceberg/issues/10260#issuecomment-2255315231
Citing only the libraries that I know (more may be available):
* C/C++
* PROJ can parse all the above.
* [ESRI prototype](https://github.com/Esri/ogc-crs-wkt-pa
desruisseaux commented on issue #10260:
URL: https://github.com/apache/iceberg/issues/10260#issuecomment-2255338418
> In addition, how does one can tell the string is in a certain CRS format
(maybe by reading the first few characters, or try catch exception handling )?
For WKT 1 (if a
raphaelauv opened a new issue, #10803:
URL: https://github.com/apache/iceberg/issues/10803
### Apache Iceberg version
None
### Query engine
None
### Please describe the bug 🐞
 should have updated
the latest version on the website. Let me check.
--
This is an automated message from the Apache Git S
rphadke-trinity opened a new issue, #10808:
URL: https://github.com/apache/iceberg/issues/10808
### Apache Iceberg version
1.6.0 (latest release)
### Query engine
Spark
### Please describe the bug 🐞
Error: UnsupportedOperationException: Byte-buffer read unsu
Xuanwo opened a new pull request, #499:
URL: https://github.com/apache/iceberg-rust/pull/499
This PR will remove an extra config parse logic that maps iceberg props into
config directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Fokko merged PR #10807:
URL: https://github.com/apache/iceberg/pull/10807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
liurenjie1024 commented on code in PR #499:
URL: https://github.com/apache/iceberg-rust/pull/499#discussion_r1695271890
##
crates/iceberg/src/io/storage_memory.rs:
##
@@ -15,31 +15,11 @@
// specific language governing permissions and limitations
// under the License.
-use st
Fokko commented on code in PR #499:
URL: https://github.com/apache/iceberg-rust/pull/499#discussion_r1695272318
##
Cargo.toml:
##
@@ -67,7 +67,7 @@ log = "^0.4"
mockito = "^1"
murmur3 = "0.5.2"
once_cell = "1"
-opendal = "0.47"
+opendal = "0.48"
Review Comment:
Nit: I thi
Fokko commented on issue #10808:
URL: https://github.com/apache/iceberg/issues/10808#issuecomment-2256000728
@rphadke-trinity Thanks for reporting this, do you also have a full
stacktrace? That would help to localize the problem.
--
This is an automated message from the Apache Git Service
Xuanwo commented on code in PR #499:
URL: https://github.com/apache/iceberg-rust/pull/499#discussion_r1695277156
##
Cargo.toml:
##
@@ -67,7 +67,7 @@ log = "^0.4"
mockito = "^1"
murmur3 = "0.5.2"
once_cell = "1"
-opendal = "0.47"
+opendal = "0.48"
Review Comment:
This PR r
Xuanwo commented on code in PR #499:
URL: https://github.com/apache/iceberg-rust/pull/499#discussion_r1695276546
##
Cargo.toml:
##
@@ -67,7 +67,7 @@ log = "^0.4"
mockito = "^1"
murmur3 = "0.5.2"
once_cell = "1"
-opendal = "0.47"
+opendal = "0.48"
Review Comment:
Got, let
Xuanwo commented on code in PR #499:
URL: https://github.com/apache/iceberg-rust/pull/499#discussion_r1695280401
##
Cargo.toml:
##
@@ -67,7 +67,7 @@ log = "^0.4"
mockito = "^1"
murmur3 = "0.5.2"
once_cell = "1"
-opendal = "0.47"
+opendal = "0.48"
Review Comment:
Hi, @liur
liurenjie1024 commented on issue #488:
URL: https://github.com/apache/iceberg-rust/issues/488#issuecomment-2256011677
> Thanks for starting this discussion first.
>
> My reason for not including a `default_table_root_location` (or
`default_warehouse_location`) at the catalog implement
Xuanwo commented on issue #488:
URL: https://github.com/apache/iceberg-rust/issues/488#issuecomment-2256015393
> Sounds reasonable to me. A more complete method is here:
https://github.com/apache/iceberg-python/blob/055938d36d46efb94849b1d861cd8a8a111f6ae5/pyiceberg/catalog/__init__.py#L880
liurenjie1024 commented on PR #492:
URL: https://github.com/apache/iceberg-rust/pull/492#issuecomment-2256018387
> It gives me a reflection that do we need the literal type like
`PrimitiveLiteral::Timestamp`. Or we can just use `PrimitiveLiteral::Long`.🤔
Yeah, I also think we no longe
liurenjie1024 commented on PR #492:
URL: https://github.com/apache/iceberg-rust/pull/492#issuecomment-2256026279
> > Yes. I think that's why we introduce `Datum`.
>
> Thank you for the reminder! It makes sense for me to remove it now.
I'll open an issue to track it.
--
This i
liurenjie1024 commented on code in PR #492:
URL: https://github.com/apache/iceberg-rust/pull/492#discussion_r1695292644
##
crates/iceberg/src/spec/values.rs:
##
@@ -76,7 +76,7 @@ pub enum PrimitiveLiteral {
/// UTF-8 bytes (without length)
String(String),
/// 16-b
Xuanwo commented on PR #492:
URL: https://github.com/apache/iceberg-rust/pull/492#issuecomment-2256024569
> Yes. I think that's why we introduce `Datum`.
Thank you for the reminder! It makes sense for me to remove it now.
--
This is an automated message from the Apache Git Service.
ajantha-bhat commented on PR #9921:
URL: https://github.com/apache/iceberg/pull/9921#issuecomment-2256030607
Closing this PR as https://github.com/apache/iceberg/pull/10402 has handled
the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
ajantha-bhat closed pull request #9921: Docs: update document release steps
URL: https://github.com/apache/iceberg/pull/9921
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Xuanwo merged PR #500:
URL: https://github.com/apache/iceberg-rust/pull/500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.a
Xuanwo commented on code in PR #499:
URL: https://github.com/apache/iceberg-rust/pull/499#discussion_r1695300548
##
crates/iceberg/src/io/storage_memory.rs:
##
@@ -15,31 +15,11 @@
// specific language governing permissions and limitations
// under the License.
-use std::coll
chinmay-bhat opened a new pull request, #976:
URL: https://github.com/apache/iceberg-python/pull/976
To allow spinning up containers for `make test-coverage` later, we now run
`make install` directly on the unzipped release project directory, which will
create a fresh python environment wit
liurenjie1024 merged PR #492:
URL: https://github.com/apache/iceberg-rust/pull/492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
liurenjie1024 commented on PR #494:
URL: https://github.com/apache/iceberg-rust/pull/494#issuecomment-2256052385
Thanks @fqaiser94 for this quick refactoring. In #488 we had further
discussion about it, please take a look.
--
This is an automated message from the Apache Git Service.
To re
ndrluis commented on issue #495:
URL: https://github.com/apache/iceberg-rust/issues/495#issuecomment-2256052967
@Xuanwo
> Hi, does remote signing means presign in s3?
Yes and no. I'm not sure if this is the flow, because I haven't found any
documentation; this is based on my un
liurenjie1024 commented on issue #495:
URL: https://github.com/apache/iceberg-rust/issues/495#issuecomment-2256072271
> I'm not comfortable closing this issue without a regression test that
guarantees the expected behavior.
+1 on this. Currently we don't have regression tests on the w
liurenjie1024 merged PR #499:
URL: https://github.com/apache/iceberg-rust/pull/499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
Fokko commented on PR #10809:
URL: https://github.com/apache/iceberg/pull/10809#issuecomment-2256107758
The PR freezes my browser, but it feels like there is something off:
- I would only expect added lines, no deletions
- It affects almost twice the number of files compared to the
Xuanwo commented on issue #495:
URL: https://github.com/apache/iceberg-rust/issues/495#issuecomment-2256126041
> It's a presign process, but it's not the client's responsibility to
presign. The get config will return the s3.signer.uri, and the load table will
return s3.remote-signing-enable
Xuanwo commented on issue #501:
URL: https://github.com/apache/iceberg-rust/issues/501#issuecomment-2256129508
Thanks for this. I support this change,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
liurenjie1024 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695336217
##
website/src/reference/podman.md:
##
@@ -0,0 +1,87 @@
+
+
+# Using Podman instead of Docker
+
+The majority of iceberg-rust is agnostic as to which container
ZENOTME commented on issue #501:
URL: https://github.com/apache/iceberg-rust/issues/501#issuecomment-2256141727
Also +1 for this and I'm glad to send the PR to do this later if we decide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
liurenjie1024 commented on PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#issuecomment-2256148753
Hi, @alexyin1
> What is the purpose of ARG BUILDPLATFORM and when/where should that be
used? It was only present in one of the Dockerfiles, so I removed it.
It's us
liurenjie1024 merged PR #496:
URL: https://github.com/apache/iceberg-rust/pull/496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
liurenjie1024 commented on PR #496:
URL: https://github.com/apache/iceberg-rust/pull/496#issuecomment-2256154481
I guess #501 would also simplify this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
bryanck commented on PR #10739:
URL: https://github.com/apache/iceberg/pull/10739#issuecomment-2256167831
Thanks for the reviews @danielcweeks , @fqaiser94 , and @ajantha-bhat !!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
bryanck merged PR #10739:
URL: https://github.com/apache/iceberg/pull/10739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.a
RussellSpitzer commented on issue #10312:
URL: https://github.com/apache/iceberg/issues/10312#issuecomment-2256202203
The validation error looks correct. Since we shouldn't be able to do the
rewrite if the equality delete has been written in the middle.
When we se using starting sequ
jbonofre commented on PR #10809:
URL: https://github.com/apache/iceberg/pull/10809#issuecomment-2256215778
@Fokko it's probably because I update the `latest` folder with 1.6.0. Should
I only add 1.6.0 without changing `latest` ?
--
This is an automated message from the Apache Git Service.
jbonofre commented on PR #10809:
URL: https://github.com/apache/iceberg/pull/10809#issuecomment-2256225891
@Fokko I updated this PR to just add `1.6.0` folder (not touching `latest`
folder).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
sdd commented on issue #501:
URL: https://github.com/apache/iceberg-rust/issues/501#issuecomment-2256250188
This would make a lot of sense. I was also never keen on the names. Maybe we
could rename Datum to `LogicalValue` and have `PhysicalValue` for primitive,
similar to Parquet?
--
Th
sdd commented on issue #501:
URL: https://github.com/apache/iceberg-rust/issues/501#issuecomment-2256252671
Actually if we did that it would diverge from the Iceberg spec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ajantha-bhat commented on code in PR #10810:
URL: https://github.com/apache/iceberg/pull/10810#discussion_r1695445101
##
site/docs/how-to-release.md:
##
@@ -270,6 +270,46 @@ git tag -am 'Release Apache Iceberg '
apache-iceberg- apache-i
Then release the candidate repository
huaxingao commented on PR #10024:
URL: https://github.com/apache/iceberg/pull/10024#issuecomment-2256302276
@laithalzyoud Thanks for your work on this PR! I've noticed there hasn't
been activity for a while, and I wanted to check if you're still able to
continue working on it. If you're bus
ZENOTME commented on issue #501:
URL: https://github.com/apache/iceberg-rust/issues/501#issuecomment-2256319932
I create an init PR #502 for this. I hope it can be a starting point to
discuss what's going on if we simplify PrimitiveLiteral. So feel free for any
suggestions.
--
This is an
manuzhang opened a new pull request, #10811:
URL: https://github.com/apache/iceberg/pull/10811
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
amogh-jahagirdar commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1695462421
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -597,6 +597,24 @@ public TableMetadata replaceProperties(Map
rawProperties) {
.b
Xuanwo commented on issue #495:
URL: https://github.com/apache/iceberg-rust/issues/495#issuecomment-2256378008
> Me and @ZENOTME did integration tests in icelake before, and I have to say
that without sql engine support, it's painful to maintain those tests.
I agree that we need a SQL
dramaticlly commented on code in PR #10811:
URL: https://github.com/apache/iceberg/pull/10811#discussion_r1695524219
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestDataFrameWrites.java:
##
@@ -419,5 +420,8 @@ public void testFaultToleranceOnWrite() throws
alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695526821
##
crates/catalog/rest/testdata/rest_catalog/docker-compose.yaml:
##
@@ -15,6 +15,9 @@
# specific language governing permissions and limitations
# under the Licen
alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695528164
##
crates/catalog/hms/testdata/hms_catalog/Dockerfile:
##
@@ -15,8 +15,6 @@
FROM --platform=$BUILDPLATFORM openjdk:8-jre-slim AS build
-ARG BUILDPLATFORM
Revi
szehon-ho commented on code in PR #10288:
URL: https://github.com/apache/iceberg/pull/10288#discussion_r1695534811
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/NDVSketchGenerator.java:
##
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation
szehon-ho commented on code in PR #10288:
URL: https://github.com/apache/iceberg/pull/10288#discussion_r1695534811
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/NDVSketchGenerator.java:
##
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation
Xuanwo commented on PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#issuecomment-2256406009
> Is there a cleaner way of having "CONTRIBUTING.MD" appear in the website
and as a toplevel file in the github? It's a little tricky getting both the
"github.com" version and the "rust
rphadke-trinity commented on issue #10808:
URL: https://github.com/apache/iceberg/issues/10808#issuecomment-2256439997
`org.apache.spark.SparkException: Job aborted due to stage failure: Task 0
in stage 12.0 failed 4 times, most recent failure: Lost task 0.3 in stage 12.0
(TID 205) (10.139.
rphadke-trinity commented on issue #10808:
URL: https://github.com/apache/iceberg/issues/10808#issuecomment-2256445409
Adding full stracktrace @Fokko
```python
org.apache.spark.SparkException: Job aborted due to stage failure: Task 0 in
stage 12.0 failed 4 times, most recent failu
szehon-ho commented on code in PR #10793:
URL: https://github.com/apache/iceberg/pull/10793#discussion_r1695559265
##
format/puffin-spec.md:
##
@@ -121,7 +121,9 @@ distinct values converted to bytes using Iceberg's
single-value serialization.
The blob metadata for this blob
singhpk234 commented on code in PR #10792:
URL: https://github.com/apache/iceberg/pull/10792#discussion_r1695514258
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CoordinatorThread.java:
##
@@ -65,5 +66,15 @@ boolean isTerminated() {
void te
callum-ryan opened a new pull request, #503:
URL: https://github.com/apache/iceberg-rust/pull/503
This is an add-on from @JanKaul's work in a previous PR - we have spoken on
slack and he is happy for me to open this PR.
--
This is an automated message from the Apache Git Service.
To respo
bryanck commented on code in PR #10792:
URL: https://github.com/apache/iceberg/pull/10792#discussion_r1695613576
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CoordinatorThread.java:
##
@@ -65,5 +66,15 @@ boolean isTerminated() {
void termi
RussellSpitzer commented on PR #10736:
URL: https://github.com/apache/iceberg/pull/10736#issuecomment-2256533305
Revapi broken (as expected) please fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
szehon-ho commented on code in PR #10784:
URL: https://github.com/apache/iceberg/pull/10784#discussion_r1695628950
##
api/src/main/java/org/apache/iceberg/actions/RepairManifests.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
singhpk234 commented on code in PR #10792:
URL: https://github.com/apache/iceberg/pull/10792#discussion_r1695631557
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CoordinatorThread.java:
##
@@ -65,5 +66,15 @@ boolean isTerminated() {
void te
fqaiser94 commented on code in PR #10792:
URL: https://github.com/apache/iceberg/pull/10792#discussion_r1695632061
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CoordinatorThread.java:
##
@@ -65,5 +66,15 @@ boolean isTerminated() {
void ter
findepi commented on code in PR #10793:
URL: https://github.com/apache/iceberg/pull/10793#discussion_r1695640265
##
format/puffin-spec.md:
##
@@ -121,7 +121,9 @@ distinct values converted to bytes using Iceberg's
single-value serialization.
The blob metadata for this blob ma
findepi commented on PR #10793:
URL: https://github.com/apache/iceberg/pull/10793#issuecomment-2256564863
> I am not sure, but does this mean an integer value like 2 now becomes 2.0?
(if using java toString)
no, this should be "2"
> And in any case, as its not entirely backward
rdblue commented on code in PR #10780:
URL: https://github.com/apache/iceberg/pull/10780#discussion_r1695651524
##
site/docs/contribute.md:
##
@@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as
[Github pull requests]
* If a PR is related to an issue,
alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695652798
##
CONTRIBUTING.md:
##
@@ -110,14 +110,16 @@ $ cargo version
cargo 1.69.0 (6e9a83356 2023-04-12)
```
- Install docker
+ Install Docker or Podman
-Curr
rdblue commented on code in PR #10780:
URL: https://github.com/apache/iceberg/pull/10780#discussion_r1695653411
##
site/docs/contribute.md:
##
@@ -45,6 +45,16 @@ The Iceberg community prefers to receive contributions as
[Github pull requests]
* If a PR is related to an issue,
alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695652798
##
CONTRIBUTING.md:
##
@@ -110,14 +110,16 @@ $ cargo version
cargo 1.69.0 (6e9a83356 2023-04-12)
```
- Install docker
+ Install Docker or Podman
-Curr
alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695652798
##
CONTRIBUTING.md:
##
@@ -110,14 +110,16 @@ $ cargo version
cargo 1.69.0 (6e9a83356 2023-04-12)
```
- Install docker
+ Install Docker or Podman
-Curr
bryanck commented on code in PR #10792:
URL: https://github.com/apache/iceberg/pull/10792#discussion_r1695665021
##
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CoordinatorThread.java:
##
@@ -65,5 +66,15 @@ boolean isTerminated() {
void termi
1 - 100 of 208 matches
Mail list logo
