alexyin1 commented on code in PR #489: URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695652798
########## CONTRIBUTING.md: ########## @@ -110,14 +110,16 @@ $ cargo version cargo 1.69.0 (6e9a83356 2023-04-12) ``` -#### Install docker +#### Install Docker or Podman -Currently, iceberg-rust uses docker to set up environment for integration tests. +Currently, iceberg-rust uses Docker to set up environment for integration tests. Podman is also supported. -You can learn how to install docker from [here](https://docs.docker.com/get-docker/). +You can learn how to install Docker from [here](https://docs.docker.com/get-docker/). For macos users, you can install [OrbStack](https://orbstack.dev/) as a docker alternative. +For podman users, refer to [Using Podman instead of Docker](https://rust.iceberg.apache.org/reference/podman.md) Review Comment: I believe symlink is used to have "CONTRIBUTING.MD" appear in toplevel of github and under website/src. I think ideally, the toplevel CONTRIBUTING.MD links to other documentation on github, and the website version link to the website, but I don't belleve that's possible with the current setup. Perhaps always linking to the website version like here is okay? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
