pvary commented on PR #10484: URL: https://github.com/apache/iceberg/pull/10484#issuecomment-2255494823
Hi @stevenzwu, I would like to move forward with this PR. I see the following open questions: 1. Lock implementation - I still think it is important to provide a working implementation without adding a requirement for external systems. For this the `Tag` based solution is working for every Iceberg deployment and there were no objections or better suggestions for it during the discussion on the mailing list (https://lists.apache.org/thread/vjf8m5wg840o58yz4y3q35k2mfhbm49l). Also tried to ask help from the Flink mailing list for alternative solutions, but I got a single one offline which turned out a dead end (https://lists.apache.org/thread/3ss83w1hp8wpocx13kcqr7qyjnghvnc8). - **I propose to remove the JVM based lock, and move forward with the Tag based lock** 2. TableChange parameters - I am open to discussing the list of parameters which will drive the triggers. It will touch a big part of the previous PR as well, and will make this change even harder to review/read. - **I propose to do it in the next PR** 3. There were some questions about the overall architecture. This is described in the original proposal doc [here](https://docs.google.com/document/d/16g3vR18mVBy8jbFaLjf2JwAANuYOmIwr15yDDxovdnA/edit#heading=h.5dc7u19et6mc). - **I'm open to discuss the proposal offline too, if that is needed.** WDYT @stevenzwu? Could we move forward along these lines, or do you have another proposal? Do you have any foundational concerns about the PR? Thanks, Peter -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
