[PR] build(deps): bump github.com/hamba/avro/v2 from 2.22.1 to 2.23.0 [iceberg-go]

2024-07-21 Thread via GitHub
dependabot[bot] opened a new pull request, #116: URL: https://github.com/apache/iceberg-go/pull/116 Bumps [github.com/hamba/avro/v2](https://github.com/hamba/avro) from 2.22.1 to 2.23.0. Release notes Sourced from https://github.com/hamba/avro/releases";>github.com/hamba/avro/v2's

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.27.16 to 1.27.26 [iceberg-go]

2024-07-21 Thread via GitHub
dependabot[bot] commented on PR #115: URL: https://github.com/apache/iceberg-go/pull/115#issuecomment-2241523201 Superseded by #117. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.27.16 to 1.27.26 [iceberg-go]

2024-07-21 Thread via GitHub
dependabot[bot] closed pull request #115: build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.27.16 to 1.27.26 URL: https://github.com/apache/iceberg-go/pull/115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[PR] build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.27.16 to 1.27.27 [iceberg-go]

2024-07-21 Thread via GitHub
dependabot[bot] opened a new pull request, #117: URL: https://github.com/apache/iceberg-go/pull/117 Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.27.16 to 1.27.27. Commits https://github.com/aws/aws-sdk-go-v2/commit/b8a0918056d0ae923f

Re: [PR] refine: move binary serialize in literal to datum [iceberg-rust]

2024-07-21 Thread via GitHub
xxchan commented on code in PR #456: URL: https://github.com/apache/iceberg-rust/pull/456#discussion_r1685679257 ## crates/iceberg/src/spec/values.rs: ## @@ -2714,23 +2660,27 @@ mod tests { assert_eq!(parsed_json_value, raw_json_value); } -fn check_avro_bytes

Re: [PR] refine: move binary serialize in literal to datum [iceberg-rust]

2024-07-21 Thread via GitHub
xxchan commented on code in PR #456: URL: https://github.com/apache/iceberg-rust/pull/456#discussion_r1685680738 ## crates/iceberg/src/spec/values.rs: ## @@ -2714,23 +2660,27 @@ mod tests { assert_eq!(parsed_json_value, raw_json_value); } -fn check_avro_bytes

Re: [PR] refine: move binary serialize in literal to datum [iceberg-rust]

2024-07-21 Thread via GitHub
ZENOTME commented on code in PR #456: URL: https://github.com/apache/iceberg-rust/pull/456#discussion_r1685680951 ## crates/iceberg/src/spec/values.rs: ## @@ -2714,23 +2660,27 @@ mod tests { assert_eq!(parsed_json_value, raw_json_value); } -fn check_avro_byte

Re: [PR] refine: move binary serialize in literal to datum [iceberg-rust]

2024-07-21 Thread via GitHub
xxchan commented on PR #456: URL: https://github.com/apache/iceberg-rust/pull/456#issuecomment-2241526618 BTW, why to we need the `RawLiteral` indirection layer, instead of having sth like ``` impl Literal { fn to_avro(&self) -> avro::Value {...} } ``` -- This is a

Re: [PR] refine: move binary serialize in literal to datum [iceberg-rust]

2024-07-21 Thread via GitHub
xxchan commented on code in PR #456: URL: https://github.com/apache/iceberg-rust/pull/456#discussion_r1685683007 ## crates/iceberg/src/spec/values.rs: ## @@ -2714,23 +2660,27 @@ mod tests { assert_eq!(parsed_json_value, raw_json_value); } -fn check_avro_bytes

Re: [PR] refine: move binary serialize in literal to datum [iceberg-rust]

2024-07-21 Thread via GitHub
ZENOTME commented on PR #456: URL: https://github.com/apache/iceberg-rust/pull/456#issuecomment-2241533708 > BTW, why to we need the `RawLiteral` indirection layer, instead of having sth like > > ``` > impl Literal { >fn to_avro(&self) -> avro::Value {...} > } > ```

[PR] UpdatePartitionSpec: Added ability to not set the new partition spec as default [iceberg]

2024-07-21 Thread via GitHub
shanielh opened a new pull request, #10736: URL: https://github.com/apache/iceberg/pull/10736 This may be used in cases where we want to add a partition spec but not set the new partition spec as default. For example, if I want to make sure that there's an unpartitioned spec since I

Re: [PR] S3 InputsStream: Reopen connection on Connection Reset [iceberg]

2024-07-21 Thread via GitHub
shanielh commented on PR #10470: URL: https://github.com/apache/iceberg/pull/10470#issuecomment-2241581138 > @shanielh Sorry about missing to link the issue on #10433, that's totally my bad. As @singhpk234 said, that PR should address the issue you're seeing here. I'll be revisiting the PR

[PR] chore(deps): Update typed-builder requirement from ^0.18 to ^0.19 [iceberg-rust]

2024-07-21 Thread via GitHub
dependabot[bot] opened a new pull request, #473: URL: https://github.com/apache/iceberg-rust/pull/473 Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: #

Re: [PR] Drop support for Java 8 [iceberg]

2024-07-21 Thread via GitHub
steveloughran commented on PR #10518: URL: https://github.com/apache/iceberg/pull/10518#issuecomment-2241607124 * making java11 your base version is great -but you'll need a followup of 'cut hadoop-2' profile. this is a good thing * java 22 is going to break a lost as they will cut `Subje

Re: [PR] View Spec implementation [iceberg-rust]

2024-07-21 Thread via GitHub
liurenjie1024 commented on code in PR #331: URL: https://github.com/apache/iceberg-rust/pull/331#discussion_r1684477421 ## crates/iceberg/src/spec/view_version.rs: ## @@ -0,0 +1,477 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license

Re: [PR] chore(deps): Update typed-builder requirement from ^0.18 to ^0.19 [iceberg-rust]

2024-07-21 Thread via GitHub
liurenjie1024 merged PR #473: URL: https://github.com/apache/iceberg-rust/pull/473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] feat: improve compatibility of S3 test minio connection [iceberg-rust]

2024-07-21 Thread via GitHub
liurenjie1024 commented on PR #470: URL: https://github.com/apache/iceberg-rust/pull/470#issuecomment-2241641393 Hi, @sdd Thanks for raising this, I'm also using mac (m3 pro) but didn't find the hang problem. 1. What docker version are you using? I've verfied it on orbstack and it wo

Re: [PR] feat: improve compatibility of S3 test minio connection [iceberg-rust]

2024-07-21 Thread via GitHub
liurenjie1024 commented on PR #470: URL: https://github.com/apache/iceberg-rust/pull/470#issuecomment-2241642067 I tried a similar approach before: https://github.com/apache/iceberg-rust/pull/424/files#diff-4458b5a449393945cd9cc982c11995fc72243950020cb75c659a559709f72b10 But it seem

Re: [PR] Build: Bump nessie from 0.92.1 to 0.93.1 [iceberg]

2024-07-21 Thread via GitHub
Fokko merged PR #10727: URL: https://github.com/apache/iceberg/pull/10727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

[PR] [wip] Table updates [iceberg-python]

2024-07-21 Thread via GitHub
kevinjqliu opened a new pull request, #950: URL: https://github.com/apache/iceberg-python/pull/950 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] feat: improve compatibility of S3 test minio connection [iceberg-rust]

2024-07-21 Thread via GitHub
sdd commented on PR #470: URL: https://github.com/apache/iceberg-rust/pull/470#issuecomment-2241732814 > 1. What docker version are you using? I've verfied it on orbstack and it works. Using an M1 Pro with MacOS Sonoma. Docker Desktop 4.32.0, Docker engine 27.0.3, Docker compose 2.28

Re: [I] [๐Ÿž] Collection of a few bugs [iceberg-python]

2024-07-21 Thread via GitHub
kevinjqliu commented on issue #864: URL: https://github.com/apache/iceberg-python/issues/864#issuecomment-2241733691 Thanks for the pointer! Looks like this is from the interactions between `CreateTableTransaction`, `StagedTable`, and the table updates. I found a difference in implementa

Re: [I] [๐Ÿž] Collection of a few bugs [iceberg-python]

2024-07-21 Thread via GitHub
kevinjqliu commented on issue #864: URL: https://github.com/apache/iceberg-python/issues/864#issuecomment-2241734091 For context, this is the `CreateTableTransaction`'s `self._updates` after `_initial_changes` ``` AssignUUIDUpdate( action='assign-uuid', uuid=UUID('14406c

Re: [I] [๐Ÿž] Collection of a few bugs [iceberg-python]

2024-07-21 Thread via GitHub
kevinjqliu commented on issue #864: URL: https://github.com/apache/iceberg-python/issues/864#issuecomment-2241735503 Also, this is what `_empty_table_metadata` creates ``` from pyiceberg.table.metadata import TableMetadataV1 from pyiceberg.schema import Schema TableMetadataV1(

[PR] Fix: Set Numpy Version Upper Limit [iceberg-python]

2024-07-21 Thread via GitHub
syun64 opened a new pull request, #951: URL: https://github.com/apache/iceberg-python/pull/951 numpy 2.0.0+ has been released, which isn't compatible with pandas <2.0.3 We should limit the upper bound on the numpy version until we are ready to upgrade the lower bound on the pandas ver

Re: [I] [๐Ÿž] Collection of a few bugs [iceberg-python]

2024-07-21 Thread via GitHub
kevinjqliu commented on issue #864: URL: https://github.com/apache/iceberg-python/issues/864#issuecomment-2241740968 Opened #950, I was able to remove the `initial_change` field and fix the table update visitor functions to make tests pass. I think we need more robust testing for the

Re: [PR] Fix: Set Numpy Version Upper Limit `numpy = { version = "^1.22.4", optional = true }` [iceberg-python]

2024-07-21 Thread via GitHub
syun64 commented on PR #951: URL: https://github.com/apache/iceberg-python/pull/951#issuecomment-2241748107 ray tests are failing due to: ``` import pandas # noqa > from pkg_resources._vendor.packaging.version import parse as parse_version E ModuleNotFoundError: No m

Re: [PR] Fix: Set Numpy Version Upper Limit `numpy = { version = "^1.22.4", optional = true }` [iceberg-python]

2024-07-21 Thread via GitHub
Fokko commented on code in PR #951: URL: https://github.com/apache/iceberg-python/pull/951#discussion_r1685801880 ## pyproject.toml: ## @@ -61,7 +61,7 @@ tenacity = ">=8.2.3,<9.0.0" pyarrow = { version = ">=9.0.0,<18.0.0", optional = true } pandas = { version = ">=1.0.0,<3.0.0

Re: [PR] Fix: Set Numpy Version Upper Limit `numpy = { version = "^1.22.4", optional = true }` [iceberg-python]

2024-07-21 Thread via GitHub
Fokko commented on code in PR #951: URL: https://github.com/apache/iceberg-python/pull/951#discussion_r1685802314 ## pyproject.toml: ## @@ -72,6 +72,7 @@ gcsfs = { version = ">=2023.1.0,<2024.1.0", optional = true } psycopg2-binary = { version = ">=2.9.6", optional = true } sq

Re: [PR] Fix: Set Numpy Version Upper Limit `numpy = { version = "^1.22.4", optional = true }` [iceberg-python]

2024-07-21 Thread via GitHub
syun64 commented on code in PR #951: URL: https://github.com/apache/iceberg-python/pull/951#discussion_r1685802216 ## pyproject.toml: ## @@ -61,7 +61,7 @@ tenacity = ">=8.2.3,<9.0.0" pyarrow = { version = ">=9.0.0,<18.0.0", optional = true } pandas = { version = ">=1.0.0,<3.0.

Re: [PR] Fix: Set Numpy Version Upper Limit `numpy = { version = "^1.22.4", optional = true }` [iceberg-python]

2024-07-21 Thread via GitHub
Fokko commented on code in PR #951: URL: https://github.com/apache/iceberg-python/pull/951#discussion_r1685802314 ## pyproject.toml: ## @@ -72,6 +72,7 @@ gcsfs = { version = ">=2023.1.0,<2024.1.0", optional = true } psycopg2-binary = { version = ">=2.9.6", optional = true } sq

Re: [PR] Fix: Set Numpy Version Upper Limit `numpy = { version = "^1.22.4", optional = true }` [iceberg-python]

2024-07-21 Thread via GitHub
syun64 commented on code in PR #951: URL: https://github.com/apache/iceberg-python/pull/951#discussion_r1685802448 ## pyproject.toml: ## @@ -72,6 +72,7 @@ gcsfs = { version = ">=2023.1.0,<2024.1.0", optional = true } psycopg2-binary = { version = ">=2.9.6", optional = true } s

Re: [PR] Fix: Set Numpy Version Upper Limit `numpy = { version = "^1.22.4", optional = true }` [iceberg-python]

2024-07-21 Thread via GitHub
syun64 commented on code in PR #951: URL: https://github.com/apache/iceberg-python/pull/951#discussion_r1685802948 ## pyproject.toml: ## @@ -61,7 +61,7 @@ tenacity = ">=8.2.3,<9.0.0" pyarrow = { version = ">=9.0.0,<18.0.0", optional = true } pandas = { version = ">=1.0.0,<3.0.

Re: [PR] Fix: Set Numpy Version Upper Limit `numpy = { version = "^1.22.4", optional = true }` [iceberg-python]

2024-07-21 Thread via GitHub
syun64 commented on code in PR #951: URL: https://github.com/apache/iceberg-python/pull/951#discussion_r1685803232 ## pyproject.toml: ## @@ -72,6 +72,7 @@ gcsfs = { version = ">=2023.1.0,<2024.1.0", optional = true } psycopg2-binary = { version = ">=2.9.6", optional = true } s

Re: [PR] Fix: Set Numpy Version Upper Limit `numpy = { version = "^1.22.4", optional = true }` [iceberg-python]

2024-07-21 Thread via GitHub
Fokko commented on code in PR #951: URL: https://github.com/apache/iceberg-python/pull/951#discussion_r1685803894 ## pyproject.toml: ## @@ -72,6 +72,7 @@ gcsfs = { version = ">=2023.1.0,<2024.1.0", optional = true } psycopg2-binary = { version = ">=2.9.6", optional = true } sq

Re: [PR] Fix: Set Numpy Version Upper Limit `numpy = { version = "^1.22.4", optional = true }` [iceberg-python]

2024-07-21 Thread via GitHub
Fokko commented on code in PR #951: URL: https://github.com/apache/iceberg-python/pull/951#discussion_r1685803956 ## pyproject.toml: ## @@ -72,6 +72,7 @@ gcsfs = { version = ">=2023.1.0,<2024.1.0", optional = true } psycopg2-binary = { version = ">=2.9.6", optional = true } sq

Re: [PR] Fix: Set Numpy Version Upper Limit `numpy = { version = "^1.22.4", optional = true }` [iceberg-python]

2024-07-21 Thread via GitHub
Fokko commented on code in PR #951: URL: https://github.com/apache/iceberg-python/pull/951#discussion_r1685803956 ## pyproject.toml: ## @@ -72,6 +72,7 @@ gcsfs = { version = ">=2023.1.0,<2024.1.0", optional = true } psycopg2-binary = { version = ">=2.9.6", optional = true } sq

Re: [PR] Fix: Set Numpy Version Upper Limit `numpy = { version = "^1.22.4", optional = true }` [iceberg-python]

2024-07-21 Thread via GitHub
Fokko commented on code in PR #951: URL: https://github.com/apache/iceberg-python/pull/951#discussion_r1685805115 ## pyproject.toml: ## @@ -72,6 +72,7 @@ gcsfs = { version = ">=2023.1.0,<2024.1.0", optional = true } psycopg2-binary = { version = ">=2.9.6", optional = true } sq

Re: [PR] Fix: Set Numpy Version Upper Limit `numpy = { version = "^1.22.4", optional = true }` [iceberg-python]

2024-07-21 Thread via GitHub
syun64 commented on code in PR #951: URL: https://github.com/apache/iceberg-python/pull/951#discussion_r1685805897 ## pyproject.toml: ## @@ -72,6 +72,7 @@ gcsfs = { version = ">=2023.1.0,<2024.1.0", optional = true } psycopg2-binary = { version = ">=2.9.6", optional = true } s

Re: [PR] Fix: Set Numpy Version Upper Limit `numpy = { version = "^1.22.4", optional = true }` [iceberg-python]

2024-07-21 Thread via GitHub
syun64 commented on code in PR #951: URL: https://github.com/apache/iceberg-python/pull/951#discussion_r1685806029 ## pyproject.toml: ## @@ -61,7 +61,7 @@ tenacity = ">=8.2.3,<9.0.0" pyarrow = { version = ">=9.0.0,<18.0.0", optional = true } pandas = { version = ">=1.0.0,<3.0.

Re: [PR] Fix: Set Numpy Version Upper Limit `numpy = { version = "^1.22.4", optional = true }` [iceberg-python]

2024-07-21 Thread via GitHub
syun64 commented on code in PR #951: URL: https://github.com/apache/iceberg-python/pull/951#discussion_r1685807001 ## pyproject.toml: ## @@ -61,7 +61,10 @@ tenacity = ">=8.2.3,<9.0.0" pyarrow = { version = ">=9.0.0,<18.0.0", optional = true } pandas = { version = ">=1.0.0,<3.0

Re: [PR] Fix: Set Numpy Version Upper Limit `numpy = { version = "^1.22.4", optional = true }` [iceberg-python]

2024-07-21 Thread via GitHub
syun64 commented on code in PR #951: URL: https://github.com/apache/iceberg-python/pull/951#discussion_r1685807001 ## pyproject.toml: ## @@ -61,7 +61,10 @@ tenacity = ">=8.2.3,<9.0.0" pyarrow = { version = ">=9.0.0,<18.0.0", optional = true } pandas = { version = ">=1.0.0,<3.0

Re: [PR] Fix: Set Numpy Version Upper Limit `numpy = { version = "^1.22.4", optional = true }` [iceberg-python]

2024-07-21 Thread via GitHub
syun64 commented on code in PR #951: URL: https://github.com/apache/iceberg-python/pull/951#discussion_r1685807361 ## pyproject.toml: ## @@ -72,6 +72,7 @@ gcsfs = { version = ">=2023.1.0,<2024.1.0", optional = true } psycopg2-binary = { version = ">=2.9.6", optional = true } s

[PR] add test [iceberg-python]

2024-07-21 Thread via GitHub
kevinjqliu opened a new pull request, #952: URL: https://github.com/apache/iceberg-python/pull/952 While looking at #864 and #950, I noticed that some TableUpdate classes do not have corresponding `_apply_table_update` function. I think we should enforce this in tests so that any future T

[PR] Kafka Connect: Runtime distribution and integration tests [iceberg]

2024-07-21 Thread via GitHub
bryanck opened a new pull request, #10739: URL: https://github.com/apache/iceberg/pull/10739 This PR is the next stage in submitting the Kafka Connect Iceberg sink connector, and is a follow up to https://github.com/apache/iceberg/pull/8701, https://github.com/apache/iceberg/pull/9466, htt

[I] Remaining Kafka Connect sink tasks [iceberg]

2024-07-21 Thread via GitHub
bryanck opened a new issue, #10740: URL: https://github.com/apache/iceberg/issues/10740 ### Feature Request / Improvement We need to submit the following remaining tasks to complete the initial Kafka Connect sink submission: - Building of the runtime distributions - Integration

Re: [I] Metadata field `last-updated-ms` is not updated for DDL operations [iceberg-python]

2024-07-21 Thread via GitHub
soumya-ghosh commented on issue #948: URL: https://github.com/apache/iceberg-python/issues/948#issuecomment-2241787796 I can work on this one. @kevinjqliu please assign this issue to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Flink: parameterize Flink table source tests to test both old and FLIP-27 source implementations [iceberg]

2024-07-21 Thread via GitHub
stevenzwu commented on code in PR #10741: URL: https://github.com/apache/iceberg/pull/10741#discussion_r1685830193 ## flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkSourceConfig.java: ## @@ -24,20 +24,21 @@ import java.util.List; import org.apache.fli

Re: [PR] Flink: parameterize Flink table source tests to test both old and FLIP-27 source implementations [iceberg]

2024-07-21 Thread via GitHub
stevenzwu commented on code in PR #10741: URL: https://github.com/apache/iceberg/pull/10741#discussion_r1685830304 ## flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TableSourceTestBase.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Flink: parameterize Flink table source tests to test both old and FLIP-27 source implementations [iceberg]

2024-07-21 Thread via GitHub
stevenzwu commented on code in PR #10741: URL: https://github.com/apache/iceberg/pull/10741#discussion_r1685830372 ## flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkSourceConfig.java: ## @@ -46,8 +47,11 @@ public void testFlinkHintConfig() { assert

Re: [PR] Core: read delete files in parallel [iceberg]

2024-07-21 Thread via GitHub
github-actions[bot] commented on PR #3120: URL: https://github.com/apache/iceberg/pull/3120#issuecomment-2241831110 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think thatโ€™s incorrect or this pull

Re: [I] Table to retractStream error [iceberg]

2024-07-21 Thread via GitHub
github-actions[bot] commented on issue #3121: URL: https://github.com/apache/iceberg/issues/3121#issuecomment-2241831121 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] When writing data to S3 using Glue Catalog, current snapshot ID is -1 and not updated in the metadata file generated [iceberg]

2024-07-21 Thread via GitHub
github-actions[bot] commented on issue #3124: URL: https://github.com/apache/iceberg/issues/3124#issuecomment-2241831133 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Flink: Migrate remaining classes to JUnit5 [iceberg]

2024-07-21 Thread via GitHub
tomtongue commented on PR #10684: URL: https://github.com/apache/iceberg/pull/10684#issuecomment-2241892402 @nastra Added all the remaining classes and removed `getSourceTableExtension` and `getSinkTableExtension`. Could you review the changes? -- This is an automated message from the Ap

Re: [I] write.metadata.metrics.max-inferred-column-defaults doesn't work for rewrite_data_file? [iceberg]

2024-07-21 Thread via GitHub
chenwyi2 commented on issue #10707: URL: https://github.com/apache/iceberg/issues/10707#issuecomment-2241984594 oh i see, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [I] write.metadata.metrics.max-inferred-column-defaults doesn't work for rewrite_data_file? [iceberg]

2024-07-21 Thread via GitHub
chenwyi2 closed issue #10707: write.metadata.metrics.max-inferred-column-defaults doesn't work for rewrite_data_file? URL: https://github.com/apache/iceberg/issues/10707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Flink: parameterize Flink table source tests to test both old and FLIP-27 source implementations [iceberg]

2024-07-21 Thread via GitHub
nastra commented on code in PR #10741: URL: https://github.com/apache/iceberg/pull/10741#discussion_r1685955271 ## flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkSourceConfig.java: ## @@ -46,8 +47,11 @@ public void testFlinkHintConfig() { assertTha

Re: [I] Remaining Kafka Connect sink tasks [iceberg]

2024-07-21 Thread via GitHub
nk1506 commented on issue #10740: URL: https://github.com/apache/iceberg/issues/10740#issuecomment-2242085897 Hi @bryanck , I am interested in contributing to Kafka-Connect tasks. Please let me know if there are any opportunities for me to contribute. -- This is an automated message

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

2024-07-21 Thread via GitHub
ajantha-bhat commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1685990795 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

2024-07-21 Thread via GitHub
ajantha-bhat commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1685995645 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2

Re: [PR] Flink: Migrate remaining classes to JUnit5 [iceberg]

2024-07-21 Thread via GitHub
nastra commented on code in PR #10684: URL: https://github.com/apache/iceberg/pull/10684#discussion_r1686000131 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/sink/TestCompressionSettings.java: ## @@ -91,19 +94,36 @@ public void testCompressionAvro() throws Exceptio

Re: [PR] Flink: Migrate remaining classes to JUnit5 [iceberg]

2024-07-21 Thread via GitHub
nastra commented on code in PR #10684: URL: https://github.com/apache/iceberg/pull/10684#discussion_r1686000869 ## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/sink/TestCompressionSettings.java: ## @@ -91,19 +94,36 @@ public void testCompressionAvro() throws Exceptio

Re: [PR] Spec: Clarify time travel implementation in Iceberg [iceberg]

2024-07-21 Thread via GitHub
ajantha-bhat commented on code in PR #8982: URL: https://github.com/apache/iceberg/pull/8982#discussion_r1686001845 ## format/spec.md: ## @@ -1370,3 +1370,16 @@ Writing v2 metadata: * `sort_columns` was removed Note that these requirements apply when writing data to a v2

Re: [PR] Build: Bump org.testcontainers:testcontainers from 1.19.8 to 1.20.0 [iceberg]

2024-07-21 Thread via GitHub
Fokko merged PR #10730: URL: https://github.com/apache/iceberg/pull/10730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Build: Bump orc from 1.9.3 to 1.9.4 [iceberg]

2024-07-21 Thread via GitHub
Fokko commented on PR #10728: URL: https://github.com/apache/iceberg/pull/10728#issuecomment-2242202692 @jbonofre Just a heads up :) In the case of another RC, we want to backport this one as well, since it fixes a CVE -- This is an automated message from the Apache Git Service. To respon

Re: [I] How to query a specified partition data file๏ผŸ [iceberg]

2024-07-21 Thread via GitHub
melin commented on issue #10725: URL: https://github.com/apache/iceberg/issues/10725#issuecomment-2242223631 cc @rdblue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To