stevenzwu commented on code in PR #10741:
URL: https://github.com/apache/iceberg/pull/10741#discussion_r1685830193
##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkSourceConfig.java:
##########
@@ -24,20 +24,21 @@
import java.util.List;
import org.apache.flink.types.Row;
import org.apache.iceberg.flink.FlinkReadOptions;
-import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.Assumptions;
+import org.junit.jupiter.api.TestTemplate;
-public class TestFlinkSourceConfig extends TestFlinkTableSource {
+public class TestFlinkSourceConfig extends TableSourceTestBase {
Review Comment:
Extracted common code from `TestFlinkTableSource` to an abstract base class
`TableSourceTestBase`. otherwise, `TestFlinkSourceConfig` also include every
test from `TestFlinkTableSource`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
