xxchan commented on code in PR #456:
URL: https://github.com/apache/iceberg-rust/pull/456#discussion_r1685679257
##########
crates/iceberg/src/spec/values.rs:
##########
@@ -2714,23 +2660,27 @@ mod tests {
assert_eq!(parsed_json_value, raw_json_value);
}
- fn check_avro_bytes_serde(input: Vec<u8>, expected_literal: Literal,
expected_type: &Type) {
+ fn check_avro_bytes_serde(
+ input: Vec<u8>,
+ expected_datum: Datum,
+ expected_type: &PrimitiveType,
+ ) {
let raw_schema = r#""bytes""#;
let schema = apache_avro::Schema::parse_str(raw_schema).unwrap();
let bytes = ByteBuf::from(input);
- let literal = Literal::try_from_bytes(&bytes, expected_type).unwrap();
- assert_eq!(literal, expected_literal);
+ let datum = Datum::try_from_bytes(&bytes,
expected_type.clone()).unwrap();
+ assert_eq!(datum, expected_datum);
Review Comment:
This looks quite suspicious. `Datum::try_from_bytes ` links to
<https://iceberg.apache.org/spec/#binary-single-value-serialization>, which is
not Avro encoding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
