nastra commented on code in PR #10741:
URL: https://github.com/apache/iceberg/pull/10741#discussion_r1685955271
##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkSourceConfig.java:
##########
@@ -46,8 +47,11 @@ public void testFlinkHintConfig() {
assertThat(result).hasSize(3);
}
- @Test
+ @TestTemplate
public void testReadOptionHierarchy() {
+ // TODO: FLIP-27 source doesn't implement limit pushdown yet
+ Assumptions.assumeFalse(useFlip27Source);
Review Comment:
```suggestion
assumeThat(useFlip27Source).isFalse();
```
we've switched to AssertJ assumptions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
