[GitHub] [iceberg] nastra commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

nastra commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1050439739 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [iceberg] nastra commented on a diff in pull request #5837: API,Core: Introduce metrics for data files by file format

nastra commented on code in PR #5837: URL: https://github.com/apache/iceberg/pull/5837#discussion_r1050492924 ## api/src/main/java/org/apache/iceberg/metrics/MultiDimensionCounterKey.java: ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [iceberg] nastra commented on a diff in pull request #5837: API,Core: Introduce metrics for data files by file format

nastra commented on code in PR #5837: URL: https://github.com/apache/iceberg/pull/5837#discussion_r1050495424 ## api/src/main/java/org/apache/iceberg/metrics/MultiDimensionCounterKey.java: ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [iceberg] Fokko commented on a diff in pull request #6437: Python: Projection by Field ID

Fokko commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1050533828 ## python/pyiceberg/expressions/visitors.py: ## @@ -753,3 +757,68 @@ def inclusive_projection( schema: Schema, spec: PartitionSpec, case_sensitive: bool = True ) ->

[GitHub] [iceberg] Fokko commented on a diff in pull request #6437: Python: Projection by Field ID

Fokko commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1050535352 ## python/pyiceberg/expressions/visitors.py: ## @@ -753,3 +757,68 @@ def inclusive_projection( schema: Schema, spec: PartitionSpec, case_sensitive: bool = True ) ->

[GitHub] [iceberg] Fokko commented on a diff in pull request #6437: Python: Projection by Field ID

Fokko commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1050552255 ## python/pyiceberg/io/pyarrow.py: ## @@ -437,3 +457,103 @@ def visit_or(self, left_result: pc.Expression, right_result: pc.Expression) -> p def expression_to_pyarrow

[GitHub] [iceberg] gaborkaszab commented on a diff in pull request #6074: API,Core: SnapshotManager to be created through Transaction

gaborkaszab commented on code in PR #6074: URL: https://github.com/apache/iceberg/pull/6074#discussion_r1050562294 ## core/src/main/java/org/apache/iceberg/SnapshotManager.java: ## @@ -30,6 +31,17 @@ public class SnapshotManager implements ManageSnapshots { ops.current(

[GitHub] [iceberg] gaborkaszab commented on a diff in pull request #6074: API,Core: SnapshotManager to be created through Transaction

gaborkaszab commented on code in PR #6074: URL: https://github.com/apache/iceberg/pull/6074#discussion_r1050562294 ## core/src/main/java/org/apache/iceberg/SnapshotManager.java: ## @@ -30,6 +31,17 @@ public class SnapshotManager implements ManageSnapshots { ops.current(

[GitHub] [iceberg] gaborkaszab commented on issue #6257: Partitions metadata table shows old partitions

gaborkaszab commented on issue #6257: URL: https://github.com/apache/iceberg/issues/6257#issuecomment-1354499343 > Looks like without `USING iceberg` you don't create iceberg table and so it doesn't have to have even update support not speaking about partitions table https://user-images.git

[GitHub] [iceberg] Fokko commented on a diff in pull request #6437: Python: Projection by Field ID

Fokko commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1050575140 ## python/pyiceberg/io/pyarrow.py: ## @@ -437,3 +457,103 @@ def visit_or(self, left_result: pc.Expression, right_result: pc.Expression) -> p def expression_to_pyarrow

[GitHub] [iceberg] Fokko commented on a diff in pull request #6437: Python: Projection by Field ID

Fokko commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1050582655 ## python/pyiceberg/io/pyarrow.py: ## @@ -437,3 +457,103 @@ def visit_or(self, left_result: pc.Expression, right_result: pc.Expression) -> p def expression_to_pyarrow

[GitHub] [iceberg] Fokko commented on a diff in pull request #6437: Python: Projection by Field ID

Fokko commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1050583093 ## python/pyiceberg/io/pyarrow.py: ## @@ -437,3 +457,103 @@ def visit_or(self, left_result: pc.Expression, right_result: pc.Expression) -> p def expression_to_pyarrow

[GitHub] [iceberg] Fokko commented on a diff in pull request #6437: Python: Projection by Field ID

Fokko commented on code in PR #6437: URL: https://github.com/apache/iceberg/pull/6437#discussion_r1050587798 ## python/pyiceberg/io/pyarrow.py: ## @@ -437,3 +457,103 @@ def visit_or(self, left_result: pc.Expression, right_result: pc.Expression) -> p def expression_to_pyarrow

[GitHub] [iceberg] nastra commented on issue #6099: Flink: Add support for Flink 1.16

nastra commented on issue #6099: URL: https://github.com/apache/iceberg/issues/6099#issuecomment-1354541184 given that #6092 is merged, we can close this one out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [iceberg] nastra closed issue #6099: Flink: Add support for Flink 1.16

nastra closed issue #6099: Flink: Add support for Flink 1.16 URL: https://github.com/apache/iceberg/issues/6099 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [iceberg] nastra opened a new pull request, #6441: Run weekly JMH Benchmarks & visualize results

nastra opened a new pull request, #6441: URL: https://github.com/apache/iceberg/pull/6441 This runs the JMH Benchmarks every Sunday and also create a visual report for each benchmark and upload it after all benchmarks completed -- This is an automated message from the Apache Git Service.

[GitHub] [iceberg] findepi opened a new issue, #6442: Extends Iceberg table stats API to allow publish data and stats atomically

findepi opened a new issue, #6442: URL: https://github.com/apache/iceberg/issues/6442 ### Feature Request / Improvement Currently `UpdateStatistics` (`org.apache.iceberg.Transaction#updateStatistics`) allows adding statistics for an existing snapshot. As a result, it is currently

[GitHub] [iceberg] findepi commented on issue #6442: Extends Iceberg table stats API to allow publish data and stats atomically

findepi commented on issue #6442: URL: https://github.com/apache/iceberg/issues/6442#issuecomment-1355104260 cc @rdblue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [iceberg] findepi opened a new issue, #6443: Provide Puffin reader API allowing read without decompression

findepi opened a new issue, #6443: URL: https://github.com/apache/iceberg/issues/6443 ### Feature Request / Improvement When a query engine wants to add new stats to a snapshot that already has some stats, it currently needs to merge existing stats file' blobs with new ones.

[GitHub] [iceberg] lvyanquan opened a new pull request, #6444: Docs: add example of spark extension for identifier fields

lvyanquan opened a new pull request, #6444: URL: https://github.com/apache/iceberg/pull/6444 add doc for this extension https://github.com/apache/iceberg/pull/2560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [iceberg-docs] InvisibleProgrammer opened a new pull request, #189: Docs: Update hive docs 1.0.0

InvisibleProgrammer opened a new pull request, #189: URL: https://github.com/apache/iceberg-docs/pull/189 Porting recent documentation changes on hive integration: https://github.com/apache/iceberg/pull/6337 -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [iceberg-docs] InvisibleProgrammer opened a new pull request, #188: Docs: Update Iceberg Hive documentation (#6337)

InvisibleProgrammer opened a new pull request, #188: URL: https://github.com/apache/iceberg-docs/pull/188 Porting recent documentation changes on hive integration: https://github.com/apache/iceberg/pull/6337 -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [iceberg-docs] InvisibleProgrammer opened a new pull request, #190: Docs: Update hive docs 1.1.0

InvisibleProgrammer opened a new pull request, #190: URL: https://github.com/apache/iceberg-docs/pull/190 Porting recent documentation changes on hive integration: https://github.com/apache/iceberg/pull/6337 -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [iceberg] InvisibleProgrammer commented on pull request #6379: Docs: Update Iceberg Hive documentation - 1.0.x (#6337)

InvisibleProgrammer commented on PR #6379: URL: https://github.com/apache/iceberg/pull/6379#issuecomment-1355156829 I think I've found the proper way to update the documentation for older versions. What do you think, is that the correct way? - 0.14.1: https://github.com/apache/iceber

[GitHub] [iceberg] InvisibleProgrammer commented on issue #6249: Update Iceberg Hive documentation

InvisibleProgrammer commented on issue #6249: URL: https://github.com/apache/iceberg/issues/6249#issuecomment-1355157632 PRs for older versions: - 0.14.1: https://github.com/apache/iceberg-docs/pull/188 - 1.0.0: https://github.com/apache/iceberg-docs/pull/189 - 1.1.0: https://gi

[GitHub] [iceberg-docs] danielcweeks merged pull request #184: Add CelerData in vendors page

danielcweeks merged PR #184: URL: https://github.com/apache/iceberg-docs/pull/184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ice

[GitHub] [iceberg] rdblue commented on a diff in pull request #6293: Added FileIO Support for ORC Reader and Writers

rdblue commented on code in PR #6293: URL: https://github.com/apache/iceberg/pull/6293#discussion_r1050931726 ## orc/src/main/java/org/apache/iceberg/orc/FileIOFSUtil.java: ## @@ -0,0 +1,164 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

[GitHub] [iceberg] rdblue commented on a diff in pull request #6293: Added FileIO Support for ORC Reader and Writers

rdblue commented on code in PR #6293: URL: https://github.com/apache/iceberg/pull/6293#discussion_r1050934075 ## orc/src/main/java/org/apache/iceberg/orc/ORC.java: ## @@ -789,7 +808,210 @@ static Reader newFileReader(InputFile file, Configuration config) { ReaderOptions re

[GitHub] [iceberg] rdblue commented on a diff in pull request #6293: Added FileIO Support for ORC Reader and Writers

rdblue commented on code in PR #6293: URL: https://github.com/apache/iceberg/pull/6293#discussion_r1050935078 ## orc/src/test/java/org/apache/iceberg/orc/TestOrcDataWriter.java: ## @@ -126,4 +135,116 @@ public void testDataWriter() throws IOException { Assert.assertEquals

[GitHub] [iceberg-docs] pvary merged pull request #188: Docs: Update Iceberg Hive documentation (#6337)

pvary merged PR #188: URL: https://github.com/apache/iceberg-docs/pull/188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

[GitHub] [iceberg-docs] pvary merged pull request #190: Docs: Update hive docs 1.1.0

pvary merged PR #190: URL: https://github.com/apache/iceberg-docs/pull/190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

[GitHub] [iceberg-docs] pvary merged pull request #189: Docs: Update hive docs 1.0.0

pvary merged PR #189: URL: https://github.com/apache/iceberg-docs/pull/189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

[GitHub] [iceberg] manisin commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

manisin commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051059938 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [iceberg] szehon-ho commented on a diff in pull request #6433: Docs: README

szehon-ho commented on code in PR #6433: URL: https://github.com/apache/iceberg/pull/6433#discussion_r1051058098 ## README.md: ## @@ -34,7 +34,7 @@ Iceberg is under active development at the Apache Software Foundation. The core Java library that tracks table snapshots and me

[GitHub] [iceberg] manisin commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

manisin commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051066674 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

issues@iceberg.apache.org

haizhou-zhao commented on code in PR #6324: URL: https://github.com/apache/iceberg/pull/6324#discussion_r1051069226 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -422,11 +425,21 @@ private Table newHmsTable(TableMetadata metadata) {

issues@iceberg.apache.org

haizhou-zhao commented on PR #6324: URL: https://github.com/apache/iceberg/pull/6324#issuecomment-1355443482 > > Hey folks, comments from last round of review all taken and implemented. > > Specifically, on one comment: @gaborkaszab @szehon-ho I removed support for changing ownership for

[GitHub] [iceberg] rubenvdg opened a new pull request, #6445: Python: Mock home and root folder when running `test_missing_uri`

rubenvdg opened a new pull request, #6445: URL: https://github.com/apache/iceberg/pull/6445 This could be a way to alleviate this issue https://github.com/apache/iceberg/issues/6361. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [iceberg] rubenvdg commented on issue #6397: Python Instructions currently do not work for testing

rubenvdg commented on issue #6397: URL: https://github.com/apache/iceberg/issues/6397#issuecomment-1355516952 Yes agreed! It's already part of https://github.com/apache/iceberg/pull/6438, right? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [iceberg] Fokko commented on issue #6397: Python Instructions currently do not work for testing

Fokko commented on issue #6397: URL: https://github.com/apache/iceberg/issues/6397#issuecomment-1355517950 @rubenvdg Yes, I was doing some refactoring yesterday, and also included it in there 👍🏻 Feel free to review the PR :) -- This is an automated message from the Apache Git Service. To

[GitHub] [iceberg] manisin commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

manisin commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051114634 ## snowflake/src/main/java/org/apache/iceberg/snowflake/entities/SnowflakeTable.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] rdblue commented on pull request #6445: Python: Mock home and root folder when running `test_missing_uri`

rdblue commented on PR #6445: URL: https://github.com/apache/iceberg/pull/6445#issuecomment-1355564692 Looks good to me! @Fokko, can you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [iceberg] rdblue commented on pull request #6444: Docs: add example of spark extension for identifier fields

rdblue commented on PR #6444: URL: https://github.com/apache/iceberg/pull/6444#issuecomment-1355565531 Thanks, @lvyanquan! This looks great. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [iceberg] rdblue merged pull request #6444: Docs: add example of spark extension for identifier fields

rdblue merged PR #6444: URL: https://github.com/apache/iceberg/pull/6444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

[GitHub] [iceberg] rdblue merged pull request #6441: Run weekly JMH Benchmarks & visualize results

rdblue merged PR #6441: URL: https://github.com/apache/iceberg/pull/6441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

[GitHub] [iceberg] rdblue commented on pull request #6441: Run weekly JMH Benchmarks & visualize results

rdblue commented on PR #6441: URL: https://github.com/apache/iceberg/pull/6441#issuecomment-1355567338 Thanks, @nastra! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [iceberg] rdblue commented on a diff in pull request #6438: Python: Reduce the use of mock objects

rdblue commented on code in PR #6438: URL: https://github.com/apache/iceberg/pull/6438#discussion_r1051136493 ## python/pyiceberg/avro/reader.py: ## @@ -104,16 +104,22 @@ def _skip_map_array(decoder: BinaryDecoder, skip_entry: Callable[[], None]) -> N block_count = dec

[GitHub] [iceberg] rdblue commented on pull request #6438: Python: Reduce the use of mock objects

rdblue commented on PR #6438: URL: https://github.com/apache/iceberg/pull/6438#issuecomment-1355572986 Looks good to me! I'm not merging in case you want to move/rename `AvroStruct` since it is really a generic class and not specific to Avro. -- This is an automated message from the Apach

[GitHub] [iceberg] Fokko opened a new pull request, #6446: Python: Support for UUID

Fokko opened a new pull request, #6446: URL: https://github.com/apache/iceberg/pull/6446 Closes #6434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [iceberg] pavibhai commented on a diff in pull request #6293: Added FileIO Support for ORC Reader and Writers

pavibhai commented on code in PR #6293: URL: https://github.com/apache/iceberg/pull/6293#discussion_r1051169885 ## orc/src/main/java/org/apache/iceberg/orc/FileIOFSUtil.java: ## @@ -0,0 +1,164 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more cont

[GitHub] [iceberg] pavibhai commented on a diff in pull request #6293: Added FileIO Support for ORC Reader and Writers

pavibhai commented on code in PR #6293: URL: https://github.com/apache/iceberg/pull/6293#discussion_r1051170766 ## orc/src/test/java/org/apache/iceberg/orc/TestOrcDataWriter.java: ## @@ -126,4 +135,116 @@ public void testDataWriter() throws IOException { Assert.assertEqua

[GitHub] [iceberg] pavibhai commented on a diff in pull request #6293: Added FileIO Support for ORC Reader and Writers

pavibhai commented on code in PR #6293: URL: https://github.com/apache/iceberg/pull/6293#discussion_r1051170973 ## orc/src/main/java/org/apache/iceberg/orc/ORC.java: ## @@ -789,7 +808,210 @@ static Reader newFileReader(InputFile file, Configuration config) { ReaderOptions

[GitHub] [iceberg] Fokko commented on a diff in pull request #6445: Python: Mock home and root folder when running `test_missing_uri`

Fokko commented on code in PR #6445: URL: https://github.com/apache/iceberg/pull/6445#discussion_r1051172204 ## python/tests/utils/test_config.py: ## @@ -39,7 +40,7 @@ def test_from_environment_variables_uppercase() -> None: assert Config().get_catalog_config("PRODUCTION")

[GitHub] [iceberg] szehon-ho commented on a diff in pull request #6344: Spark 3.3: Introduce the changelog iterator

szehon-ho commented on code in PR #6344: URL: https://github.com/apache/iceberg/pull/6344#discussion_r1051211196 ## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/ChangelogIterator.java: ## @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] szehon-ho commented on a diff in pull request #6344: Spark 3.3: Introduce the changelog iterator

szehon-ho commented on code in PR #6344: URL: https://github.com/apache/iceberg/pull/6344#discussion_r1051211196 ## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/ChangelogIterator.java: ## @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051230270 ## build.gradle: ## @@ -696,6 +696,26 @@ project(':iceberg-dell') { } } +project(':iceberg-snowflake') { + test { +useJUnitPlatform() + } + + dependencie

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051230626 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051230895 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051231396 ## snowflake/src/test/java/org/apache/iceberg/snowflake/SnowflakeCatalogTest.java: ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051241597 ## snowflake/src/test/java/org/apache/iceberg/snowflake/SnowflakeCatalogTest.java: ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051241705 ## snowflake/src/test/java/org/apache/iceberg/snowflake/SnowflakeCatalogTest.java: ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051244552 ## snowflake/src/main/java/org/apache/iceberg/snowflake/JdbcSnowflakeClient.java: ## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051245397 ## snowflake/src/main/java/org/apache/iceberg/snowflake/JdbcSnowflakeClient.java: ## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051251362 ## snowflake/src/main/java/org/apache/iceberg/snowflake/JdbcSnowflakeClient.java: ## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] szehon-ho commented on a diff in pull request #6365: Core: Add position deletes metadata table

szehon-ho commented on code in PR #6365: URL: https://github.com/apache/iceberg/pull/6365#discussion_r1051251356 ## core/src/main/java/org/apache/iceberg/AbstractTableScan.java: ## @@ -0,0 +1,173 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051262362 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051264532 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051265807 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeClient.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051267959 ## snowflake/src/test/java/org/apache/iceberg/snowflake/SnowflakeCatalogTest.java: ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051272184 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051274163 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051274675 ## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeResources.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [iceberg] dennishuo commented on a diff in pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1051274939 ## snowflake/src/main/java/org/apache/iceberg/snowflake/entities/SnowflakeTable.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [iceberg] xwmr-max commented on pull request #6440: Flink: Support Look-up Function

xwmr-max commented on PR #6440: URL: https://github.com/apache/iceberg/pull/6440#issuecomment-1355946472 cc @stevenzwu @hililiwei -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [iceberg] dennishuo commented on pull request #6428: Add new SnowflakeCatalog implementation to enable directly using Snowflake-managed Iceberg tables

dennishuo commented on PR #6428: URL: https://github.com/apache/iceberg/pull/6428#issuecomment-1356015002 @nastra Thanks for the thorough review and suggestions! Finished applying all your suggestions, including fully converting to `assertj`/`Assertions` and refactoring out the Namespace<->

[GitHub] [iceberg] pvary commented on issue #6370: What is the purpose of Hive Lock ?

pvary commented on issue #6370: URL: https://github.com/apache/iceberg/issues/6370#issuecomment-1356061017 @InvisibleProgrammer, @TuroczyX: any news about the atomic lock? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [iceberg] rubenvdg commented on a diff in pull request #6445: Python: Mock home and root folder when running `test_missing_uri`

rubenvdg commented on code in PR #6445: URL: https://github.com/apache/iceberg/pull/6445#discussion_r1051331332 ## python/tests/cli/test_console.py: ## @@ -134,14 +134,17 @@ def update_namespace_properties( MOCK_ENVIRONMENT = {"PYICEBERG_CATALOG__PRODUCTION__URI": "test://does

[GitHub] [iceberg] rubenvdg commented on a diff in pull request #6445: Python: Mock home and root folder when running `test_missing_uri`

rubenvdg commented on code in PR #6445: URL: https://github.com/apache/iceberg/pull/6445#discussion_r1051332065 ## python/tests/cli/test_console.py: ## @@ -134,14 +134,17 @@ def update_namespace_properties( MOCK_ENVIRONMENT = {"PYICEBERG_CATALOG__PRODUCTION__URI": "test://does

[GitHub] [iceberg] rubenvdg commented on a diff in pull request #6445: Python: Mock home and root folder when running `test_missing_uri`

rubenvdg commented on code in PR #6445: URL: https://github.com/apache/iceberg/pull/6445#discussion_r1051331332 ## python/tests/cli/test_console.py: ## @@ -134,14 +134,17 @@ def update_namespace_properties( MOCK_ENVIRONMENT = {"PYICEBERG_CATALOG__PRODUCTION__URI": "test://does

[GitHub] [iceberg] shardulm94 commented on issue #6224: Spark: regression / query failure with Iceberg 1.0.0 and UNION

shardulm94 commented on issue #6224: URL: https://github.com/apache/iceberg/issues/6224#issuecomment-1356083642 Hey @maximethebault! Thanks for the report. I investigated this and found that that it is actually a bug in Spark 3.3.1+. I have created [SPARK-41557](https://issues.apache.org