rubenvdg commented on code in PR #6445:
URL: https://github.com/apache/iceberg/pull/6445#discussion_r1051332065
##########
python/tests/cli/test_console.py:
##########
@@ -134,14 +134,17 @@ def update_namespace_properties(
MOCK_ENVIRONMENT = {"PYICEBERG_CATALOG__PRODUCTION__URI":
"test://doesnotexist"}
-def test_missing_uri() -> None:
- runner = CliRunner()
- result = runner.invoke(run, ["list"])
- assert result.exit_code == 1
- assert (
- result.output
- == "URI missing, please provide using --uri, the config or environment
variable \nPYICEBERG_CATALOG__DEFAULT__URI\n"
- )
+def test_missing_uri(empty_home_dir_path: str) -> None:
Review Comment:
Alternatively, we could do something like this in `conftest.py`:
```
def make_temporary_home_folder(tmp_path_factory) -> None:
home_path = str(tmp_path_factory.mktemp("home"))
os.environ["TMP_HOME_PATH"] = home_path
```
and then in the test
```
@mock.patch.dict(os.environ, {"HOME": os.environ["TMP_HOME_PATH"]})
def test_missing_uri():
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
