yegangy0718 commented on code in PR #6382:
URL: https://github.com/apache/iceberg/pull/6382#discussion_r1045449754
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/ShuffleOperator.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundati
amogh-jahagirdar opened a new pull request, #6408:
URL: https://github.com/apache/iceberg/pull/6408
Was going through SparkValueReaders and saw some commented out code which
can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Fokko merged PR #6342:
URL: https://github.com/apache/iceberg/pull/6342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach
Fokko commented on code in PR #6342:
URL: https://github.com/apache/iceberg/pull/6342#discussion_r1045589430
##
python/pyiceberg/schema.py:
##
@@ -317,6 +331,97 @@ def primitive(self, primitive: PrimitiveType) -> T:
"""Visit a PrimitiveType"""
+class SchemaVisitorPe
Fokko merged PR #6409:
URL: https://github.com/apache/iceberg/pull/6409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach
Fokko commented on PR #6409:
URL: https://github.com/apache/iceberg/pull/6409#issuecomment-1346223849
Merging this to avoid others having a red CI because of the missing types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
gaborkaszab commented on code in PR #187:
URL: https://github.com/apache/iceberg-docs/pull/187#discussion_r1045663147
##
landing-page/content/common/how-to-release.md:
##
@@ -222,6 +246,12 @@ Therefore, the release candidate is passed/rejected.
After the release vote has pass
gaborkaszab commented on code in PR #6404:
URL: https://github.com/apache/iceberg/pull/6404#discussion_r1045678055
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -304,7 +306,9 @@ public Table loadTable(SessionContext context,
TableIdentifier identi
zinking commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1045716950
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkPartitioningAwareScan.java:
##
@@ -0,0 +1,244 @@
+/*
+ * Licensed to the Apache Software Foundati
nastra opened a new pull request, #6411:
URL: https://github.com/apache/iceberg/pull/6411
Previously, having an unpartitioned table would produce a `"partitions."`
entry in the snapshot summary when the partition summary limit was configured
--
This is an automated message from the Apache
InvisibleProgrammer commented on issue #6370:
URL: https://github.com/apache/iceberg/issues/6370#issuecomment-1346382736
@pvary I think it is not a simple yes or no question. We need some time to
better understand the topic and the consequences of the change.
--
This is an automated me
nastra commented on code in PR #6411:
URL: https://github.com/apache/iceberg/pull/6411#discussion_r1045769408
##
core/src/test/java/org/apache/iceberg/TestRowDelta.java:
##
@@ -896,17 +896,14 @@ public void testAddDeleteFilesMultipleSpecs() {
Map summary = snapshot.summary(
gaborkaszab commented on PR #5837:
URL: https://github.com/apache/iceberg/pull/5837#issuecomment-1346411031
Thanks again for the review, @nastra!
I believe I have addressed all of your previous comments. Another round of
review would be appreciated :)
--
This is an automated message fr
nastra commented on code in PR #6411:
URL: https://github.com/apache/iceberg/pull/6411#discussion_r1045770751
##
core/src/test/java/org/apache/iceberg/TestRowDelta.java:
##
@@ -896,17 +896,14 @@ public void testAddDeleteFilesMultipleSpecs() {
Map summary = snapshot.summary(
nastra commented on code in PR #6411:
URL: https://github.com/apache/iceberg/pull/6411#discussion_r1045769408
##
core/src/test/java/org/apache/iceberg/TestRowDelta.java:
##
@@ -896,17 +896,14 @@ public void testAddDeleteFilesMultipleSpecs() {
Map summary = snapshot.summary(
nastra commented on PR #5837:
URL: https://github.com/apache/iceberg/pull/5837#issuecomment-1346417834
thanks @gaborkaszab, will try and review it this week. You might also want
to include @rdblue or @danielcweeks for a review.
--
This is an automated message from the Apache Git Service.
chenjunjiedada commented on code in PR #6313:
URL: https://github.com/apache/iceberg/pull/6313#discussion_r1045778493
##
core/src/main/java/org/apache/iceberg/MetricsConfig.java:
##
@@ -107,6 +107,30 @@ public static MetricsConfig forPositionDelete(Table table)
{
return ne
RussellSpitzer commented on issue #6406:
URL: https://github.com/apache/iceberg/issues/6406#issuecomment-1346431638
Are you sure you are only checking the live manifest files for the table?
How do the metrics compare with those in the metadata view of the table?
--
This is an automated me
Fokko commented on issue #6397:
URL: https://github.com/apache/iceberg/issues/6397#issuecomment-1346447504
@rubenvdg `poetry shell` is not required, since the
[Makefile](https://github.com/apache/iceberg/blob/master/python/Makefile#L28-L32)
already executes the tests `poetry run`. I'm still
rubenvdg commented on issue #6397:
URL: https://github.com/apache/iceberg/issues/6397#issuecomment-1346538268
[@Fokko It seems that it only works on Python >= 3.9.8. There's some stuff
on Protocols in the release
notes](https://docs.python.org/release/3.9.8/whatsnew/changelog.html) that
mi
rubenvdg commented on issue #6397:
URL: https://github.com/apache/iceberg/issues/6397#issuecomment-1346543174
Both Docker containers fail btw with:
```
#11 21.80 FAILED
tests/io/test_pyarrow.py::test_raise_on_opening_a_local_file_no_permission
#11 21.80 FAILED
tests/io/test_pya
Fokko commented on issue #6397:
URL: https://github.com/apache/iceberg/issues/6397#issuecomment-1346548075
> It seems that it only works on Python >= 3.9.8. There's some bugfix on
Protocols in the [release
notes](https://docs.python.org/release/3.9.8/whatsnew/changelog.html) that
might rin
cccs-eric commented on code in PR #6392:
URL: https://github.com/apache/iceberg/pull/6392#discussion_r1045861171
##
python/tests/io/test_fsspec.py:
##
@@ -204,6 +204,191 @@ def test_writing_avro_file(generated_manifest_entry_file:
Generator[str, None, N
b2 = in_f.r
gaborkaszab commented on code in PR #6410:
URL: https://github.com/apache/iceberg/pull/6410#discussion_r1045784906
##
api/src/main/java/org/apache/iceberg/metrics/MetricsReporter.java:
##
@@ -18,10 +18,16 @@
*/
package org.apache.iceberg.metrics;
+import java.util.Map;
+
/
nastra commented on code in PR #6411:
URL: https://github.com/apache/iceberg/pull/6411#discussion_r1045878419
##
spark/v2.4/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java:
##
@@ -898,7 +898,7 @@ public void testSnapshotsTable() {
nastra commented on code in PR #6410:
URL: https://github.com/apache/iceberg/pull/6410#discussion_r1045745386
##
api/src/main/java/org/apache/iceberg/metrics/MetricsReporter.java:
##
@@ -18,10 +18,16 @@
*/
package org.apache.iceberg.metrics;
+import java.util.Map;
+
/** Th
hililiwei commented on code in PR #6377:
URL: https://github.com/apache/iceberg/pull/6377#discussion_r1045850345
##
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/DataGenerators.java:
##
@@ -0,0 +1,746 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
pvary commented on issue #6370:
URL: https://github.com/apache/iceberg/issues/6370#issuecomment-1346635105
@InvisibleProgrammer: Fair enough. If it would have been a simple question,
I might not have asked š
--
This is an automated message from the Apache Git Service.
To respond to the m
nastra commented on code in PR #6404:
URL: https://github.com/apache/iceberg/pull/6404#discussion_r1045939277
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -177,7 +177,9 @@ public void initialize(String name, Map
unresolved) {
this.io =
cccs-eric commented on code in PR #6392:
URL: https://github.com/apache/iceberg/pull/6392#discussion_r1045861171
##
python/tests/io/test_fsspec.py:
##
@@ -204,6 +204,191 @@ def test_writing_avro_file(generated_manifest_entry_file:
Generator[str, None, N
b2 = in_f.r
nastra commented on code in PR #6404:
URL: https://github.com/apache/iceberg/pull/6404#discussion_r1045949398
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -304,7 +306,9 @@ public Table loadTable(SessionContext context,
TableIdentifier identifier)
rubenvdg opened a new pull request, #6413:
URL: https://github.com/apache/iceberg/pull/6413
c.f. https://github.com/apache/iceberg/issues/6397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
nastra commented on code in PR #6411:
URL: https://github.com/apache/iceberg/pull/6411#discussion_r1045978833
##
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java:
##
@@ -953,9 +953,9 @@ public void testDeleteWithMultipleSpecs() {
nastra closed pull request #6404: Core: Allow configuring metrics reporter impl
via Catalog property
URL: https://github.com/apache/iceberg/pull/6404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nastra opened a new pull request, #6404:
URL: https://github.com/apache/iceberg/pull/6404
In certain cases it makes sense to make the used metrics reporter
customizable, so that users have more control over it and how it's reporting
--
This is an automated message from the Apache Git Serv
kmozaid commented on code in PR #6410:
URL: https://github.com/apache/iceberg/pull/6410#discussion_r1046006735
##
api/src/main/java/org/apache/iceberg/metrics/MetricsReporter.java:
##
@@ -18,10 +18,16 @@
*/
package org.apache.iceberg.metrics;
+import java.util.Map;
+
/** T
kmozaid commented on code in PR #6410:
URL: https://github.com/apache/iceberg/pull/6410#discussion_r1046008836
##
core/src/main/java/org/apache/iceberg/BaseTable.java:
##
@@ -63,6 +63,10 @@ public String name() {
return name;
}
+ public MetricsReporter reporter() {
R
kmozaid commented on code in PR #6410:
URL: https://github.com/apache/iceberg/pull/6410#discussion_r1046012714
##
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java:
##
@@ -198,6 +201,28 @@ public void testCreateTableTxnBuilder() throws Exception {
}
rdblue commented on code in PR #6404:
URL: https://github.com/apache/iceberg/pull/6404#discussion_r1046056595
##
api/src/main/java/org/apache/iceberg/metrics/LoggingMetricsReporter.java:
##
@@ -28,6 +28,11 @@
*/
public class LoggingMetricsReporter implements MetricsReporter {
rdblue commented on code in PR #6404:
URL: https://github.com/apache/iceberg/pull/6404#discussion_r1046057652
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -106,7 +106,7 @@ public class RESTSessionCatalog extends BaseSessionCatalog
private Resou
rdblue commented on code in PR #6404:
URL: https://github.com/apache/iceberg/pull/6404#discussion_r1046062940
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -316,7 +320,7 @@ private void reportMetrics(
TableIdentifier tableIdentifier,
rdblue commented on code in PR #6404:
URL: https://github.com/apache/iceberg/pull/6404#discussion_r1046068902
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -304,7 +306,9 @@ public Table loadTable(SessionContext context,
TableIdentifier identifier)
rdblue commented on code in PR #6404:
URL: https://github.com/apache/iceberg/pull/6404#discussion_r1046069256
##
api/src/main/java/org/apache/iceberg/metrics/LoggingMetricsReporter.java:
##
@@ -28,6 +28,11 @@
*/
public class LoggingMetricsReporter implements MetricsReporter {
rdblue commented on code in PR #6411:
URL: https://github.com/apache/iceberg/pull/6411#discussion_r1046073562
##
core/src/main/java/org/apache/iceberg/SnapshotSummary.java:
##
@@ -148,7 +148,7 @@ public void set(String property, String value) {
}
private void updateP
danielcweeks commented on code in PR #6352:
URL: https://github.com/apache/iceberg/pull/6352#discussion_r1046096643
##
aws/src/main/java/org/apache/iceberg/aws/s3/S3URI.java:
##
@@ -74,17 +74,14 @@ class S3URI {
this.scheme = schemeSplit[0];
String[] authoritySplit =
ajantha-bhat opened a new issue, #6414:
URL: https://github.com/apache/iceberg/issues/6414
### Feature Request / Improvement
very recently pyiceberg has added support for glue catalog (0.2.0).
We need to have support for Nessie catalog too just like hive, glue, REST
catalogs.
ajantha-bhat commented on issue #6414:
URL: https://github.com/apache/iceberg/issues/6414#issuecomment-1346881787
I will wait a week or two to see if anyone wants to pick it up. If not, I
will try to work on it.
--
This is an automated message from the Apache Git Service.
To respond to t
nastra commented on code in PR #6404:
URL: https://github.com/apache/iceberg/pull/6404#discussion_r1046130246
##
api/src/main/java/org/apache/iceberg/metrics/LoggingMetricsReporter.java:
##
@@ -28,6 +28,11 @@
*/
public class LoggingMetricsReporter implements MetricsReporter {
nastra commented on code in PR #6404:
URL: https://github.com/apache/iceberg/pull/6404#discussion_r1046134055
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -106,7 +106,7 @@ public class RESTSessionCatalog extends BaseSessionCatalog
private Resou
nastra commented on issue #6393:
URL: https://github.com/apache/iceberg/issues/6393#issuecomment-1346932126
@amogh-jahagirdar could you help out here please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
stevenzwu merged PR #6394:
URL: https://github.com/apache/iceberg/pull/6394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.a
stevenzwu commented on PR #6394:
URL: https://github.com/apache/iceberg/pull/6394#issuecomment-1346977801
thanks @hililiwei
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
ajantha-bhat commented on PR #6296:
URL: https://github.com/apache/iceberg/pull/6296#issuecomment-1346988722
ping @RussellSpitzer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
stevenzwu commented on code in PR #6407:
URL: https://github.com/apache/iceberg/pull/6407#discussion_r1046225363
##
core/src/main/java/org/apache/iceberg/SerializableTable.java:
##
@@ -357,6 +357,12 @@ public Transaction newTransaction() {
throw new UnsupportedOperationExce
asheeshgarg opened a new issue, #6415:
URL: https://github.com/apache/iceberg/issues/6415
### Apache Iceberg version
0.14.0
### Query engine
None
### Please describe the bug š
@nastra
I am using Vectorized read from Java API and able to load the data
stevenzwu commented on code in PR #6407:
URL: https://github.com/apache/iceberg/pull/6407#discussion_r1046275112
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/DataIterator.java:
##
@@ -68,6 +69,23 @@ public DataIterator(
this.recordOffset = 0L;
}
+
stevenzwu commented on code in PR #6407:
URL: https://github.com/apache/iceberg/pull/6407#discussion_r1046286159
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/FlinkSource.java:
##
@@ -220,7 +212,7 @@ public FlinkInputFormat buildFormat() {
readab
huaxingao commented on PR #6405:
URL: https://github.com/apache/iceberg/pull/6405#issuecomment-1347229885
@rdblue Thank you very much for the PR! I will get your code to my local and
work on integrating my changes into yours.
--
This is an automated message from the Apache Git Service.
To
szehon-ho commented on code in PR #6344:
URL: https://github.com/apache/iceberg/pull/6344#discussion_r1046346355
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/ChangelogIterator.java:
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
szehon-ho commented on code in PR #6344:
URL: https://github.com/apache/iceberg/pull/6344#discussion_r1046354676
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/ChangelogIterator.java:
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
szehon-ho commented on code in PR #6344:
URL: https://github.com/apache/iceberg/pull/6344#discussion_r1046360920
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/ChangelogIterator.java:
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
flyrain commented on code in PR #6344:
URL: https://github.com/apache/iceberg/pull/6344#discussion_r1046364398
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/ChangelogIterator.java:
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
szehon-ho commented on code in PR #6344:
URL: https://github.com/apache/iceberg/pull/6344#discussion_r1046360920
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/ChangelogIterator.java:
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
flyrain commented on code in PR #6344:
URL: https://github.com/apache/iceberg/pull/6344#discussion_r1046364398
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/ChangelogIterator.java:
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
stevenzwu commented on code in PR #6402:
URL: https://github.com/apache/iceberg/pull/6402#discussion_r1045171171
##
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkTableSource.java:
##
@@ -96,6 +97,7 @@ public void before() {
@After
public void cle
rdblue commented on PR #6267:
URL: https://github.com/apache/iceberg/pull/6267#issuecomment-1347376734
> I think we still need an interface to get the current stats file for
snapshot id currentStatisticsFiles()
No, I don't think this is valuable. This depends too much on some definiti
stevenzwu commented on code in PR #6377:
URL: https://github.com/apache/iceberg/pull/6377#discussion_r1046417674
##
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/DataGenerators.java:
##
@@ -0,0 +1,746 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
ajantha-bhat commented on PR #6267:
URL: https://github.com/apache/iceberg/pull/6267#issuecomment-1347529570
@rdblue: Thanks for the review and suggestions. I have kept it as just the
document (spec) update now.
--
This is an automated message from the Apache Git Service.
To respond to
szehon-ho commented on code in PR #6350:
URL: https://github.com/apache/iceberg/pull/6350#discussion_r1046518537
##
core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java:
##
@@ -149,8 +149,7 @@ public static Iterable ancestorsOf(long
snapshotId, Function
flyrain commented on code in PR #6350:
URL: https://github.com/apache/iceberg/pull/6350#discussion_r1046534226
##
core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java:
##
@@ -149,8 +149,7 @@ public static Iterable ancestorsOf(long
snapshotId, Function
flyrain commented on code in PR #6350:
URL: https://github.com/apache/iceberg/pull/6350#discussion_r1046534226
##
core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java:
##
@@ -149,8 +149,7 @@ public static Iterable ancestorsOf(long
snapshotId, Function
flyrain commented on code in PR #6350:
URL: https://github.com/apache/iceberg/pull/6350#discussion_r1046536345
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##
@@ -213,13 +214,26 @@ public Scan build() {
SparkReadOptions.END_SN
github-actions[bot] commented on issue #5043:
URL: https://github.com/apache/iceberg/issues/5043#issuecomment-1347558186
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #4900:
URL: https://github.com/apache/iceberg/issues/4900#issuecomment-1347558303
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
flyrain commented on code in PR #6350:
URL: https://github.com/apache/iceberg/pull/6350#discussion_r1046541174
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##
@@ -213,13 +214,26 @@ public Scan build() {
SparkReadOptions.END_SN
flyrain commented on code in PR #6350:
URL: https://github.com/apache/iceberg/pull/6350#discussion_r1046541628
##
core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java:
##
@@ -149,8 +149,7 @@ public static Iterable ancestorsOf(long
snapshotId, Function
flyrain commented on code in PR #6344:
URL: https://github.com/apache/iceberg/pull/6344#discussion_r1046549002
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/ChangelogIterator.java:
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
flyrain commented on code in PR #6344:
URL: https://github.com/apache/iceberg/pull/6344#discussion_r1046553676
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/ChangelogIterator.java:
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
flyrain commented on code in PR #6344:
URL: https://github.com/apache/iceberg/pull/6344#discussion_r1046555442
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/ChangelogIterator.java:
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
szehon-ho commented on code in PR #6344:
URL: https://github.com/apache/iceberg/pull/6344#discussion_r1046556419
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/ChangelogIterator.java:
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
szehon-ho commented on code in PR #6344:
URL: https://github.com/apache/iceberg/pull/6344#discussion_r1046557836
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/ChangelogIterator.java:
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
szehon-ho commented on code in PR #6344:
URL: https://github.com/apache/iceberg/pull/6344#discussion_r1046559017
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/ChangelogIterator.java:
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
flyrain commented on code in PR #6344:
URL: https://github.com/apache/iceberg/pull/6344#discussion_r1046560941
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/ChangelogIterator.java:
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
flyrain commented on code in PR #6344:
URL: https://github.com/apache/iceberg/pull/6344#discussion_r1046560941
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/ChangelogIterator.java:
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
flyrain commented on code in PR #6344:
URL: https://github.com/apache/iceberg/pull/6344#discussion_r1046562966
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/ChangelogIterator.java:
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
flyrain commented on code in PR #6344:
URL: https://github.com/apache/iceberg/pull/6344#discussion_r1046560941
##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/ChangelogIterator.java:
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
srilman commented on issue #3220:
URL: https://github.com/apache/iceberg/issues/3220#issuecomment-1347623323
FYI, I did start working on an initial implementation but ran into issues
with trying to use just FileIO to perform special operations needed for Hadoop
tables (I believe hadoop FS l
tomtongue commented on code in PR #6352:
URL: https://github.com/apache/iceberg/pull/6352#discussion_r1046599507
##
aws/src/main/java/org/apache/iceberg/aws/s3/S3URI.java:
##
@@ -74,17 +74,14 @@ class S3URI {
this.scheme = schemeSplit[0];
String[] authoritySplit = sc
chenjunjiedada commented on code in PR #6407:
URL: https://github.com/apache/iceberg/pull/6407#discussion_r1046600657
##
core/src/main/java/org/apache/iceberg/SerializableTable.java:
##
@@ -357,6 +357,12 @@ public Transaction newTransaction() {
throw new UnsupportedOperatio
chenjunjiedada commented on code in PR #6407:
URL: https://github.com/apache/iceberg/pull/6407#discussion_r1046600948
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/reader/RowDataReaderFunction.java:
##
@@ -18,53 +18,45 @@
*/
package org.apache.iceberg.fli
chenjunjiedada commented on code in PR #6407:
URL: https://github.com/apache/iceberg/pull/6407#discussion_r1046601114
##
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/source/reader/ReaderFunctionTestBase.java:
##
@@ -51,16 +55,28 @@ public static Object[][] parameters
chenjunjiedada commented on code in PR #6407:
URL: https://github.com/apache/iceberg/pull/6407#discussion_r1046602827
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/FlinkSource.java:
##
@@ -220,7 +212,7 @@ public FlinkInputFormat buildFormat() {
r
chenjunjiedada commented on code in PR #6407:
URL: https://github.com/apache/iceberg/pull/6407#discussion_r1046603540
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/RowDataRewriter.java:
##
@@ -77,20 +65,12 @@ public RowDataRewriter(
RowType flinkSchema
hililiwei commented on PR #6394:
URL: https://github.com/apache/iceberg/pull/6394#issuecomment-1347665691
thanks @stevenzwu for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
stevenzwu commented on code in PR #6407:
URL: https://github.com/apache/iceberg/pull/6407#discussion_r1046606070
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##
@@ -357,13 +358,10 @@ public IcebergSource build() {
if (readerFuncti
stevenzwu commented on code in PR #6313:
URL: https://github.com/apache/iceberg/pull/6313#discussion_r1046608479
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkAppenderFactory.java:
##
@@ -216,7 +241,8 @@ public EqualityDeleteWriter newEqDeleteWriter(
@
stevenzwu commented on code in PR #6313:
URL: https://github.com/apache/iceberg/pull/6313#discussion_r1046609770
##
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkAppenderFactory.java:
##
@@ -99,7 +122,8 @@ private RowType lazyPosDeleteFlinkSchema() {
@O
hililiwei commented on code in PR #6402:
URL: https://github.com/apache/iceberg/pull/6402#discussion_r1046618093
##
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkTableSource.java:
##
@@ -603,7 +605,103 @@ public void testFilterPushDown2Literal() {
}
kamaljit-1991 commented on issue #6122:
URL: https://github.com/apache/iceberg/issues/6122#issuecomment-1347696537
Hey @RussellSpitzer checking again. We are creating the table like this :
```
catalog.createTable(
TableIdentifier.of(database, table),
amogh-jahagirdar commented on code in PR #6405:
URL: https://github.com/apache/iceberg/pull/6405#discussion_r1046618283
##
api/src/main/java/org/apache/iceberg/expressions/CountStar.java:
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
1 - 100 of 111 matches
Mail list logo
