rdblue commented on code in PR #6404:
URL: https://github.com/apache/iceberg/pull/6404#discussion_r1046062940
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -316,7 +320,7 @@ private void reportMetrics(
TableIdentifier tableIdentifier,
MetricsReport report,
Supplier<Map<String, String>> headers) {
- reporter.report(report);
+ LoggingMetricsReporter.instance().report(report);
Review Comment:
I think that the logging metrics reporter should be replaced by the injected
metrics reporter. Either way, this method should be called. And I think we will
need to move the reporter call inside the try/catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
