nastra commented on code in PR #6404: URL: https://github.com/apache/iceberg/pull/6404#discussion_r1046134055
########## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ########## @@ -106,7 +106,7 @@ public class RESTSessionCatalog extends BaseSessionCatalog private ResourcePaths paths = null; private Object conf = null; private FileIO io = null; - private MetricsReporter reporter = null; + private MetricsReporter customMetricsReporter = null; Review Comment: I was confused for a sec when reading the code I wrote a while ago and thought why this wasn't called `customMetricsReporter` in the first place, hence the change. I can change it back if you think it's not worth renaming this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
