flyrain commented on code in PR #6350: URL: https://github.com/apache/iceberg/pull/6350#discussion_r1046534226
########## core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java: ########## @@ -149,8 +149,7 @@ public static Iterable<Snapshot> ancestorsOf(long snapshotId, Function<Long, Sna } /** - * Traverses the history of the table's current snapshot and finds the first snapshot committed - * after the given time. + * Finds the oldest snapshot that was committed either at or after a given time. Review Comment: The first part of the comment is confusing, it should be at least something like this. ``` Traverses the table's snapshot history ``` Moreover, I think it is not necessary to mention that. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
