Re: [PR] Url encode field names for partition paths [iceberg]

2024-05-27 Thread via GitHub
danielcweeks merged PR #10329: URL: https://github.com/apache/iceberg/pull/10329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceb

Re: [PR] Url encode field names for partition paths [iceberg]

2024-05-27 Thread via GitHub
danielcweeks commented on code in PR #10329: URL: https://github.com/apache/iceberg/pull/10329#discussion_r1616406486 ## core/src/test/java/org/apache/iceberg/TestLocationProvider.java: ## @@ -285,4 +286,22 @@ public void testObjectStorageWithinTableLocation() { assertThat(

Re: [PR] Url encode field names for partition paths [iceberg]

2024-05-16 Thread via GitHub
dimas-b commented on code in PR #10329: URL: https://github.com/apache/iceberg/pull/10329#discussion_r1603601992 ## api/src/main/java/org/apache/iceberg/PartitionSpec.java: ## @@ -189,7 +189,7 @@ public String partitionToPath(StructLike data) { if (i > 0) { sb.ap

Re: [PR] Url encode field names for partition paths [iceberg]

2024-05-15 Thread via GitHub
danielcweeks commented on code in PR #10329: URL: https://github.com/apache/iceberg/pull/10329#discussion_r1602150488 ## core/src/test/java/org/apache/iceberg/TestLocationProvider.java: ## @@ -285,4 +286,22 @@ public void testObjectStorageWithinTableLocation() { assertThat(

Re: [PR] Url encode field names for partition paths [iceberg]

2024-05-15 Thread via GitHub
dimas-b commented on code in PR #10329: URL: https://github.com/apache/iceberg/pull/10329#discussion_r1602092875 ## api/src/main/java/org/apache/iceberg/PartitionSpec.java: ## @@ -189,7 +189,7 @@ public String partitionToPath(StructLike data) { if (i > 0) { sb.ap

Re: [PR] Url encode field names for partition paths [iceberg]

2024-05-15 Thread via GitHub
dimas-b commented on code in PR #10329: URL: https://github.com/apache/iceberg/pull/10329#discussion_r1602074394 ## api/src/main/java/org/apache/iceberg/PartitionSpec.java: ## @@ -189,7 +189,7 @@ public String partitionToPath(StructLike data) { if (i > 0) { sb.ap

Re: [PR] Url encode field names for partition paths [iceberg]

2024-05-13 Thread via GitHub
nastra commented on code in PR #10329: URL: https://github.com/apache/iceberg/pull/10329#discussion_r1599476388 ## core/src/test/java/org/apache/iceberg/TestLocationProvider.java: ## @@ -285,4 +286,22 @@ public void testObjectStorageWithinTableLocation() { assertThat(parts)

Re: [PR] Url encode field names for partition paths [iceberg]

2024-05-13 Thread via GitHub
dimas-b commented on code in PR #10329: URL: https://github.com/apache/iceberg/pull/10329#discussion_r1599215769 ## core/src/test/java/org/apache/iceberg/TestLocationProvider.java: ## @@ -285,4 +286,22 @@ public void testObjectStorageWithinTableLocation() { assertThat(parts

Re: [PR] Url encode field names for partition paths [iceberg]

2024-05-13 Thread via GitHub
dimas-b commented on code in PR #10329: URL: https://github.com/apache/iceberg/pull/10329#discussion_r1599208577 ## core/src/test/java/org/apache/iceberg/TestLocationProvider.java: ## @@ -285,4 +286,22 @@ public void testObjectStorageWithinTableLocation() { assertThat(parts

Re: [PR] Url encode field names for partition paths [iceberg]

2024-05-13 Thread via GitHub
dimas-b commented on code in PR #10329: URL: https://github.com/apache/iceberg/pull/10329#discussion_r1599208577 ## core/src/test/java/org/apache/iceberg/TestLocationProvider.java: ## @@ -285,4 +286,22 @@ public void testObjectStorageWithinTableLocation() { assertThat(parts

Re: [PR] Url encode field names for partition paths [iceberg]

2024-05-13 Thread via GitHub
dimas-b commented on code in PR #10329: URL: https://github.com/apache/iceberg/pull/10329#discussion_r1599203081 ## api/src/main/java/org/apache/iceberg/PartitionSpec.java: ## @@ -189,7 +189,7 @@ public String partitionToPath(StructLike data) { if (i > 0) { sb.ap

Re: [PR] Url encode field names for partition paths [iceberg]

2024-05-13 Thread via GitHub
danielcweeks commented on code in PR #10329: URL: https://github.com/apache/iceberg/pull/10329#discussion_r1599193529 ## core/src/test/java/org/apache/iceberg/TestLocationProvider.java: ## @@ -285,4 +286,22 @@ public void testObjectStorageWithinTableLocation() { assertThat(

Re: [PR] Url encode field names for partition paths [iceberg]

2024-05-13 Thread via GitHub
danielcweeks commented on code in PR #10329: URL: https://github.com/apache/iceberg/pull/10329#discussion_r1599193529 ## core/src/test/java/org/apache/iceberg/TestLocationProvider.java: ## @@ -285,4 +286,22 @@ public void testObjectStorageWithinTableLocation() { assertThat(

Re: [PR] Url encode field names for partition paths [iceberg]

2024-05-13 Thread via GitHub
amogh-jahagirdar commented on code in PR #10329: URL: https://github.com/apache/iceberg/pull/10329#discussion_r1599127317 ## core/src/test/java/org/apache/iceberg/TestLocationProvider.java: ## @@ -285,4 +286,22 @@ public void testObjectStorageWithinTableLocation() { assertT