dimas-b commented on code in PR #10329:
URL: https://github.com/apache/iceberg/pull/10329#discussion_r1603601992
##########
api/src/main/java/org/apache/iceberg/PartitionSpec.java:
##########
@@ -189,7 +189,7 @@ public String partitionToPath(StructLike data) {
if (i > 0) {
sb.append("/");
}
- sb.append(field.name()).append("=").append(escape(valueString));
+ sb.append(escape(field.name())).append("=").append(escape(valueString));
Review Comment:
The `%20` could be part of the column name (or value) as in my example in
#10279, so decoding the original string may not be applicable to all cases.
```
create table test.ns.t9(`id%20` string not null, a int) partitioned by
(`id%20`);
```
... but I did not test that particular name in practice :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
