danielcweeks commented on code in PR #10329:
URL: https://github.com/apache/iceberg/pull/10329#discussion_r1616406486
##########
core/src/test/java/org/apache/iceberg/TestLocationProvider.java:
##########
@@ -285,4 +286,22 @@ public void testObjectStorageWithinTableLocation() {
assertThat(parts).element(2).asString().isNotEmpty();
assertThat(parts).element(3).asString().isEqualTo("test.parquet");
}
+
+ @TestTemplate
+ public void testEncodedFieldNameInPartitionPath() {
+ // Update the table to use a string field for partitioning with special
characters in the name
+ table.updateProperties().set(TableProperties.OBJECT_STORE_ENABLED,
"true").commit();
+ table.updateSchema().addColumn("data#1", Types.StringType.get()).commit();
+ table.updateSpec().addField("data#1").commit();
Review Comment:
For now, we'll just make this consistent with what we're doing for the
values. I agree we should probably up-level this discussion and figure out a
path forward that is more usable with other URI parsing utilities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
