Re: [PR] Spark 3.5: Fix incorrect catalog loaded in TestCreateActions [iceberg]

2024-08-22 Thread via GitHub
nastra merged PR #10952: URL: https://github.com/apache/iceberg/pull/10952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Spark 3.5: Fix incorrect catalog loaded in TestCreateActions [iceberg]

2024-08-22 Thread via GitHub
nastra commented on PR #10952: URL: https://github.com/apache/iceberg/pull/10952#issuecomment-2304744807 thanks for fixing this @manuzhang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Spark 3.5: Fix incorrect catalog loaded in TestCreateActions [iceberg]

2024-08-22 Thread via GitHub
nastra commented on code in PR #10952: URL: https://github.com/apache/iceberg/pull/10952#discussion_r1726990942 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -162,6 +162,9 @@ public void before() { this.tableLocation = tabl

Re: [PR] Spark 3.5: Fix incorrect catalog loaded in TestCreateActions [iceberg]

2024-08-22 Thread via GitHub
nastra commented on code in PR #10952: URL: https://github.com/apache/iceberg/pull/10952#discussion_r1726989251 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -186,6 +189,12 @@ public void before() { public void after() throws

Re: [PR] Spark 3.5: Fix incorrect catalog loaded in TestCreateActions [iceberg]

2024-08-22 Thread via GitHub
nastra commented on code in PR #10952: URL: https://github.com/apache/iceberg/pull/10952#discussion_r1726988968 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -162,6 +162,9 @@ public void before() { this.tableLocation = tabl

Re: [PR] Spark 3.5: Fix incorrect catalog loaded in TestCreateActions [iceberg]

2024-08-22 Thread via GitHub
manuzhang commented on code in PR #10952: URL: https://github.com/apache/iceberg/pull/10952#discussion_r1726746358 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -162,6 +162,9 @@ public void before() { this.tableLocation = t

Re: [PR] Spark 3.5: Fix incorrect catalog loaded in TestCreateActions [iceberg]

2024-08-22 Thread via GitHub
manuzhang commented on code in PR #10952: URL: https://github.com/apache/iceberg/pull/10952#discussion_r1726746358 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -162,6 +162,9 @@ public void before() { this.tableLocation = t

Re: [PR] Spark 3.5: Fix incorrect catalog loaded in TestCreateActions [iceberg]

2024-08-22 Thread via GitHub
nastra commented on code in PR #10952: URL: https://github.com/apache/iceberg/pull/10952#discussion_r1726607136 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -162,6 +162,9 @@ public void before() { this.tableLocation = tabl

Re: [PR] Spark 3.5: Fix incorrect catalog loaded in TestCreateActions [iceberg]

2024-08-22 Thread via GitHub
nastra commented on code in PR #10952: URL: https://github.com/apache/iceberg/pull/10952#discussion_r1726477211 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -186,6 +186,8 @@ public void before() { public void after() throws

Re: [PR] Spark 3.5: Fix incorrect catalog loaded in TestCreateActions [iceberg]

2024-08-21 Thread via GitHub
manuzhang commented on code in PR #10952: URL: https://github.com/apache/iceberg/pull/10952#discussion_r1725425409 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -186,6 +186,8 @@ public void before() { public void after() thro

Re: [PR] Spark 3.5: Fix incorrect catalog loaded in TestCreateActions [iceberg]

2024-08-21 Thread via GitHub
manuzhang commented on code in PR #10952: URL: https://github.com/apache/iceberg/pull/10952#discussion_r1725421349 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -186,6 +186,8 @@ public void before() { public void after() thro

Re: [PR] Spark 3.5: Fix incorrect catalog loaded in TestCreateActions [iceberg]

2024-08-21 Thread via GitHub
nastra commented on code in PR #10952: URL: https://github.com/apache/iceberg/pull/10952#discussion_r1725381138 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -186,6 +186,8 @@ public void before() { public void after() throws

Re: [PR] Spark 3.5: Fix incorrect catalog loaded in TestCreateActions [iceberg]

2024-08-21 Thread via GitHub
manuzhang commented on code in PR #10952: URL: https://github.com/apache/iceberg/pull/10952#discussion_r1725370100 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -186,6 +186,8 @@ public void before() { public void after() thro

Re: [PR] Spark 3.5: Fix incorrect catalog loaded in TestCreateActions [iceberg]

2024-08-20 Thread via GitHub
nastra commented on code in PR #10952: URL: https://github.com/apache/iceberg/pull/10952#discussion_r1723442916 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -186,6 +186,8 @@ public void before() { public void after() throws

Re: [PR] Spark 3.5: Fix incorrect catalog loaded in TestCreateActions [iceberg]

2024-08-19 Thread via GitHub
manuzhang commented on code in PR #10952: URL: https://github.com/apache/iceberg/pull/10952#discussion_r1722688458 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -186,6 +186,8 @@ public void before() { public void after() thro

Re: [PR] Spark 3.5: Fix incorrect catalog loaded in TestCreateActions [iceberg]

2024-08-19 Thread via GitHub
nastra commented on code in PR #10952: URL: https://github.com/apache/iceberg/pull/10952#discussion_r1721900991 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -186,6 +186,8 @@ public void before() { public void after() throws

Re: [PR] Spark 3.5: Fix incorrect catalog loaded in TestCreateActions [iceberg]

2024-08-19 Thread via GitHub
nastra commented on code in PR #10952: URL: https://github.com/apache/iceberg/pull/10952#discussion_r1721898547 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -186,6 +186,8 @@ public void before() { public void after() throws