nastra commented on code in PR #10952:
URL: https://github.com/apache/iceberg/pull/10952#discussion_r1726988968


##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java:
##########
@@ -162,6 +162,9 @@ public void before() {
     this.tableLocation = tableDir.toURI().toString();
     this.catalog = (TableCatalog) 
spark.sessionState().catalogManager().catalog(catalogName);
 
+    if (!catalogName.equals("spark_catalog")) {
+      spark.conf().set("spark.sql.catalog.spark_catalog", 
SparkSessionCatalog.class.getName());

Review Comment:
   sorry, this is probably my bad due to my earlier suggestion. I think we can 
remove setting this here if we remove 
`spark.conf().unset("spark.sql.catalog.spark_catalog");`. That way all tests 
should still pass



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to