manuzhang commented on code in PR #10952:
URL: https://github.com/apache/iceberg/pull/10952#discussion_r1725425409
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java:
##########
@@ -186,6 +186,8 @@ public void before() {
public void after() throws IOException {
// Drop the hive table.
spark.sql(String.format("DROP TABLE IF EXISTS %s", baseTableName));
+ catalogConfig.forEach(
Review Comment:
Putting it at a central place could prevent future tests from running into
this issue. I'm hitting this because we implemented a customized `type` of
`SparkSessionCatalog` internally and added it wherever `SparkSessionCatalog` is
configured.
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java:
##########
@@ -186,6 +186,8 @@ public void before() {
public void after() throws IOException {
// Drop the hive table.
spark.sql(String.format("DROP TABLE IF EXISTS %s", baseTableName));
+ catalogConfig.forEach(
Review Comment:
Putting it at a central place could prevent future tests from running into
this issue. I'm hitting this because we implemented a customized `type` of
`SparkSessionCatalog` internally and added it wherever `SparkSessionCatalog` is
tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
