nastra commented on code in PR #10952: URL: https://github.com/apache/iceberg/pull/10952#discussion_r1726477211
########## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ########## @@ -186,6 +186,8 @@ public void before() { public void after() throws IOException { // Drop the hive table. spark.sql(String.format("DROP TABLE IF EXISTS %s", baseTableName)); + catalogConfig.forEach( Review Comment: I see that other tests are resetting this via ``` @AfterEach public void resetSparkSessionCatalog() throws Exception { spark.conf().unset("spark.sql.catalog.spark_catalog"); spark.conf().unset("spark.sql.catalog.spark_catalog.type"); spark.conf().unset("spark.sql.catalog.spark_catalog.warehouse"); } ``` Maybe it would be good to do the same here, where the explicit `spark_catalog` is used? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org