Re: [PR] Spark: Support altering views [iceberg]

nastra commented on code in PR #9510: URL: https://github.com/apache/iceberg/pull/9510#discussion_r1469766873 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -60,17 +63,23 @@ case class RewriteViewCommands(spa

Re: [PR] Spark: Support altering views [iceberg]

nastra commented on code in PR #9510: URL: https://github.com/apache/iceberg/pull/9510#discussion_r1469684751 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckViews.scala: ## @@ -36,6 +38,9 @@ object CheckViews extends (LogicalPlan => Uni

Re: [PR] Spark: Support altering views [iceberg]

nastra commented on PR #9510: URL: https://github.com/apache/iceberg/pull/9510#issuecomment-1914349245 @rdblue I have extracted setting/unsetting view properties into https://github.com/apache/iceberg/pull/9582 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Spark: Support altering views [iceberg]

nastra commented on code in PR #9510: URL: https://github.com/apache/iceberg/pull/9510#discussion_r1469223182 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -123,4 +132,17 @@ case class RewriteViewCommands(sp

Re: [PR] Spark: Support altering views [iceberg]

nastra commented on code in PR #9510: URL: https://github.com/apache/iceberg/pull/9510#discussion_r1469223182 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -123,4 +132,17 @@ case class RewriteViewCommands(sp

Re: [PR] Spark: Support altering views [iceberg]

rdblue commented on code in PR #9510: URL: https://github.com/apache/iceberg/pull/9510#discussion_r1468937534 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ExtendedDataSourceV2Strategy.scala: ## @@ -123,6 +127,35 @@ case class Extend

Re: [PR] Spark: Support altering views [iceberg]

rdblue commented on code in PR #9510: URL: https://github.com/apache/iceberg/pull/9510#discussion_r1468937382 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/views/ResolvedV2View.scala: ## @@ -22,10 +22,12 @@ package org.apache.spark.sql

Re: [PR] Spark: Support altering views [iceberg]

rdblue commented on code in PR #9510: URL: https://github.com/apache/iceberg/pull/9510#discussion_r1468936985 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ExtendedDataSourceV2Strategy.scala: ## @@ -123,6 +127,35 @@ case class Extend

Re: [PR] Spark: Support altering views [iceberg]

rdblue commented on code in PR #9510: URL: https://github.com/apache/iceberg/pull/9510#discussion_r1468936762 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -60,17 +63,23 @@ case class RewriteViewCommands(spa

Re: [PR] Spark: Support altering views [iceberg]

rdblue commented on code in PR #9510: URL: https://github.com/apache/iceberg/pull/9510#discussion_r1468935466 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -123,4 +132,17 @@ case class RewriteViewCommands(sp

Re: [PR] Spark: Support altering views [iceberg]

rdblue commented on code in PR #9510: URL: https://github.com/apache/iceberg/pull/9510#discussion_r1468935203 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ## @@ -123,4 +132,17 @@ case class RewriteViewCommands(sp

Re: [PR] Spark: Support altering views [iceberg]

rdblue commented on code in PR #9510: URL: https://github.com/apache/iceberg/pull/9510#discussion_r1468933314 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckViews.scala: ## @@ -36,6 +38,9 @@ object CheckViews extends (LogicalPlan => Uni

Re: [PR] Spark: Support altering views [iceberg]

rdblue commented on code in PR #9510: URL: https://github.com/apache/iceberg/pull/9510#discussion_r1468933314 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckViews.scala: ## @@ -36,6 +38,9 @@ object CheckViews extends (LogicalPlan => Uni

Re: [PR] Spark: Support altering views [iceberg]

nastra commented on code in PR #9510: URL: https://github.com/apache/iceberg/pull/9510#discussion_r1467933159 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -1149,10 +1148,343 @@ public void createViewWithSubqueryExpressio

Re: [PR] Spark: Support altering views [iceberg]

nastra commented on code in PR #9510: URL: https://github.com/apache/iceberg/pull/9510#discussion_r1467925434 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -1149,10 +1148,343 @@ public void createViewWithSubqueryExpressio

Re: [PR] Spark: Support altering views [iceberg]

nastra commented on code in PR #9510: URL: https://github.com/apache/iceberg/pull/9510#discussion_r1467911970 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -87,15 +86,6 @@ case class ResolveViews(spark: SparkSessio

Re: [PR] Spark: Support altering views [iceberg]

nastra commented on code in PR #9510: URL: https://github.com/apache/iceberg/pull/9510#discussion_r1467911499 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckViews.scala: ## @@ -36,6 +38,9 @@ object CheckViews extends (LogicalPlan => Uni