rdblue commented on code in PR #9510:
URL: https://github.com/apache/iceberg/pull/9510#discussion_r1468935203
##########
spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala:
##########
@@ -123,4 +132,17 @@ case class RewriteViewCommands(spark: SparkSession)
extends Rule[LogicalPlan] wi
collectTempViews(child)
}
+
+ private object IsIcebergView {
Review Comment:
The `Is` for this name doesn't make sense because it doesn't produce a
boolean. It produces a loaded v2 view. I don't even think that the v2 view
needs to be an Iceberg view.
I think this should probably be renamed to `ResolvedView` and the other
should be named `ResolvedIdentifier` or something. I also don't like the
duplication across these two helpers. It seems like this is doing what the
other rule does, but should instead be delegating to other rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
