nastra commented on code in PR #9510:
URL: https://github.com/apache/iceberg/pull/9510#discussion_r1469766873
##########
spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala:
##########
@@ -60,17 +63,23 @@ case class RewriteViewCommands(spark: SparkSession) extends
Rule[LogicalPlan] wi
properties = properties,
allowExisting = allowExisting,
replace = replace)
+
+ case a@AlterViewAs(ResolvedV2View(_, ident, _), _, query) =>
Review Comment:
if we want to go this route, then we'd also need to add the same handling
for `SetViewProperties(UnresolvedView(...))` /
`UnsetViewProperties(UnresolvedView(...))`, hence it seemed better to me to
just handle `case u@UnresolvedView(ResolvedView(resolved), _, _, _)` separately.
I'm fine either way, so let me know if you'd still like me to switch to the
approach you proposed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
