nastra commented on code in PR #9510:
URL: https://github.com/apache/iceberg/pull/9510#discussion_r1469223182
##########
spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala:
##########
@@ -123,4 +132,17 @@ case class RewriteViewCommands(spark: SparkSession)
extends Rule[LogicalPlan] wi
collectTempViews(child)
}
+
+ private object IsIcebergView {
Review Comment:
I like those new names better. I've updated the existing one to
`ResolvedIdent` as otherwise it clashes with the existing `ResolvedIdentifier`.
Unfortunately both `unapply` methods can't be combined
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
