Re: [PR] Spark: Deprecate SparkAppenderFactory [iceberg]

2024-09-26 Thread via GitHub
aokolnychyi commented on PR #11076: URL: https://github.com/apache/iceberg/pull/11076#issuecomment-2378384646 Thanks, @ajantha-bhat! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Spark: Deprecate SparkAppenderFactory [iceberg]

2024-09-26 Thread via GitHub
aokolnychyi merged PR #11076: URL: https://github.com/apache/iceberg/pull/11076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] Spark: Deprecate SparkAppenderFactory [iceberg]

2024-09-05 Thread via GitHub
ajantha-bhat commented on PR #11076: URL: https://github.com/apache/iceberg/pull/11076#issuecomment-2332990957 @amoghjaha-db: > Since the class is package private do we want to just remove it upfront I did get this thought initially and checked how we handled previously for

Re: [PR] Spark: Deprecate SparkAppenderFactory [iceberg]

2024-09-04 Thread via GitHub
ajantha-bhat commented on code in PR #11076: URL: https://github.com/apache/iceberg/pull/11076#discussion_r1743221318 ## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkAppenderFactory.java: ## @@ -48,6 +48,10 @@ import org.apache.spark.sql.types.StructType;

Re: [PR] Spark: Deprecate SparkAppenderFactory [iceberg]

2024-09-03 Thread via GitHub
ajantha-bhat commented on code in PR #11076: URL: https://github.com/apache/iceberg/pull/11076#discussion_r1742886689 ## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkAppenderFactory.java: ## @@ -48,6 +48,10 @@ import org.apache.spark.sql.types.StructType;