ajantha-bhat commented on code in PR #11076:
URL: https://github.com/apache/iceberg/pull/11076#discussion_r1743221318


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkAppenderFactory.java:
##########
@@ -48,6 +48,10 @@
 import org.apache.spark.sql.types.StructType;
 import org.apache.spark.unsafe.types.UTF8String;
 
+/**
+ * @deprecated since 1.7.0, will be removed in 1.8.0; use {@link 
SparkFileWriterFactory} instead.
+ */
+@Deprecated
 class SparkAppenderFactory implements FileAppenderFactory<InternalRow> {

Review Comment:
   Also, this class is not used by the Spark engine integration. Hence, we can 
safely remove it. 
   
   Looking more into it, we might have lost metrics related function in 
`FileWriterFactory` that was present in `AppenderFactory`. Maybe I can work on 
it in the future for `FileWriterFactory`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to