ajantha-bhat commented on PR #11076:
URL: https://github.com/apache/iceberg/pull/11076#issuecomment-2332990957
@amoghjaha-db:
> Since the class is package private do we want to just remove it upfront
I did get this thought initially and checked how we handled previously for
other classes in this module. The package private classes like `SparkFileScan`
was deprecated first and then removed. So, I went ahead and followed the same.
<img width="1507" alt="Screenshot 2024-09-03 at 5 45 44 PM"
src="https://github.com/user-attachments/assets/77ee43f4-aa7c-4d7e-b40e-9296ff21443f";>
> It looks like it's currently used in some JMH benchmarks WritersBenchmark,
and TestSparkMergingMetrics would need to be updated to test the
SparkFileWriterFactory class instead.
As I mentioned in one of the
[comments](https://github.com/apache/iceberg/pull/11076#discussion_r1742886689),
`SparkFileWriterFactory` doesn't have metrics related function. So, we cannot
update the test to use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
