ajantha-bhat commented on code in PR #11076:
URL: https://github.com/apache/iceberg/pull/11076#discussion_r1742886689


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkAppenderFactory.java:
##########
@@ -48,6 +48,10 @@
 import org.apache.spark.sql.types.StructType;
 import org.apache.spark.unsafe.types.UTF8String;
 
+/**
+ * @deprecated since 1.7.0, will be removed in 1.8.0; use {@link 
SparkFileWriterFactory} instead.
+ */
+@Deprecated
 class SparkAppenderFactory implements FileAppenderFactory<InternalRow> {

Review Comment:
   While working on partition stats, I came across `FileWriterFactory` and 
`AppenderFactory`. After digging a bit, found that Spark was using 
`AppenderFactory` before but now uses `FileWriterFactory`.  But the 
implementation of `AppenderFactory` still exist and confusing for users. Hence, 
deprecating it before removal in the next version. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to