Fokko merged PR #476:
URL: https://github.com/apache/iceberg-python/pull/476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko commented on code in PR #476:
URL: https://github.com/apache/iceberg-python/pull/476#discussion_r1507407503
##
pyiceberg/table/sorting.py:
##
@@ -189,4 +191,4 @@ def assign_fresh_sort_order_ids(sort_order: SortOrder,
old_schema: Schema, fresh
)
)
-
Fokko commented on code in PR #476:
URL: https://github.com/apache/iceberg-python/pull/476#discussion_r1507390872
##
pyiceberg/table/sorting.py:
##
@@ -168,7 +168,9 @@ def __repr__(self) -> str:
UNSORTED_SORT_ORDER = SortOrder(order_id=UNSORTED_SORT_ORDER_ID)
-def assign_fr
anupam-saini commented on PR #476:
URL: https://github.com/apache/iceberg-python/pull/476#issuecomment-1966488776
> Thanks for working on this, can you check the tests and CI? `make install
&& make lint`
My bad, missed it this time.
--
This is an automated message from the Apache G
anupam-saini commented on code in PR #476:
URL: https://github.com/apache/iceberg-python/pull/476#discussion_r1504170134
##
pyiceberg/table/metadata.py:
##
@@ -226,6 +226,10 @@ def schema_by_id(self, schema_id: int) -> Optional[Schema]:
"""Get the schema by schema_id.""
Fokko commented on code in PR #476:
URL: https://github.com/apache/iceberg-python/pull/476#discussion_r1503784888
##
pyiceberg/table/metadata.py:
##
@@ -226,6 +226,10 @@ def schema_by_id(self, schema_id: int) -> Optional[Schema]:
"""Get the schema by schema_id."""
