Fokko commented on code in PR #476:
URL: https://github.com/apache/iceberg-python/pull/476#discussion_r1507407503
##########
pyiceberg/table/sorting.py:
##########
@@ -189,4 +191,4 @@ def assign_fresh_sort_order_ids(sort_order: SortOrder,
old_schema: Schema, fresh
)
)
- return SortOrder(*fresh_fields, order_id=INITIAL_SORT_ORDER_ID)
+ return SortOrder(*fresh_fields, order_id=sort_order_id if sort_order_id is
not None else INITIAL_SORT_ORDER_ID)
Review Comment:
```suggestion
return SortOrder(*fresh_fields, order_id=sort_order_id)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
