Fokko commented on code in PR #476:
URL: https://github.com/apache/iceberg-python/pull/476#discussion_r1507390872
##########
pyiceberg/table/sorting.py:
##########
@@ -168,7 +168,9 @@ def __repr__(self) -> str:
UNSORTED_SORT_ORDER = SortOrder(order_id=UNSORTED_SORT_ORDER_ID)
-def assign_fresh_sort_order_ids(sort_order: SortOrder, old_schema: Schema,
fresh_schema: Schema) -> SortOrder:
+def assign_fresh_sort_order_ids(
+ sort_order: SortOrder, old_schema: Schema, fresh_schema: Schema,
sort_order_id: Optional[int] = None
Review Comment:
This will avoid the inline if below:
```suggestion
sort_order: SortOrder, old_schema: Schema, fresh_schema: Schema,
sort_order_id: int = INITIAL_SORT_ORDER_ID
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
