Fokko commented on code in PR #476:
URL: https://github.com/apache/iceberg-python/pull/476#discussion_r1503784888


##########
pyiceberg/table/metadata.py:
##########
@@ -226,6 +226,10 @@ def schema_by_id(self, schema_id: int) -> Optional[Schema]:
         """Get the schema by schema_id."""
         return next((schema for schema in self.schemas if schema.schema_id == 
schema_id), None)
 
+    def sort_order_by_id(self, sort_order_id: int) -> Optional[Schema]:

Review Comment:
   ```suggestion
       def sort_order_by_id(self, sort_order_id: int) -> Optional[SortOrder]:
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to