Re: [PR] Parquet: Add system config for unsafe Parquet ID fallback. [iceberg]

2024-01-22 Thread via GitHub
rdblue commented on code in PR #9324: URL: https://github.com/apache/iceberg/pull/9324#discussion_r1462220664 ## parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java: ## @@ -1119,27 +1120,29 @@ public CloseableIterable build() { ParquetReadOptions options =

Re: [PR] Parquet: Add system config for unsafe Parquet ID fallback. [iceberg]

2024-01-22 Thread via GitHub
rdblue merged PR #9324: URL: https://github.com/apache/iceberg/pull/9324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Parquet: Add system config for unsafe Parquet ID fallback. [iceberg]

2024-01-22 Thread via GitHub
rdblue commented on PR #9324: URL: https://github.com/apache/iceberg/pull/9324#issuecomment-1904527162 Merged. Thanks for reviewing, @aokolnychyi and @Fokko! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Parquet: Add system config for unsafe Parquet ID fallback. [iceberg]

2024-01-22 Thread via GitHub
rdblue commented on code in PR #9324: URL: https://github.com/apache/iceberg/pull/9324#discussion_r1462131129 ## core/src/main/java/org/apache/iceberg/SystemConfigs.java: ## @@ -72,6 +72,19 @@ private SystemConfigs() {} 8, Integer::parseUnsignedInt); + /

Re: [PR] Parquet: Add system config for unsafe Parquet ID fallback. [iceberg]

2024-01-18 Thread via GitHub
aokolnychyi commented on code in PR #9324: URL: https://github.com/apache/iceberg/pull/9324#discussion_r1457974224 ## core/src/main/java/org/apache/iceberg/SystemConfigs.java: ## @@ -72,6 +72,19 @@ private SystemConfigs() {} 8, Integer::parseUnsignedInt);

Re: [PR] Parquet: Add system config for unsafe Parquet ID fallback. [iceberg]

2024-01-18 Thread via GitHub
aokolnychyi commented on code in PR #9324: URL: https://github.com/apache/iceberg/pull/9324#discussion_r1457974224 ## core/src/main/java/org/apache/iceberg/SystemConfigs.java: ## @@ -72,6 +72,19 @@ private SystemConfigs() {} 8, Integer::parseUnsignedInt);

Re: [PR] Parquet: Add system config for unsafe Parquet ID fallback. [iceberg]

2024-01-18 Thread via GitHub
aokolnychyi commented on code in PR #9324: URL: https://github.com/apache/iceberg/pull/9324#discussion_r1457972686 ## parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java: ## @@ -1119,27 +1120,29 @@ public CloseableIterable build() { ParquetReadOptions optio

Re: [PR] Parquet: Add system config for unsafe Parquet ID fallback. [iceberg]

2024-01-14 Thread via GitHub
rdblue commented on PR #9324: URL: https://github.com/apache/iceberg/pull/9324#issuecomment-1891081451 @jackye1995, @danielcweeks, @RussellSpitzer, could you look at this? I'd like to ideally get it into the next release since we have been allowing unsafe reads. -- This is an automated m

Re: [PR] Parquet: Add system config for unsafe Parquet ID fallback. [iceberg]

2023-12-18 Thread via GitHub
rdblue commented on code in PR #9324: URL: https://github.com/apache/iceberg/pull/9324#discussion_r1430731106 ## core/src/main/java/org/apache/iceberg/SystemConfigs.java: ## @@ -72,6 +72,19 @@ private SystemConfigs() {} 8, Integer::parseUnsignedInt); + /

Re: [PR] Parquet: Add system config for unsafe Parquet ID fallback. [iceberg]

2023-12-18 Thread via GitHub
amogh-jahagirdar commented on code in PR #9324: URL: https://github.com/apache/iceberg/pull/9324#discussion_r1430236452 ## core/src/main/java/org/apache/iceberg/SystemConfigs.java: ## @@ -72,6 +72,19 @@ private SystemConfigs() {} 8, Integer::parseUnsignedIn

Re: [PR] Parquet: Add system config for unsafe Parquet ID fallback. [iceberg]

2023-12-17 Thread via GitHub
rdblue commented on PR #9324: URL: https://github.com/apache/iceberg/pull/9324#issuecomment-1859284853 @jackye1995, this is the fix I mentioned for Parquet data files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th