amogh-jahagirdar commented on code in PR #9324: URL: https://github.com/apache/iceberg/pull/9324#discussion_r1430236452
########## core/src/main/java/org/apache/iceberg/SystemConfigs.java: ########## @@ -72,6 +72,19 @@ private SystemConfigs() {} 8, Integer::parseUnsignedInt); + /** @deprecated will be removed in 2.0.0; use name mapping instead */ + @Deprecated + public static final ConfigEntry<Boolean> NETFLIX_PARQUET_ID_FALLBACK_ENABLED = Review Comment: Would "UNSAFE_PARQUET_ID_FALLBACK_ENABLED" be a better name (same for the property name)? ########## core/src/main/java/org/apache/iceberg/SystemConfigs.java: ########## @@ -72,6 +72,19 @@ private SystemConfigs() {} 8, Integer::parseUnsignedInt); + /** @deprecated will be removed in 2.0.0; use name mapping instead */ + @Deprecated + public static final ConfigEntry<Boolean> NETFLIX_PARQUET_ID_FALLBACK_ENABLED = Review Comment: Would "UNSAFE_PARQUET_ID_FALLBACK_ENABLED" be a better name (same for the actual property name)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org