rdblue commented on code in PR #9324: URL: https://github.com/apache/iceberg/pull/9324#discussion_r1462220664
########## parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java: ########## @@ -1119,27 +1120,29 @@ public <D> CloseableIterable<D> build() { ParquetReadOptions options = optionsBuilder.build(); + NameMapping mapping; Review Comment: I went to add this, but then I thought it was a bit confusing to have both the field and method. I think it should be okay to have an extra variable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org