aokolnychyi commented on code in PR #9324:
URL: https://github.com/apache/iceberg/pull/9324#discussion_r1457972686


##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -1119,27 +1120,29 @@ public <D> CloseableIterable<D> build() {
 
         ParquetReadOptions options = optionsBuilder.build();
 
+        NameMapping mapping;

Review Comment:
   Optional: You could also check the system property when picking the default 
value in the constructor or add a method called `nameMapping()` to avoid two 
variables with similar names in `build()`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to