Re: [PR] Migrate other files in Core to JUnit5 [iceberg]

nastra merged PR #10027: URL: https://github.com/apache/iceberg/pull/10027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Migrate other files in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #10027: URL: https://github.com/apache/iceberg/pull/10027#discussion_r1537425697 ## core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java: ## @@ -1102,19 +1050,17 @@ public void testExpireWithDefaultSnapshotAge() { // rely solely o

Re: [PR] Migrate other files in Core to JUnit5 [iceberg]

nastra commented on code in PR #10027: URL: https://github.com/apache/iceberg/pull/10027#discussion_r1537424515 ## core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java: ## @@ -1102,19 +1050,17 @@ public void testExpireWithDefaultSnapshotAge() { // rely solely on d

Re: [PR] Migrate other files in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #10027: URL: https://github.com/apache/iceberg/pull/10027#discussion_r1537416747 ## core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java: ## @@ -1102,19 +1050,17 @@ public void testExpireWithDefaultSnapshotAge() { // rely solely o

Re: [PR] Migrate other files in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #10027: URL: https://github.com/apache/iceberg/pull/10027#discussion_r1537416747 ## core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java: ## @@ -1102,19 +1050,17 @@ public void testExpireWithDefaultSnapshotAge() { // rely solely o

Re: [PR] Migrate other files in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #10027: URL: https://github.com/apache/iceberg/pull/10027#discussion_r1537402730 ## core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java: ## @@ -136,43 +123,37 @@ public void testExpireOlderThanWithDelete() { removeSnapshots(ta

Re: [PR] Migrate other files in Core to JUnit5 [iceberg]

tomtongue commented on PR #10027: URL: https://github.com/apache/iceberg/pull/10027#issuecomment-2017729873 > > @nastra Could you review this PR? > > Just let you know, the following two classes in `org/apache/iceberg` will be migrated: > > > > * `TestWapWorkflow` > > * `TestMet

Re: [PR] Migrate other files in Core to JUnit5 [iceberg]

nastra commented on PR #10027: URL: https://github.com/apache/iceberg/pull/10027#issuecomment-2017686753 > @nastra Could you review this PR? > > Just let you know, the following two classes in `org/apache/iceberg` will be migrated: > > * `TestWapWorkflow` > * `TestMetrics` (

Re: [PR] Migrate other files in Core to JUnit5 [iceberg]

nastra commented on code in PR #10027: URL: https://github.com/apache/iceberg/pull/10027#discussion_r1537370506 ## core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java: ## @@ -1102,19 +1050,17 @@ public void testExpireWithDefaultSnapshotAge() { // rely solely on d

Re: [PR] Migrate other files in Core to JUnit5 [iceberg]

nastra commented on code in PR #10027: URL: https://github.com/apache/iceberg/pull/10027#discussion_r1537368676 ## core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java: ## @@ -257,32 +229,30 @@ public void testExpireOlderThanWithRollback() { removeSnapshots(tab

Re: [PR] Migrate other files in Core to JUnit5 [iceberg]

nastra commented on code in PR #10027: URL: https://github.com/apache/iceberg/pull/10027#discussion_r1537367647 ## core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java: ## @@ -202,39 +182,32 @@ public void testExpireOlderThanWithDeleteInMergedManifests() { rem

Re: [PR] Migrate other files in Core to JUnit5 [iceberg]

nastra commented on code in PR #10027: URL: https://github.com/apache/iceberg/pull/10027#discussion_r1537366557 ## core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java: ## @@ -136,43 +123,37 @@ public void testExpireOlderThanWithDelete() { removeSnapshots(table

Re: [PR] Migrate other files in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #10027: URL: https://github.com/apache/iceberg/pull/10027#discussion_r1537319084 ## core/src/test/java/org/apache/iceberg/TestSplitPlanning.java: ## @@ -33,40 +38,34 @@ import org.apache.iceberg.relocated.com.google.common.collect.Iterables; i

Re: [PR] Migrate other files in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #10027: URL: https://github.com/apache/iceberg/pull/10027#discussion_r1537319084 ## core/src/test/java/org/apache/iceberg/TestSplitPlanning.java: ## @@ -33,40 +38,34 @@ import org.apache.iceberg.relocated.com.google.common.collect.Iterables; i

Re: [PR] Migrate other files in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #10027: URL: https://github.com/apache/iceberg/pull/10027#discussion_r1537319084 ## core/src/test/java/org/apache/iceberg/TestSplitPlanning.java: ## @@ -33,40 +38,34 @@ import org.apache.iceberg.relocated.com.google.common.collect.Iterables; i

Re: [PR] Migrate other files in Core to JUnit5 [iceberg]

nastra commented on code in PR #10027: URL: https://github.com/apache/iceberg/pull/10027#discussion_r1537193892 ## core/src/test/java/org/apache/iceberg/TestSplitPlanning.java: ## @@ -33,40 +38,34 @@ import org.apache.iceberg.relocated.com.google.common.collect.Iterables; impo

Re: [PR] Migrate other files in Core to JUnit5 [iceberg]

tomtongue commented on PR #10027: URL: https://github.com/apache/iceberg/pull/10027#issuecomment-2017151496 @nastra Could you review this PR? The following two classes in `org/apache/iceberg` need to be migrated for now: * `TestWapWorkflow` * `TestMetrics` (this class is related