tomtongue commented on code in PR #10027:
URL: https://github.com/apache/iceberg/pull/10027#discussion_r1537416747
##########
core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:
##########
@@ -1102,19 +1050,17 @@ public void testExpireWithDefaultSnapshotAge() {
// rely solely on default configs
removeSnapshots(table).deleteWith(deletedFiles::add).commit();
- Assert.assertEquals(
- "Should not change current snapshot", thirdSnapshot,
table.currentSnapshot());
- Assert.assertEquals("Should keep 1 snapshot", 1,
Iterables.size(table.snapshots()));
- Assert.assertEquals(
- "Should remove expired manifest lists",
- Sets.newHashSet(
- firstSnapshot.manifestListLocation(),
secondSnapshot.manifestListLocation()),
- deletedFiles);
+ assertThat(table.currentSnapshot()).isEqualTo(thirdSnapshot);
+ assertThat(table.snapshots()).hasSize(1);
+ assertThat(deletedFiles)
+ .isEqualTo(
Review Comment:
The order of `firstSnapshot.manifestLocation` and
`secondSnapshot.manifestLocation` depends on the hashset values, so the order
is not always the same. So, this part needs to use `isEqualTo`, or
`containsExactlyInAnyOrder`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
