nastra commented on code in PR #10027:
URL: https://github.com/apache/iceberg/pull/10027#discussion_r1537368676
##########
core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:
##########
@@ -257,32 +229,30 @@ public void testExpireOlderThanWithRollback() {
removeSnapshots(table).expireOlderThan(tAfterCommits).deleteWith(deletedFiles::add).commit();
- Assert.assertEquals(
- "Expire should not change current snapshot",
- snapshotId,
- table.currentSnapshot().snapshotId());
- Assert.assertNotNull(
- "Expire should keep the oldest snapshot, current",
- table.snapshot(firstSnapshot.snapshotId()));
- Assert.assertNull(
- "Expire should remove the orphaned snapshot",
table.snapshot(secondSnapshot.snapshotId()));
-
- Assert.assertEquals(
- "Should remove expired manifest lists and reverted appended data file",
- Sets.newHashSet(
- secondSnapshot.manifestListLocation(), // snapshot expired
- Iterables.getOnlyElement(secondSnapshotManifests)
- .path()), // manifest is no longer referenced
- deletedFiles);
+ assertThat(table.currentSnapshot().snapshotId()).isEqualTo(snapshotId);
+ assertThat(table.snapshot(firstSnapshot.snapshotId()))
+ .as("Expire should keep the oldest snapshot, current")
+ .isNotNull();
+ assertThat(table.snapshot(secondSnapshot.snapshotId()))
+ .as("Expire should remove the orphaned snapshot")
+ .isNull();
+
+ assertThat(deletedFiles)
+ .as("Should remove expired manifest lists and reverted appended data
file")
+ .isEqualTo(
+ Sets.newHashSet(
+ secondSnapshot.manifestListLocation(), // snapshot expired
+ Iterables.getOnlyElement(secondSnapshotManifests)
Review Comment:
can we avoid using `Iterables` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
